From: Wolfram Sang <wsa@kernel.org>
To: Lin Yujun <linyujun809@huawei.com>
Cc: a.zummo@towertech.it, alexandre.belloni@bootlin.com,
mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com,
akpm@linux-foundation.org, wim@iguana.be,
linux-rtc@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] rtc: stmp3xxx: Add failure handling for stmp3xxx_wdt_register()
Date: Thu, 15 Sep 2022 00:02:23 +0100 [thread overview]
Message-ID: <YyJdf1AswoJNUcu0@shikoro> (raw)
In-Reply-To: <20220914032159.94812-1-linyujun809@huawei.com>
[-- Attachment #1.1: Type: text/plain, Size: 222 bytes --]
> + if (rc)
> + platform_device_put(wdt_pdev);
This is correct, thanks.
> + } else {
> + dev_err(&rtc_pdev->dev,
> + "failed to allocate stmp3xxx_rtc_wdt\n");
This is superfluous because rc is initialized to -1.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-14 23:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 3:21 [PATCH -next] rtc: stmp3xxx: Add failure handling for stmp3xxx_wdt_register() Lin Yujun
2022-09-14 23:02 ` Wolfram Sang [this message]
2022-09-15 1:29 ` linyujun (C)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YyJdf1AswoJNUcu0@shikoro \
--to=wsa@kernel.org \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linyujun809@huawei.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox