From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EA965ECAAD3 for ; Wed, 14 Sep 2022 23:03:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=g0PRlujPehphHrJf/YWBAWcMlHF1+mATP2/oxKYpG2M=; b=xrTY1GMIyBH5h9eaeWy/VtatSx ElHmFbYSKAqWqxd7eBTy+bWC1TTZyjvMESjmueATgCOnQHPbk4rTYS56bPdMonBRm6aA154hVBa76 wSCUUBcJN5rMQAVurPfEJB83K/R5KRXcxOx8h2mQAjfvC9gUBriSRUZdpft7avgE1+elUmHeW4j4I RbeAYIRmf2bvrFdl2ZTy+fxvhsCzk5Pzu4N6YJi89L9tN4jiqGgbxP56mUb+/gPLvmuTNsrPQ1wji HRsKS14lIso5YaIcrlQ+ngJGfFP9VxiO9r14Mq4cawYdy11ZNerpYglVv/niCm/NaIWGWdvc0EN0H o0sFCA/g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oYbOs-00Bl4s-4V; Wed, 14 Sep 2022 23:02:34 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oYbOp-00Bkvw-2e for linux-arm-kernel@lists.infradead.org; Wed, 14 Sep 2022 23:02:32 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B432FB81D04; Wed, 14 Sep 2022 23:02:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EB03EC433D6; Wed, 14 Sep 2022 23:02:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663196547; bh=3kkWgbvO9bEVvPrgr2yHaS27i2sauSwrvj21/TsPcVs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iC0zA2V4RI+NMWe8YKz6QNGcKu/qYLXVoyzGDJpptjnKTYzSmV9TlzgX7O8p0hAPL r/vKNEumu+IdDPwO08xicOWw7CS/e5MxkGfsyreKLVbASuxFuJ/hOda/OMxgSRUMiJ r3x46I14i4CTy3hz5yDSoqkPUgVaCk1E3SiiOjTcXAWUVLIPIKplKPaghad7SO9Kyi oWL+WnpnvMkIKFQj3bcv3IeSzW5AVkvpu5HQ19bxK9Aphi69CAvwc1dnlNGTLrDFqQ Wr0WC8tZFFxvdkbG+UUBVHEuAt+H8VSoljOBGiwSiBJ787Jsb3ZhqLk0hvFpkm8WDP IWhYdh1K2TNlQ== Date: Thu, 15 Sep 2022 00:02:23 +0100 From: Wolfram Sang To: Lin Yujun Cc: a.zummo@towertech.it, alexandre.belloni@bootlin.com, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, akpm@linux-foundation.org, wim@iguana.be, linux-rtc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] rtc: stmp3xxx: Add failure handling for stmp3xxx_wdt_register() Message-ID: Mail-Followup-To: Wolfram Sang , Lin Yujun , a.zummo@towertech.it, alexandre.belloni@bootlin.com, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, akpm@linux-foundation.org, wim@iguana.be, linux-rtc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220914032159.94812-1-linyujun809@huawei.com> MIME-Version: 1.0 In-Reply-To: <20220914032159.94812-1-linyujun809@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220914_160231_322792_345CA39C X-CRM114-Status: GOOD ( 12.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0342880516981749802==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0342880516981749802== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="0GaYQqpmyMEinp5d" Content-Disposition: inline --0GaYQqpmyMEinp5d Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > + if (rc) > + platform_device_put(wdt_pdev); This is correct, thanks. > + } else { > + dev_err(&rtc_pdev->dev, > + "failed to allocate stmp3xxx_rtc_wdt\n"); This is superfluous because rc is initialized to -1. --0GaYQqpmyMEinp5d Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmMiXX8ACgkQFA3kzBSg KbYo2RAAiL2PQuOoLXMbiSpW7Xq2C7tLSYErAQDhF4eWx/rfgxJ6+iwsqL0iaCyH ehlDH+yrJivfDTpsOlj+u/CMoNq+PQTbKK82WLeSD86L8/gT4jeCFq1w4LDPdv4Y C2xmtQngRYrnd+LZwRECDoTSL/yzoW7+kdJ59HoPEvwSIEDd8yVgpiyxJ/yX6T1t KkT21eZBKhnAUw5SrKtSthUu/KCDyciHQFnwC7b8AyecgdmoWy+8MIjmulnyNBn7 sINWTsKy3q0kQLAnILl2FeCnuYshc7RK+pgu79Pq3ZZGdD4PvV7kIZhH3NtTO2q1 +yzhIEPeIYSM0aVEAdrZstk1waorixEkQY6Q4yAN2ibDBQN9KoSI7ztHkIrGUU0J k4B+k3KaJCUJ/QLsvsme/wgA5+9Qdo8tlu3QJepCTzyGpEyrpVEBMa1rps204JxX LYS8ivW31wEj+PVOhKWc09VnxzQGnteB7lkTcan8Y+ZQsz1P4dMW8Tx9Q4Uvclgt dAyztAxGZCRBiNzHKR3som5pexW31dE3T7DEKbZoJoquoyfsNdr+43ln4xPNlLv+ xE355xb5Q/7lzsNnJEmYH0ep4z2lQVuwzmuxWgum1TA1WqVlqGAM89klDqPZ6Yi/ RrtwsKkTq0SoNBVex8j9GvcIbDkL9bAeVxfKBMmvSST7MYHb8kI= =E9lP -----END PGP SIGNATURE----- --0GaYQqpmyMEinp5d-- --===============0342880516981749802== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0342880516981749802==--