From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 271FCC54EE9 for ; Fri, 16 Sep 2022 12:27:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eGXjBs1usdxt0sHtAhxs7f1jN8MjVccjKWHam9ZT9Q8=; b=kfvK+n/9Dfc6oB Z/te68tQZrAfwSdZUzSwOj4MOKvAICxbJFsNJgDnFqnQqlMdV96GnVMLpDF/UiWVkqbf1pIPVmZTR WTMrH+2dHZbmaDWiEIkETSsqx+a5UalRViiDvX0BD8ShT44RszylPm0YkGuynzMHx6gGndyDsq6OG 4b4dWBuFJyN+2ZgTCoZitx+75qOhcxAbarlYv6HcCrOPaWUP7VqM+wiIi4MMrVCVMouXyNOhNOzFP GkdhV26mPkA1m9XcsJf1Z/Tf41u/AE2PA6mWIMCjkBJCFuMOIrPh8MjKuzPIfXER3sPc5iuzwwvUL Il/Gl0UXfx0eThISRQgw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oZAQt-00DBGt-W4; Fri, 16 Sep 2022 12:27:00 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oZAQp-00DBCR-MT for linux-arm-kernel@lists.infradead.org; Fri, 16 Sep 2022 12:26:58 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DCCF6B82698; Fri, 16 Sep 2022 12:26:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9E8ADC433C1; Fri, 16 Sep 2022 12:26:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663331209; bh=AW6TF25zOisYUbOOZkTVJzAVomJgQKWT2gCcg/cUS7A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Tsxuq501+aB/6YwnSPXSvYKXkOY2FP4N1HJCXgpbMvAQqOEeKpB0490Ngi8RdqU4d uzWOsi3chvT1t8Bijl+HJPoDjiKbv0mA5yUghmQjbO1risXyPzYk3Ouh7tZfHZhSX9 tqwnQI9dGBt1oF1lCrbrYq+Uqicyp1VBd5q1G64c0VbzeAGsMXMuMEAnFQUCJGFmm4 JuVeQPa5GQUwq+yvGS8da8mPJ22DrUbcgvShJQl3lwf4qGt4pEBzaga3wYd1z264YC rdRexfnTJZZvXG8YR/W17Ga8S1mulbVMPI+N+PqvxewNQv05Erj4i1MQA4FqSU0FWH eKF1qUVhkdXSA== Date: Fri, 16 Sep 2022 14:26:43 +0200 From: Lorenzo Pieralisi To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Thomas Petazzoni , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/2] PCI: mvebu: use BIT() and GENMASK() macros instead of hardcoded hex values Message-ID: References: <20220905185150.22220-1-pali@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220905185150.22220-1-pali@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220916_052655_899944_8ABCBCE8 X-CRM114-Status: GOOD ( 15.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 05, 2022 at 08:51:49PM +0200, Pali Roh=E1r wrote: You must add a commit log, ditto for (2/2). Thanks, Lorenzo > Signed-off-by: Pali Roh=E1r > --- > drivers/pci/controller/pci-mvebu.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > = > diff --git a/drivers/pci/controller/pci-mvebu.c b/drivers/pci/controller/= pci-mvebu.c > index 8bde4727aca4..c222dc189567 100644 > --- a/drivers/pci/controller/pci-mvebu.c > +++ b/drivers/pci/controller/pci-mvebu.c > @@ -44,7 +44,7 @@ > #define PCIE_WIN5_BASE_OFF 0x1884 > #define PCIE_WIN5_REMAP_OFF 0x188c > #define PCIE_CONF_ADDR_OFF 0x18f8 > -#define PCIE_CONF_ADDR_EN 0x80000000 > +#define PCIE_CONF_ADDR_EN BIT(31) > #define PCIE_CONF_REG(r) ((((r) & 0xf00) << 16) | ((r) & 0xfc)) > #define PCIE_CONF_BUS(b) (((b) & 0xff) << 16) > #define PCIE_CONF_DEV(d) (((d) & 0x1f) << 11) > @@ -70,13 +70,13 @@ > #define PCIE_INT_ERR_MASK (PCIE_INT_ERR_FATAL | PCIE_INT_ERR_NONFATAL = | PCIE_INT_ERR_COR) > #define PCIE_INT_ALL_MASK GENMASK(31, 0) > #define PCIE_CTRL_OFF 0x1a00 > -#define PCIE_CTRL_X1_MODE 0x0001 > +#define PCIE_CTRL_X1_MODE BIT(0) > #define PCIE_CTRL_RC_MODE BIT(1) > #define PCIE_CTRL_MASTER_HOT_RESET BIT(24) > #define PCIE_STAT_OFF 0x1a04 > -#define PCIE_STAT_BUS 0xff00 > -#define PCIE_STAT_DEV 0x1f0000 > #define PCIE_STAT_LINK_DOWN BIT(0) > +#define PCIE_STAT_BUS GENMASK(15, 8) > +#define PCIE_STAT_DEV GENMASK(20, 16) > #define PCIE_SSPL_OFF 0x1a0c > #define PCIE_SSPL_VALUE_SHIFT 0 > #define PCIE_SSPL_VALUE_MASK GENMASK(7, 0) > -- = > 2.20.1 > = > = > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel