From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34847ECAAD8 for ; Tue, 20 Sep 2022 11:28:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Kr8G0xVO0ksDih28nuViJEZadcK4TmEmMZdsKnRkXkw=; b=ZO0pYgYVm/U6ky sZlZv7X3a3h0+A7JLj4FCIRKJej4nGXxdJH1JDqkY/DIT/CTEnH38L0dbWrsVuNrVrzaDxaHcaQIP cXM9hCLy06kdoEmGc2Vp+/80eWi0A+RJMGQzMYvAui+XkRRpDGhjEto5GMtB7c21LLktEnZ/iHGSl CQhxyFil1cpuH+1EzvQbjknt+CeXDMzhPnKCnEdS+IzpJLN4rBzQfH4ARylXbps8Y4DlBN6Io0Um2 amsdUmrzPdYxm4SFaVMhuvBQjt4JMMO7KhQ+Y3sRPUX3wwSgnAM328/DZTAf1//iK870Yr9VIi62h AvdpHicUccTEWHVU3D2w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oabPe-003HqI-31; Tue, 20 Sep 2022 11:27:38 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oabPb-003HoF-MY for linux-arm-kernel@lists.infradead.org; Tue, 20 Sep 2022 11:27:37 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CF7DA61A24; Tue, 20 Sep 2022 11:27:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 60EDFC433D6; Tue, 20 Sep 2022 11:27:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663673254; bh=WdzZGXEytt0PPm4g3TwrmXy6TK0VHyA/hs9By4NFYQk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BsfwkzcRhJvcU9X5zcNx9fyzgcy+YMt8vgjkBA5x4kioU21pcZiNhPDN0L2RjbW0/ I1AFl3bpBeQWwW9+tC3k5xeuMXZrro+fhh99xRa1Uu2gyCklKqCVVPHdGwJHFDWCCr BGmEFkPIjzNIzNs2bOTVGrlVVI171oy3U9iSYILabxaDl2q+sIHwC5xjvmaq/ZUUuv PvfMMTn3SNmmsf6SyQ+V5MWTNQTWtW/PmwUYaM1RMGzUbTn7ZNy91WZLVSqNbOLz9J JFvmS4fBgGh9dWCEXBFwyciiHd0SGqP0N+X86xc1Wo1qlEdjYYasJdzmSXDcpJxmE2 S/avBTqkcs3Ug== Date: Tue, 20 Sep 2022 16:57:29 +0530 From: Vinod Koul To: Sarath Babu Naidu Gaddam Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, lars@metafoo.de, adrianml@alumnos.upm.es, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, michal.simek@amd.com, radhey.shyam.pandey@amd.com, anirudha.sarangi@amd.com, harini.katakam@amd.com, git@xilinx.com, git@amd.com Subject: Re: [RFC V3 PATCH 0/8] Xilinx DMA enhancements and optimization Message-ID: References: <20220920055119.12634-1-sarath.babu.naidu.gaddam@amd.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220920055119.12634-1-sarath.babu.naidu.gaddam@amd.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220920_042735_812979_9B852B1D X-CRM114-Status: GOOD ( 20.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 20-09-22, 11:21, Sarath Babu Naidu Gaddam wrote: > Some background about the patch series: Xilinx Axi Ethernet device driver > (xilinx_axienet_main.c) currently has axi-dma code inside it. The goal is > to refactor axiethernet driver and use existing AXI DMA driver using > DMAEngine API. > > This patchset does feature addition and optimization to support axidma > integration with axiethernet network driver. Once axidma version is > accepted mcdma specific changes will be added in followup version. why is this tagged RFC? Is it not ready for merge? > > Changes for V2: > - Use metadata API[1] for passing metadata from dma to netdev client. > - Read irq-delay from DT. > - Remove desc_callback_valid check. > - Addressed RFC v1 comments[2]. > - Minor code refactoring. > > Changes for V3: > - Add device_config support for passing any dma client data. > - Address RFC v2 comments. > - remove hardcoding for axidma_tx_segment. > - Below review comment is in pipeline. We are facing a race issue when > addressing it. we will fix it in the next version. > "chan->idle = true; in xilinx_dma_irq_handler() needs to be gated on > the active_list being empty". > > Comments, suggestions are very welcome > > Radhey Shyam Pandey (7): > dt-bindings: dmaengine: xilinx_dma: Add xlnx,axistream-connected > property > dt-bindings: dmaengine: xilinx_dma: Add xlnx,irq-delay property > dmaengine: xilinx_dma: Pass AXI4-Stream control words to dma client > dmaengine: xilinx_dma: Increase AXI DMA transaction segment count > dmaengine: xilinx_dma: Freeup active list based on descriptor > completion bit > dmaengine: xilinx_dma: Use tasklet_hi_schedule for timing critical > usecase > dmaengine: xilinx_dma: Program interrupt delay timeout > > Sarath Babu Naidu Gaddam (1): > dmaengine: xilinx_dma: Add device_config support > > .../bindings/dma/xilinx/xilinx_dma.txt | 4 + > drivers/dma/xilinx/xilinx_dma.c | 107 ++++++++++++++++-- > include/linux/dma/xilinx_dma.h | 16 +++ > 3 files changed, 115 insertions(+), 12 deletions(-) > > -- > 2.25.1 -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel