From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1B909C6FA82 for ; Tue, 20 Sep 2022 16:10:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=N9wm20fCa2So6a7pzsEV5FQfmD8Y3Hj/oyCbvwICF7c=; b=TxW3xDUa0KWlY5 OlHwZTPg7uVv3DeEE+at7veSWtIt1uJnsotYYo8MQJJhfexWXxC385pfsPaSGs481kwU1ods5RCqf Pp0mS5dKqP6cORkXdnddMoocdDVH5nEg1VWAynwwgWj9aP7qXTk1trmGEvrMkg14B34EetTsFEnFQ Ui7mXbN5K3+fRQ0JxTh1CWn9h2P79kKayLbDc+UeE33EE8jhspsPB2SuUnAPE+UsSi1b2aut05PxI 6YWwex1XXTROjSipyhc+n/+Rclx39Y+Qssdl+qzFn/cBWfN4ykyhZ5OdILrPJ3mhBlEUXu5dBPG78 ayViuND0uX/wmXxmotBg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oafo3-0055Ca-V7; Tue, 20 Sep 2022 16:09:09 +0000 Received: from mail-bn1nam07on2088.outbound.protection.outlook.com ([40.107.212.88] helo=NAM02-BN1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oafnw-00559I-Ht; Tue, 20 Sep 2022 16:09:02 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kX8h5f8N30JIYUeqE+XMSVRWInHzdK08QCmk8sR9aBMHk8AinLy4Z+gF7jEoQYGLac+GAWZvMAtuaCWD7mvJcShDCvt43EHbaNosJYj4yaOceSP9XXiEPctz7UdI7F6Cpg+2AoKxrtzLF4aLZVpFBAV8g9A1KC/mLYjVxbL1J5Qj0jAkwdXbw52G4/CM7lIOIzp4omtQ0tCcjEOYTms39lOJ1ISWF9ss+307ea91sF1Ux4h22X4HVZnO+8myknQNFoSgXf0Sbtx8Ik4tViTC6LPAidd/o2Z1Ik9TRxYmZavfXjUxLoZwrEmLOzg4aGxh02XqKp9HDD++sgFUTDWJTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XCJs0Ez8XRGvVxWXV0IiFWq6SxmnIM6tM2AiML/jJU4=; b=P/5Fs7Hig/j7mR0KuXU05S8DHt7MDXJT2RDnL8M3h02l6WFYg4Ps4+qQhEXVEKEZy0b6DiJnqae0MfJ4wuHBYJe9YbSJ4GSF4GKl+dDRD/XUoxMK4QJWUMY/qv/p9cpKaebjBnQOfkHa1wZpqGb8FeZJu5wzuqtxH3p1UmCxUg+2nfVvS4sZrKae8I4ZZBowE7k6Qp0vc4DSmcv/uEV1jyF9vyfdvprrYk2Gqh9NW7re4iYEUSnFhCy/KDEgII8udd046GEB678NOMjMGoV9iGyzAVpe5KzDz2chPXb/8Qsm03t/Zpd+CTgy1ZwSgfE8MNnfchF0M8uVsFLHCmVpIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XCJs0Ez8XRGvVxWXV0IiFWq6SxmnIM6tM2AiML/jJU4=; b=poUJZ5SNFmFzD/y6/v+hMdH3xCCQ6477U8gTPkx88MOKiJDcM0dzbSZecY8VufvEfjstfp6HT/D0qMMMbawgoWL8iZXfvzPEKT71dQlA9jfFlBX5DP08Lrq6YuQCVDdltCuUKmNg4imnV1Vhh6r4UCBzGg0QhNaaUBsETlzETJG6829L1SOWg/vvAopa8q1QwJ+MCheMaCcD3RwAVpGTHETj+iIbhEktugrR3hHxy1Ws+vomIOyqxYAPwZtXQ63wXmsyDAE3eGiW0zZlasmuX+SW9MQLWmOJZCHsGATzLT4OlNmF+u8Xfeug7mcJwc3EJjzg+HpCrD4FTEKu7I7JsQ== Received: from BN0PR04CA0178.namprd04.prod.outlook.com (2603:10b6:408:eb::33) by BL1PR12MB5255.namprd12.prod.outlook.com (2603:10b6:208:315::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21; Tue, 20 Sep 2022 16:08:53 +0000 Received: from BN8NAM11FT048.eop-nam11.prod.protection.outlook.com (2603:10b6:408:eb:cafe::3c) by BN0PR04CA0178.outlook.office365.com (2603:10b6:408:eb::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14 via Frontend Transport; Tue, 20 Sep 2022 16:08:53 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BN8NAM11FT048.mail.protection.outlook.com (10.13.177.117) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14 via Frontend Transport; Tue, 20 Sep 2022 16:08:53 +0000 Received: from rnnvmail204.nvidia.com (10.129.68.6) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.26; Tue, 20 Sep 2022 09:08:38 -0700 Received: from drhqmail202.nvidia.com (10.126.190.181) by rnnvmail204.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Tue, 20 Sep 2022 09:08:37 -0700 Received: from drhqmail202.nvidia.com (10.126.190.181) by drhqmail202.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Tue, 20 Sep 2022 09:08:36 -0700 Received: from Asurada-Nvidia (10.127.8.14) by mail.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29 via Frontend Transport; Tue, 20 Sep 2022 09:08:35 -0700 Date: Tue, 20 Sep 2022 09:08:33 -0700 From: Nicolin Chen To: "Tian, Kevin" CC: "joro@8bytes.org" , "will@kernel.org" , "robin.murphy@arm.com" , "dwmw2@infradead.org" , "baolu.lu@linux.intel.com" , "yong.wu@mediatek.com" , "matthias.bgg@gmail.com" , "jgg@nvidia.com" , "iommu@lists.linux.dev" , "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v3 4/6] iommu: Regulate EINVAL in ->attach_dev callback functions Message-ID: References: <253f8098664f78f5b5a8a7deb816af8ad7d37122.1663227492.git.nicolinc@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT048:EE_|BL1PR12MB5255:EE_ X-MS-Office365-Filtering-Correlation-Id: 07a532ae-2bf8-4f21-e6ef-08da9b2269e6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2NsBA/oMzTtKlqYf/Igfb+KQC2SFR6h1VOFTAjMHv9D8p+gKCbbI6z6SZd8kSEmbIG/SOgvhZnqNFypTJLqlzlmoCMB234wTVPXQo2806FzxM5KcbvnHGjVCRCHRBny1gVV1KdygsLYUU+pKCS6KW6OicMhr6AtcySFHuXhiiMM2eob3ofxKhiaqxedR/0xzm5W8efWspXa35LHCYvh6bZtSlbG8tqcoEvPh/bleOY2PEHk9RIwnJk+EVrranb5eNWQbxnVxi9q6VPmNs/TYanCASk+P6YqVc7LQ56lxo9L9sQ2pSw8qWZXTzNXUbZ+J//oSBGn9kG378Jq97BzcoC2MG+AAYimgpqtKzU22UGTTekolJpnADYGVlB6xavocTLiGMX3lx3l2EvU/DY3So/+1EQRQuy+XYUJXR2Yj9gDNgsV2q0kQG7qyeh/f+DGKqXwk/rlUmoPsdzdA4Sryph4Wo4rjfpvzuaevVqtvU10e8WNwQ94Slvu19Glt3diiqn+6+JDv8Y3sEKWyE75tujyrILiS/ZXUHc6Oz7GVQZwNtXDAbq6RAy0Ob4OeWjcwqst5Q5YVfzi8IT84lh/G+whzcREJPILpJ+HOQ2W+zzZZgLPT0RPxv9DYBvqNo8Tbuj/2ZoOhn+qEzZegtFryLa1BcQaOWZcqEGC+z0C7yE5RmF5jieXxfr8m6n+lLbeHBoQfeZOyTjeLMyYK7uVIxWHBg8055OBXFdlzKx8o1natyOIk6VBkQFGk+20rr6QMZZkMM7G3t/cN0/d5zMw7oA== X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(136003)(376002)(346002)(451199015)(46966006)(40470700004)(36840700001)(36860700001)(55016003)(86362001)(82740400003)(7636003)(6916009)(40480700001)(356005)(316002)(8676002)(54906003)(40460700003)(8936002)(2906002)(4326008)(7416002)(70206006)(5660300002)(41300700001)(70586007)(426003)(336012)(82310400005)(186003)(47076005)(478600001)(33716001)(9686003)(26005);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2022 16:08:53.2092 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 07a532ae-2bf8-4f21-e6ef-08da9b2269e6 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT048.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5255 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220920_090900_838353_D6182CB8 X-CRM114-Status: GOOD ( 14.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 20, 2022 at 06:29:28AM +0000, Tian, Kevin wrote: > External email: Use caution opening links or attachments > > > > From: Nicolin Chen > > Sent: Thursday, September 15, 2022 3:59 PM > > > > diff --git a/drivers/iommu/intel/pasid.c b/drivers/iommu/intel/pasid.c > > index c5e7e8b020a5..4cadbd744b7f 100644 > > --- a/drivers/iommu/intel/pasid.c > > +++ b/drivers/iommu/intel/pasid.c > > @@ -101,8 +101,10 @@ int intel_pasid_alloc_table(struct device *dev) > > > > might_sleep(); > > info = dev_iommu_priv_get(dev); > > - if (WARN_ON(!info || !dev_is_pci(dev) || info->pasid_table)) > > - return -EINVAL; > > + if (WARN_ON(!info || !dev_is_pci(dev))) > > + return -ENODEV; > > + if (WARN_ON(info->pasid_table)) > > + return -EBUSY; > > -EEXIST. It's not a busy condition which might change sometime after. > > btw below -EVINAL in viommu should be converted to -ENODEV too > since it's a check purely on device side: > > viommu_domain_finalise() > viommu_page_size = 1UL << __ffs(viommu->pgsize_bitmap); > if (viommu_page_size > PAGE_SIZE) { > dev_err(vdev->dev, > "granule 0x%lx larger than system page size 0x%lx\n", > viommu_page_size, PAGE_SIZE); > return -EINVAL; > } Fixed both places. Thanks! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel