From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1FC41C6FA82 for ; Tue, 20 Sep 2022 18:09:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HZowTmATre/AsVBuukyE2rN/s1kJYqDFFg6MKPzQtrQ=; b=fkDFkcG1eVGWbf my9RrzfQA3Wmt2yu5EDyDqhWn06uuFOyVV576QvaXRBrdE6uYFUzyZ5ai/Ix8tfBfFJCw5SAiV5Pa FjkS5i48zMb9nbhSl6XQjIFKX71+0c8LeYLqgmGUM9AgwKVd3e9B6HRaJDDb1sWTthaYsZ6Za5I6F IbxFlfGopZvSii8LdtbjAN9SmOnDBEpEOyUG9pcIycZE9rAHTsITYiibcSXjIKsoL3JS/z2pGX5Em Rv5uutAdED+6frakRpwyCp2U0KhG5SMUhWeuVHVSdSM7K1RoeNx8G+qdBg+Mg5VD91B7gB9nRdOva rpo0zobZNqXeXlCvqaQw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oahfY-005dXG-Ro; Tue, 20 Sep 2022 18:08:28 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oahfU-005dVn-V0 for linux-arm-kernel@lists.infradead.org; Tue, 20 Sep 2022 18:08:26 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3038362C08; Tue, 20 Sep 2022 18:08:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0DAA7C433C1; Tue, 20 Sep 2022 18:08:20 +0000 (UTC) Date: Tue, 20 Sep 2022 19:08:16 +0100 From: Catalin Marinas To: Mark Brown Cc: James Clark , suzuki.poulose@arm.com, coresight@lists.linaro.org, mathieu.poirier@linaro.org, mike.leach@linaro.org, leo.yan@linaro.org, Alexander Shishkin , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] coresight: Use new autogenerated sysreg definitions Message-ID: References: <20220920134827.31738-1-james.clark@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220920_110825_054333_B16BFB12 X-CRM114-Status: GOOD ( 21.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 20, 2022 at 06:56:59PM +0100, Mark Brown wrote: > On Tue, Sep 20, 2022 at 06:07:34PM +0100, Catalin Marinas wrote: > > On Tue, Sep 20, 2022 at 05:42:38PM +0100, Catalin Marinas wrote: > > > BTW, for some reason we don't have CoreSight enabled in defconfig, not > > > even as a module. Would you mind sending a patch for this and enable (as > > > modules) all the relevant drivers? We miss any test coverage here. > > > > The PMU counters are in the same camp. Enabling them breaks the kernel > > build. I wonder whether we should go for changing the default in Kconfig > > directly rather than defconfig. > > I sent a patch for the PMU counters defconfig yesterday. The defconfig patches tend to fall through the cracks. I'll try to pick some of them up. BTW, do you plan to send a patch for the arm_spe_pmu build failures (unless you did already and I missed it): linux/drivers/perf/arm_spe_pmu.c: In function 'arm_spe_pmsevfr_res0': linux/drivers/perf/arm_spe_pmu.c:677:14: error: 'ID_AA64DFR0_PMSVER_8_2' undeclared (first use in this function); did you mean 'ID_AA64DFR0_EL1_PMSVer_IMP'? 677 | case ID_AA64DFR0_PMSVER_8_2: | ^~~~~~~~~~~~~~~~~~~~~~ | ID_AA64DFR0_EL1_PMSVer_IMP linux/drivers/perf/arm_spe_pmu.c:677:14: note: each undeclared identifier is reported only once for each function it appears in linux/drivers/perf/arm_spe_pmu.c:679:14: error: 'ID_AA64DFR0_PMSVER_8_3' undeclared (first use in this function); did you mean 'ID_AA64DFR0_EL1_PMSVer_IMP'? 679 | case ID_AA64DFR0_PMSVER_8_3: | ^~~~~~~~~~~~~~~~~~~~~~ | ID_AA64DFR0_EL1_PMSVer_IMP linux/drivers/perf/arm_spe_pmu.c: In function '__arm_spe_pmu_dev_probe': linux/drivers/perf/arm_spe_pmu.c:961:52: error: 'ID_AA64DFR0_PMSVER_SHIFT' undeclared (first use in this function); did you mean 'ID_AA64DFR0_EL1_PMSVer_SHIFT'? 961 | ID_AA64DFR0_PMSVER_SHIFT); | ^~~~~~~~~~~~~~~~~~~~~~~~ | ID_AA64DFR0_EL1_PMSVer_SHIFT -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel