From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AD869C6FA82 for ; Wed, 21 Sep 2022 03:24:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xIdDD2WTwyO2QaBwNwRkYnjhJWYGQcQeeZKN1MhZ1EA=; b=UOpQj9tK8rOYhq m9SS3BQQefqhKvrNmKg5ChDcZaSge64NVejwwsP+uAfw2rSrzuFCbh2pQBM6ooovAcHMZCCqabKGf hbaCJtarBsXtVRJIxwGj+1/LrbiT0tVopo0rNNCJLNkrKqAg8HdJ8OLY1CSoVY7348aA2o5vjVOH0 OaRFxoacdbCtklQM9iggt4O+BTeHBlO1IftM7zcqrXfwsI/Acn/ns5N0dW8rWVeuPdsW+tgnGiRwq JHhp0oBZpgbco1j5CLL7dRkuakRmtxyAxTbSNFbc8pe0NUp3D4w7aLMi9a0gas1WsyEsYO0aumQ2C tVjsKDaQrEx+wdDegJtA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oaqKk-008Wpf-Jy; Wed, 21 Sep 2022 03:23:34 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oaqKg-008WoE-Sb for linux-arm-kernel@lists.infradead.org; Wed, 21 Sep 2022 03:23:32 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2247BB816AF; Wed, 21 Sep 2022 03:23:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0DEA0C433C1; Wed, 21 Sep 2022 03:23:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663730607; bh=tzVpyonWg2wvFH3/Tacs6bLOU6Y//b6mvOx4iigfXC0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qFGCUK8m6XOUqC/W+RPNcW+hzltTEWYhYLsC6vn4QcZPjK7X/Q5v3Wsp4DyO6mCW/ HF8J6fSLb1o7u230pOMgYHPX6FPWLl2wnsbYZM0zlhiS3bMCKX/wc10qCFnh9fHEPL T4Ib6VjDiUBmnvpJyBSlYSRcVZ9M1faIp5p+PkUK0lLxPcjnIxLXFbZj9kcDdFF7v4 u+MUM1HmwkR2KU3gJi4bhpYpCMuuuoR5kPYPKoIIxQa4J+L9rcacuznW+FRhQTT+4v kiCGgwjJ+RzKyCYHo/qTr6CZ2gjfAe15zub+B71pDMEWWD6dDKxVd41nql+PuI8NFA 8mq4Dgxi8Qajg== Date: Wed, 21 Sep 2022 08:53:23 +0530 From: Vinod Koul To: Dario Binacchi Cc: linux-kernel@vger.kernel.org, linux-amarula@amarulasolutions.com, Michael Trimarchi , stable@vger.kernel.org, Fabio Estevam , NXP Linux Team , Pengutronix Kernel Team , Shawn Guo , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sascha Hauer Subject: Re: [RESEND PATCH v5 1/2] dmaengine: mxs: use platform_driver_register Message-ID: References: <20220904141020.2947725-1-dario.binacchi@amarulasolutions.com> <20220913163510.GR6477@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220920_202331_088327_80652006 X-CRM114-Status: GOOD ( 30.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 20-09-22, 19:10, Dario Binacchi wrote: > Hi Vinoud, > > On Tue, Sep 13, 2022 at 6:35 PM Sascha Hauer wrote: > > > > Hi Dario, > > > > On Sun, Sep 04, 2022 at 04:10:19PM +0200, Dario Binacchi wrote: > > > Driver registration fails on SOC imx8mn as its supplier, the clock > > > control module, is probed later than subsys initcall level. This driver > > > uses platform_driver_probe which is not compatible with deferred probing > > > and won't be probed again later if probe function fails due to clock not > > > being available at that time. > > > > > > This patch replaces the use of platform_driver_probe with > > > platform_driver_register which will allow probing the driver later again > > > when the clock control module will be available. > > > > > > Fixes: a580b8c5429a ("dmaengine: mxs-dma: add dma support for i.MX23/28") > > > Co-developed-by: Michael Trimarchi > > > Signed-off-by: Michael Trimarchi > > > Signed-off-by: Dario Binacchi > > > Cc: stable@vger.kernel.org > > > > How I see it v3 of this patch is perfectly fine and should be taken > > instead of this one. I just commented that to v3. > > > > Not sure if Vinod would take v3, or if you should resend v3 as v6 > > instead. If you do, you can add my Acked-by. > > > > Vinod, please let us know what you prefer. > > Could you please let me know how to proceed? This patch has been pending for > a while and it's a real shame as the change is minimal and fixes a > real issue that is > still present in the mainline and stable kernels. Ooops, Somehow this seems to have really slipped. Sorry I owe you an apology for this I am still not sure of this patch yet, lets get it right and merged quickly. I will send my review later today -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel