From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 69BC5C32771 for ; Wed, 21 Sep 2022 12:51:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MLy58YfhJWwhmjQwnwMp5UZl4/tt6oNLR+wdYwv22Y4=; b=Uj9YbXnDn6FPXb GolUqyNr66nRJTOTaoT1Dd35cw2eVRH1prpfejp8d56NszGast9mJ7MxNXdDsQu6ZVcX5dxeo7GxB HwhxCpaSMKfltVWNntlDpCq48FWvGy7w2ivRnzqbyO7K099Bz4CL1cPRblWOlYtQ3OzF/0NQV1Gg/ 8catGrtxzHFiD4GQ2YdSx4t85KZlZNmo1zJFf7WxO2gesVWe+lkKpk3RI29OT9VMa/QG0eDwog9g4 Z2Wml5a6zEBqQOEtEU09AnjdMwyJ07VyPd9oyhFfBIIUXE939wxvCecgLc8lG1IumRn8fdh9uBnhv YUkS68Hph5zEE09CzhwQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oazBR-00BLdX-Au; Wed, 21 Sep 2022 12:50:33 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oazBO-00BLch-Ra for linux-arm-kernel@lists.infradead.org; Wed, 21 Sep 2022 12:50:32 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5D3EF6249D; Wed, 21 Sep 2022 12:50:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F88BC433D6; Wed, 21 Sep 2022 12:50:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663764628; bh=kLAs3Of68tjCVcClxahDtNTJthmU+CNanmr3EQ7GBFE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=I/3gn7vNZX+AgEMNdBAeJVaqjY9XuCF3vYoSTPMNAhdqDeGxmvFI+pSvBKa9xmqmW oLzMcxCxxhDmM+gs845MPcVfsv+iNN3+9XTP8xtFuIE9KG3YO50qezAWqXAZ3C5Baj PwEPbjDhzBveKOgp29P2N1azYzLpqFExjU/NwB1gAOWd/kkjbjq8KhUf2B4VIhMBBk kL5ziCe4KpCjpyJjV0ZURr4iw4il46YbqQA8x8D3vpHlde0bcgcxfsyztvghkY3fRn 3TQSM+yTa22ZFFaYODJtxLvRkV4+yP7YXr3mTWrMb+LQQI2tBzVfb3+dlFYTWEMJMt 2wyYZMY7vC9LA== Date: Wed, 21 Sep 2022 18:20:24 +0530 From: Vinod Koul To: Sascha Hauer Cc: Dario Binacchi , linux-kernel@vger.kernel.org, linux-amarula@amarulasolutions.com, Michael Trimarchi , stable@vger.kernel.org, Fabio Estevam , NXP Linux Team , Pengutronix Kernel Team , Shawn Guo , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [RESEND PATCH v5 1/2] dmaengine: mxs: use platform_driver_register Message-ID: References: <20220904141020.2947725-1-dario.binacchi@amarulasolutions.com> <20220913163510.GR6477@pengutronix.de> <20220921103930.GM12909@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220921103930.GM12909@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220921_055030_971455_D03E52EC X-CRM114-Status: GOOD ( 29.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 21-09-22, 12:39, Sascha Hauer wrote: > On Wed, Sep 21, 2022 at 08:53:23AM +0530, Vinod Koul wrote: > > On 20-09-22, 19:10, Dario Binacchi wrote: > > > > How I see it v3 of this patch is perfectly fine and should be taken > > > > instead of this one. I just commented that to v3. > > > > > > > > Not sure if Vinod would take v3, or if you should resend v3 as v6 > > > > instead. If you do, you can add my Acked-by. > > > > > > > > Vinod, please let us know what you prefer. > > > > > > Could you please let me know how to proceed? This patch has been pending for > > > a while and it's a real shame as the change is minimal and fixes a > > > real issue that is > > > still present in the mainline and stable kernels. > > > > Ooops, Somehow this seems to have really slipped. Sorry I owe you an > > apology for this > > > > I am still not sure of this patch yet, lets get it right and merged > > quickly. I will send my review later today > > I just realized that unlike what I said v3 of this patch is still wrong > as it leaves the __init annotation on mxs_dma_init() which is called > from (non __init) mxs_dma_probe(). v3 probably doesn't give a section > mismatch warning because mxs_dma_init() is inlined. > > Really v2 is the one we should take which is at: hmmm, looking at the old revs, that does look sane. My question was why __init change is there, it needs to be documented and if there are two different reasons, add that I agree rev 2 is the right things to do and changelog needs to add why we dropped __init (i dont think this should be a different patchset as that leads to warnings ... > https://lore.kernel.org/linux-arm-kernel/20220523132247.1429321-1-dario.binacchi@amarulasolutions.com/T/ -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel