From: Tzung-Bi Shih <tzungbi@kernel.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: broonie@kernel.org, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, tiwai@suse.com,
lgirdwood@gmail.com, linux-mediatek@lists.infradead.org,
trevor.wu@mediatek.com, matthias.bgg@gmail.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ASoC: mediatek: mt8195-mt6359: Use snd_soc_pm_ops instead of custom ops
Date: Thu, 22 Sep 2022 19:26:21 +0800 [thread overview]
Message-ID: <YyxGXXSp2JD9a6ah@google.com> (raw)
In-Reply-To: <20220922103502.49981-1-angelogioacchino.delregno@collabora.com>
On Thu, Sep 22, 2022 at 12:35:02PM +0200, AngeloGioacchino Del Regno wrote:
> -static const struct dev_pm_ops mt8195_mt6359_pm_ops = {
> - .poweroff = snd_soc_poweroff,
> - .restore = snd_soc_resume,
> -};
> -
> static struct platform_driver mt8195_mt6359_driver = {
> .driver = {
> .name = "mt8195_mt6359",
> .of_match_table = mt8195_mt6359_dt_match,
> - .pm = &mt8195_mt6359_pm_ops,
> + .pm = &snd_soc_pm_ops,
snd_soc_pm_ops[1] sets some more fields. I'm not quite sure whether
it would introduce any side effect or not. Perhaps Trevor could
provide some suggestions.
[1]: https://elixir.bootlin.com/linux/v5.19.10/source/sound/soc/soc-core.c#L2150
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-22 11:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-22 10:35 [PATCH] ASoC: mediatek: mt8195-mt6359: Use snd_soc_pm_ops instead of custom ops AngeloGioacchino Del Regno
2022-09-22 11:26 ` Tzung-Bi Shih [this message]
2022-09-22 13:30 ` Mark Brown
2022-09-22 14:10 ` AngeloGioacchino Del Regno
2022-09-23 4:39 ` Trevor Wu
2022-09-23 5:03 ` Tzung-Bi Shih
2022-09-23 17:06 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YyxGXXSp2JD9a6ah@google.com \
--to=tzungbi@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=tiwai@suse.com \
--cc=trevor.wu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).