Re: [PATCH RESEND v3 14/17] EDAC/synopsys: Detach Zynq DDRC controller support

Borislav Petkov
2022-09-30T14:43:50Z

On Fri, Sep 30, 2022 at 02:27:09AM +0300, Serge Semin wrote:
> It was a bad idea in the first place to combine two absolutely different
> controllers support in a single driver [1]. It caused having an additional
> level of abstraction, which obviously have needlessly overcomplicated the
> driver and as such caused many problems in the new main controller
> features support implementation. The solution looks even more unreasonable
> now seeing the justification of having both controllers support in a
> single driver hasn't been implemented by the original code author [2].

Yeah, no, you need to give more concrete details here.

Why exactly is this a problem?

Are you saying that if synopsys puts out 10 incompatible memory
controllers, we should have 10 separate EDAC drivers?

Hell no.

synopsys_edac.c is not a huge file and the probe logic which matches
which synps_platform_data to load is pretty straight-forward to me.

But maybe I'm missing something so please explain in detail what the
actual problems with this are?

Thx.

--
Regards/Gruss,
Boris.