From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 888CCC07E9D for ; Mon, 26 Sep 2022 10:51:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=r5xwjRRiGMHX5o1sJFy+8rMZCm1v+JzwmFAYf3948YU=; b=gBayd0jZBothFr d3NZ+51jjkVEGjogH/d78r9fJ42AeHWVtwtLrFVZYr74kkUmn1S/Ya+eIUBabcCe1PS7d+Dfk+wt7 y5otdcZcWqlwyLB3TJTqx476YvXf4mlPmJgaQqMREr2ZwX5FS+8UbU500YQdSN3tWUcEcKBqEC2k+ 5BARG7oW6Ta/7yA1QfH150JKYPOKSvWMsEuHC7Ygbyf6Uhbk9iuqrHsekfTBCiqp3I03Eybtdlkld 4XH9OfJI9I+YYByqVcBZfHuZ6wTwdyp3W3nxcr/Ov11IChYYI/0SY2tqW2DNWOiKd6gyhCr6w1iIX AzKTmbUnFsHT4ebdY2Sg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oclhO-004J8S-Cb; Mon, 26 Sep 2022 10:50:54 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oclh8-004IvC-3o for linux-arm-kernel@lists.infradead.org; Mon, 26 Sep 2022 10:50:40 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 064EED6E; Mon, 26 Sep 2022 03:50:40 -0700 (PDT) Received: from e120937-lin (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C0DC13F66F; Mon, 26 Sep 2022 03:50:32 -0700 (PDT) Date: Mon, 26 Sep 2022 11:50:26 +0100 From: Cristian Marussi To: Yuan Can Cc: sudeep.holla@arm.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] firmware: arm_scmi: Use dev_err_probe() to simplify code Message-ID: References: <20220924025146.34976-1-yuancan@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220924025146.34976-1-yuancan@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220926_035038_282471_58EAA609 X-CRM114-Status: GOOD ( 17.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Sep 24, 2022 at 02:51:46AM +0000, Yuan Can wrote: > In the probe path, dev_err() can be replaced with dev_err_probe() > which will check if error code is -EPROBE_DEFER and prints the > error name. It also sets the defer probe reason which can be > checked later through debugfs. > > Signed-off-by: Yuan Can Hi Yuan, LGTM, thanks for this. Reviewed-by: Cristian Marussi Thanks, Cristian > --- > drivers/firmware/arm_scmi/mailbox.c | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) > > diff --git a/drivers/firmware/arm_scmi/mailbox.c b/drivers/firmware/arm_scmi/mailbox.c > index 08ff4d110beb..85b84be85458 100644 > --- a/drivers/firmware/arm_scmi/mailbox.c > +++ b/drivers/firmware/arm_scmi/mailbox.c > @@ -94,13 +94,10 @@ static int mailbox_chan_setup(struct scmi_chan_info *cinfo, struct device *dev, > cl->knows_txdone = tx; > > smbox->chan = mbox_request_channel(cl, tx ? 0 : 1); > - if (IS_ERR(smbox->chan)) { > - ret = PTR_ERR(smbox->chan); > - if (ret != -EPROBE_DEFER) > - dev_err(cdev, "failed to request SCMI %s mailbox\n", > - tx ? "Tx" : "Rx"); > - return ret; > - } > + if (IS_ERR(smbox->chan)) > + return dev_err_probe(cdev, PTR_ERR(smbox->chan), > + "failed to request SCMI %s mailbox\n", > + tx ? "Tx" : "Rx"); > > cinfo->transport_info = smbox; > smbox->cinfo = cinfo; > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel