From: Lorenzo Pieralisi <lpieralisi@kernel.org>
To: Bjorn Helgaas <helgaas@kernel.org>, gregkh@linuxfoundation.org
Cc: cgel.zte@gmail.com, robh@kernel.org, kw@linux.com,
bhelgaas@google.com, rjui@broadcom.com, sbranden@broadcom.com,
bcm-kernel-feedback-list@broadcom.com, linux-pci@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
ye xingchen <ye.xingchen@zte.com.cn>,
Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH linux-next] PCI: iproc: Remove the unneeded result variable
Date: Tue, 27 Sep 2022 14:07:52 +0200 [thread overview]
Message-ID: <YzLnmGiU7qcWkeH2@lpieralisi> (raw)
In-Reply-To: <20220906212520.GA45166@bhelgaas>
[+Greg]
On Tue, Sep 06, 2022 at 04:25:20PM -0500, Bjorn Helgaas wrote:
> On Tue, Sep 06, 2022 at 07:16:36AM +0000, cgel.zte@gmail.com wrote:
> > From: ye xingchen <ye.xingchen@zte.com.cn>
> >
> > Return the value iproc_pcie_setup_ib() directly instead of storing it in
> > another redundant variable.
> >
> > Reported-by: Zeal Robot <zealci@zte.com.cn>
> > Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
>
> This patch itself is fine, but was posted by cgel.zte@gmail.com, not by
> "ye xingchen <ye.xingchen@zte.com.cn>", so it needs another signoff
> and full name so the chain is complete. For more details see:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=v5.18#n363
Greg, Bjorn,
I believe that appending a SoB like this myself is fine:
Signed-off-by: CGEL ZTE <cgel.zte@gmail.com>
It is a SOB already in kernel commit logs - I assume
that's the right thing to do in this case, please
let me know if it isn't and what should we do instead.
Thanks,
Lorenzo
> Bjorn
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-27 12:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 7:16 [PATCH linux-next] PCI: iproc: Remove the unneeded result variable cgel.zte
2022-09-06 16:54 ` Florian Fainelli
2022-09-06 21:25 ` Bjorn Helgaas
2022-09-06 21:27 ` Scott Branden
2022-09-06 21:37 ` Florian Fainelli
2022-09-07 3:10 ` [PATCH linux-next] cgel.zte
2022-09-27 12:07 ` Lorenzo Pieralisi [this message]
2022-09-27 12:38 ` [PATCH linux-next] PCI: iproc: Remove the unneeded result variable Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzLnmGiU7qcWkeH2@lpieralisi \
--to=lpieralisi@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bhelgaas@google.com \
--cc=cgel.zte@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=helgaas@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=robh@kernel.org \
--cc=sbranden@broadcom.com \
--cc=ye.xingchen@zte.com.cn \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox