From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Jerome Neanne <jneanne@baylibre.com>
Cc: lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org,
nm@ti.com, kristo@kernel.org, krzysztof.kozlowski+dt@linaro.org,
catalin.marinas@arm.com, will@kernel.org, lee@kernel.org,
tony@atomide.com, vigneshr@ti.com, bjorn.andersson@linaro.org,
shawnguo@kernel.org, geert+renesas@glider.be,
dmitry.baryshkov@linaro.org, marcel.ziswiler@toradex.com,
vkoul@kernel.org, biju.das.jz@bp.renesas.com, arnd@arndb.de,
jeff@labundy.com, afd@ti.com, khilman@baylibre.com,
narmstrong@baylibre.com, msp@baylibre.com, j-keerthy@ti.com,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-input@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH v5 5/6] Input: Add tps65219 interrupt driven powerbutton
Date: Tue, 27 Sep 2022 08:52:15 -0700 [thread overview]
Message-ID: <YzMcL/wktFyKO06K@google.com> (raw)
In-Reply-To: <20220927083520.15766-6-jneanne@baylibre.com>
Hi Jerome,
On Tue, Sep 27, 2022 at 10:35:19AM +0200, Jerome Neanne wrote:
> +static int tps65219_pb_probe(struct platform_device *pdev)
> +{
> + struct tps65219 *tps = dev_get_drvdata(pdev->dev.parent);
> + struct device *dev = &pdev->dev;
> + struct tps65219_pwrbutton *pwr;
> + struct input_dev *idev;
> + int error;
> + int push_irq;
> + int release_irq;
> +
> + pwr = devm_kzalloc(dev, sizeof(*pwr), GFP_KERNEL);
> + if (!pwr)
> + return -ENOMEM;
> +
> + idev = devm_input_allocate_device(dev);
> + if (!idev)
> + return -ENOMEM;
> +
> + idev->name = pdev->name;
> + snprintf(pwr->phys, sizeof(pwr->phys), "%s/input0",
> + pdev->name);
> + idev->phys = pwr->phys;
> + idev->dev.parent = dev;
As I mentioned in my previous email, this assignment is not needed given
that devm_input_allocate_device() is used. Otherwise:
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Please feel free to merge through MFD tree.
Thanks.
--
Dmitry
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-27 15:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 8:35 [PATCH v5 0/6] Add support for TI TPS65219 PMIC Jerome Neanne
2022-09-27 8:35 ` [PATCH v5 1/6] DONOTMERGE: arm64: dts: ti: Add TI TPS65219 PMIC support for AM642 SK board Jerome Neanne
2022-09-27 8:35 ` [PATCH v5 2/6] DONOTMERGE: arm64: dts: ti: Add pinmux and irq mapping for TPS65219 external interrupts Jerome Neanne
2022-09-27 8:35 ` [PATCH v5 3/6] DONOTMERGE: arm64: dts: ti: k3-am642-sk: Enable tps65219 power-button Jerome Neanne
2022-09-27 8:35 ` [PATCH v5 4/6] mfd: tps65219: Add driver for TI TPS65219 PMIC Jerome Neanne
2022-09-27 8:35 ` [PATCH v5 5/6] Input: Add tps65219 interrupt driven powerbutton Jerome Neanne
2022-09-27 15:52 ` Dmitry Torokhov [this message]
2022-09-27 8:35 ` [PATCH v5 6/6] arm64: defconfig: Add tps65219 as modules Jerome Neanne
-- strict thread matches above, loose matches on Subject: below --
2022-09-14 14:07 [PATCH v5 0/6] Add support for TI TPS65219 PMIC Jerome Neanne
2022-09-14 14:07 ` [PATCH v5 5/6] Input: Add tps65219 interrupt driven powerbutton Jerome Neanne
2022-09-13 12:14 [PATCH v5 0/6] Add support for TI TPS65219 PMIC Jerome Neanne
2022-09-13 12:14 ` [PATCH v5 5/6] Input: Add tps65219 interrupt driven powerbutton Jerome Neanne
2022-09-14 12:32 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzMcL/wktFyKO06K@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=afd@ti.com \
--cc=arnd@arndb.de \
--cc=biju.das.jz@bp.renesas.com \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=geert+renesas@glider.be \
--cc=j-keerthy@ti.com \
--cc=jeff@labundy.com \
--cc=jneanne@baylibre.com \
--cc=khilman@baylibre.com \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=msp@baylibre.com \
--cc=narmstrong@baylibre.com \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
--cc=vkoul@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).