From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 316A1C07E9D for ; Tue, 27 Sep 2022 15:53:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=u76IjSi2nuDXD4BJdfkhbHODz5UNjuU8suq1CQfefvM=; b=zL0X+uwwZsnv4b vR6Mjk73HLZwg9ieaxYIfSTjkg2UpA30eGmec53uEygR6GkKpx5P4UjDciW0tOtPnI3pr50tWtclI Wnx5Bty4kn9RlRyOxZvhRw/s2ettM/Q53O7Nw7Ik3YogriFQqrJswLn7ly+uMRCx3OOKkFETLtwtj gkDJq/iMdlK70A8fuxdrmzAYsno6W2WJks+/iWJnu94xR2HW3n8hezLPYFN5bXkOAJd4Ga9nF1VOf JFBaQ9BDn8PWx97XnQUyIB7y0MRaXhcui6vaVuiHW9l0WUR4MwENTF/YOBAcQr3QU2MsxnxANHRtN InP2sfYQDX69MDkkyYCw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1odCsk-00Bdxq-6l; Tue, 27 Sep 2022 15:52:26 +0000 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1odCsg-00Bdtv-Jj for linux-arm-kernel@lists.infradead.org; Tue, 27 Sep 2022 15:52:23 +0000 Received: by mail-pl1-x634.google.com with SMTP id w20so9436110ply.12 for ; Tue, 27 Sep 2022 08:52:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=p0YcyRlyNYPjC2yUE5rEWl59Rr2Y1jMOfDRIiIcxunI=; b=dkXzWr3tMEIvoAgqt/Db887cORt7DqQtdkeWbrjlb2qlMwLXEQIaWpbGozZKdyLaVd R1DVx2Z+gxzrYamD8qxUGpiW/IRMrNfIFlXoRpGauQvLS/kH/R9DUuTlOd7zPHb6r0eU NjVb3OtdHd1JgAHb1XLwkrUCOTJnJS7Gt0dj7cl/qa8hapLXHk9JYq6TH3uEzU4OmKvM QWLpQVpba/hi7UWAhhHXbpDyoN7dOuIg2X0TdNiHkLlykXZNPwtGPG3mNgotflsdc+j+ TSUffuh88J0HJmoGS8JF9rlUMozrn9weVuQQYbinMqtddwgSa86uULTUVKHSRXKRpyt3 ZNKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=p0YcyRlyNYPjC2yUE5rEWl59Rr2Y1jMOfDRIiIcxunI=; b=gGwWMIshmFGGpJWAdBMZorQt+LuTulkyRW/l1onqVaKvQtLm/W2ii6dd8kzzxE3kY1 2NG7rDzDlD5+9PHDMid/iI9+ioi2KHDSfYGXpYGzZTslvxqi+6AannJh2t45WlQngxMC Y9gVo9RjPghEJop0oWdHUVRvtoi1t25qba0edJWH+XMhwwydOzyhpPzer66dPrewPb09 4yB+dabzVBccm/RkKBT9uMkQJZRvBBeKl406MfzSnHo1UFPP987bfP93sV900MWg2sTg Y7pJE8GEhHdv3HV8FKxuwRBbATK3gGxYRDdJtIPFtoQM/utivoxl6vip/YuKkSJyTbjf 46MQ== X-Gm-Message-State: ACrzQf2kKhg5UDgGiMOIlGHQ7HgzOUJgr9mvod7dQqX/j/FEhK45f9sB +8u2YMNIzOqPIwdY8WA1Xtg= X-Google-Smtp-Source: AMsMyM4lQReHf55/5V7GZv01jZKvTie0sNuH+pDIoCDbLJjFZzEASOE06VVWXvBuUWH42yBTlZyW8A== X-Received: by 2002:a17:903:240b:b0:178:a475:6644 with SMTP id e11-20020a170903240b00b00178a4756644mr28086716plo.96.1664293940295; Tue, 27 Sep 2022 08:52:20 -0700 (PDT) Received: from google.com ([2620:15c:9d:2:9739:ab49:3830:2cbb]) by smtp.gmail.com with ESMTPSA id d190-20020a6336c7000000b0041cd2417c66sm1770777pga.18.2022.09.27.08.52.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Sep 2022 08:52:19 -0700 (PDT) Date: Tue, 27 Sep 2022 08:52:15 -0700 From: Dmitry Torokhov To: Jerome Neanne Cc: lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, nm@ti.com, kristo@kernel.org, krzysztof.kozlowski+dt@linaro.org, catalin.marinas@arm.com, will@kernel.org, lee@kernel.org, tony@atomide.com, vigneshr@ti.com, bjorn.andersson@linaro.org, shawnguo@kernel.org, geert+renesas@glider.be, dmitry.baryshkov@linaro.org, marcel.ziswiler@toradex.com, vkoul@kernel.org, biju.das.jz@bp.renesas.com, arnd@arndb.de, jeff@labundy.com, afd@ti.com, khilman@baylibre.com, narmstrong@baylibre.com, msp@baylibre.com, j-keerthy@ti.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH v5 5/6] Input: Add tps65219 interrupt driven powerbutton Message-ID: References: <20220927083520.15766-1-jneanne@baylibre.com> <20220927083520.15766-6-jneanne@baylibre.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220927083520.15766-6-jneanne@baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220927_085222_682069_9200B288 X-CRM114-Status: GOOD ( 12.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jerome, On Tue, Sep 27, 2022 at 10:35:19AM +0200, Jerome Neanne wrote: > +static int tps65219_pb_probe(struct platform_device *pdev) > +{ > + struct tps65219 *tps = dev_get_drvdata(pdev->dev.parent); > + struct device *dev = &pdev->dev; > + struct tps65219_pwrbutton *pwr; > + struct input_dev *idev; > + int error; > + int push_irq; > + int release_irq; > + > + pwr = devm_kzalloc(dev, sizeof(*pwr), GFP_KERNEL); > + if (!pwr) > + return -ENOMEM; > + > + idev = devm_input_allocate_device(dev); > + if (!idev) > + return -ENOMEM; > + > + idev->name = pdev->name; > + snprintf(pwr->phys, sizeof(pwr->phys), "%s/input0", > + pdev->name); > + idev->phys = pwr->phys; > + idev->dev.parent = dev; As I mentioned in my previous email, this assignment is not needed given that devm_input_allocate_device() is used. Otherwise: Acked-by: Dmitry Torokhov Please feel free to merge through MFD tree. Thanks. -- Dmitry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel