From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C5641C04A95 for ; Wed, 28 Sep 2022 06:53:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2vZoZ7nw8uImHHsmLHZTs8vk6srlFc2qepEOW2L+lXQ=; b=Ru/sQLD577Q35c XHE/aKQWlM6ie7fWo66QYoeL8TiuS9TAiqr2LITYXWgw/3EiuHxOM0fltKqd4DfcLIF30t87uaoNJ 2L/01umi10OXIZLzRFSfRD4s6m8YaQkaD202/OaCRyILVJVwctnwP5dj+tL4H7pO3cd/90GQ254/p Lixh++OKcyIbcs0H2x8w/cqKzKaQlgX8klchNcUBDiQc6WtxynMHj0o9ielzk39/6cVF4x4q4gbqI 5xj6SJB7iWbDWXeXP0ChQxOEVSy3UJ7UvFbFVRmOJHKPBO3kAB4GsKgXwGS/x9MLJzxokijPDfgOV nw6LZg9HTSm4mv5niQww==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1odQwB-00ELsE-TX; Wed, 28 Sep 2022 06:52:56 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1odQw8-00ELoU-3H for linux-arm-kernel@lists.infradead.org; Wed, 28 Sep 2022 06:52:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664347971; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IlaSZc33GONrE9IArKtEWlpurS3hEknJV/JTkyz5RZ0=; b=hVzylBFyWp2Q/0xG6MRw+RpV8k1jMHriYdXDkJG5cu4OOjRpa/z9V6Sux4W9jvIRUdxnIP ulIEI5BPPZpZK4WpLw2kQA8+B9tySrzVOmDgGmOLm4fYnJTy+C9ZmtjMWkfP3qM6zTjhQw 7nq8BkCO+6rICrLv8iFkZGHCeFxHIlA= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-292-7yyPjbgSNVaEGE3qQ-_5FA-1; Wed, 28 Sep 2022 02:52:47 -0400 X-MC-Unique: 7yyPjbgSNVaEGE3qQ-_5FA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4C7FD185A79C; Wed, 28 Sep 2022 06:52:47 +0000 (UTC) Received: from localhost (ovpn-13-211.pek2.redhat.com [10.72.13.211]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 772D5422A9; Wed, 28 Sep 2022 06:52:45 +0000 (UTC) Date: Wed, 28 Sep 2022 14:52:42 +0800 From: Baoquan He To: Chen Lifu Cc: linux@armlinux.org.uk, akpm@linux-foundation.org, pmladek@suse.com, kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] ARM: kexec: Make machine_crash_nonpanic_core() static Message-ID: References: <20220816074250.3991633-1-chenlifu@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220816074250.3991633-1-chenlifu@huawei.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220927_235252_248878_2948CACF X-CRM114-Status: GOOD ( 20.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 08/16/22 at 03:42pm, Chen Lifu wrote: > This symbol is not used outside of the file, so mark it static. > > Fixes the following warning: > > arch/arm/kernel/machine_kexec.c:76:6: warning: symbol 'machine_crash_nonpanic_core' was not declared. Should it be static? > > Signed-off-by: Chen Lifu LGTM, Acked-by: Baoquan He > --- > arch/arm/kernel/machine_kexec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/kernel/machine_kexec.c b/arch/arm/kernel/machine_kexec.c > index f567032a09c0..a2e9ac763a9f 100644 > --- a/arch/arm/kernel/machine_kexec.c > +++ b/arch/arm/kernel/machine_kexec.c > @@ -71,11 +71,11 @@ int machine_kexec_prepare(struct kimage *image) > > void machine_kexec_cleanup(struct kimage *image) > { > } > > -void machine_crash_nonpanic_core(void *unused) > +static void machine_crash_nonpanic_core(void *unused) > { > struct pt_regs regs; > > crash_setup_regs(®s, get_irq_regs()); > printk(KERN_DEBUG "CPU %u will stop doing anything useful since another CPU has crashed\n", > -- > 2.37.1 > > > _______________________________________________ > kexec mailing list > kexec@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/kexec > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel