From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CC003C32771 for ; Wed, 28 Sep 2022 14:21:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6+tp2vlr21zCbQcBbdrMEgq4JWJ6AUlaGhZVUS1OyV0=; b=yy0x5ke3JpDAxK yY4rW687Ak15Agh9+oQu3vxON7TMm2o2sLwxYea7nf+3owo6ATKe2PQYhJCUveSvJEBaMcIYbL5Pu Ss6zXgOYXE4oI9J2284d5pn+NnSV1bQ1dsdCQ3SHVYIDyOEtxVJxuxEp7urQ6l8YnT0K3j4z2GZEb f/qR+ub9923abM8BluuzVBSpwMF9Oys7KF850jqwQuBVjucKbkFugyR9vs8IoxKZt31Q5ajImX5v+ apxWlGUhHsS2u6CS18ob9eiSUZRwhuJTWEoIH+Hc/PxzfkVyEJ5EQKXtQshgiz9TTy/G3Dkmn2yps 8PoZt++sJNU/YqRiYjoA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1odXve-00Gecl-SB; Wed, 28 Sep 2022 14:20:50 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1odXvd-00GecU-3C for linux-arm-kernel@bombadil.infradead.org; Wed, 28 Sep 2022 14:20:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=qNdY2NrJ1gsnDEHSqMsKn6OOlMnSw9JiNsIQWGCO7UA=; b=mWrFZ1bKF8oxlhfJS1UKwNox18 PESCHt8ZyBYAk/xeHCvkkDF3Ys8AT72IRhqd2Wx2ueMgrL9fBhdFyMImquFVXBywdgwRvbe0Vfeek 2llIrzqUdDbn2lF1SEBgBQX1XTBjDcNaf4hhIRTJKHTakj/LK6auIEfCrkYO4DveFQVoa+oNpu1k4 yrJuyXpFmdV9AD/dPiy54cU8oeUq+8RV+Qp9hrC33GDDU9gnYb8fBfs1L1dYVve2mf95IcDLoLsl1 pjusLGhzz8QL05acZdP105olRhDa9bhrngt8aCqh0NJE/sHdPuQxH+nWCCqm6zVljS8m7LDLRtPBr vtiDKK/w==; Received: from [187.19.236.141] (helo=quaco.ghostprotocols.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1odXvZ-00GbS3-Ex; Wed, 28 Sep 2022 14:20:45 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 717B2405F0; Wed, 28 Sep 2022 11:20:43 -0300 (-03) Date: Wed, 28 Sep 2022 11:20:43 -0300 From: Arnaldo Carvalho de Melo To: Leo Yan Cc: Ali Saidi , renyu.zj@linux.alibaba.com, alexander.shishkin@linux.intel.com, german.gomez@arm.com, james.clark@arm.com, john.garry@huawei.com, jolsa@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, mark.rutland@arm.com, mike.leach@linaro.org, mingo@redhat.com, namhyung@kernel.org, peterz@infradead.org, timothy.hayes@arm.com, will@kernel.org, xueshuai@linux.alibaba.com, zhuo.song@linux.alibaba.com Subject: Re: [PATCH] perf arm-spe: augment the data source type with neoverse_spe list Message-ID: References: <1664197396-42672-1-git-send-email-renyu.zj@linux.alibaba.com> <20220926141032.30734-1-alisaidi@amazon.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Em Mon, Sep 26, 2022 at 11:00:31PM +0800, Leo Yan escreveu: > On Mon, Sep 26, 2022 at 02:10:32PM +0000, Ali Saidi wrote: > > > When synthesizing event with SPE data source, commit 4e6430cbb1a9("perf > > > arm-spe: Use SPE data source for neoverse cores") augment the type with > > > source information by MIDR. However, is_midr_in_range only compares the > > > first entry in neoverse_spe. > > > > > > Change is_midr_in_range to is_midr_in_range_list to traverse the > > > neoverse_spe array so that all neoverse cores synthesize event with data > > > source packet. > > > > > > Fixes: 4e6430cbb1a9("perf arm-spe: Use SPE data source for neoverse cores") > > > Signed-off-by: Jing Zhang > > > > Thanks for catching this, you're absolutely right. > > > > Reviewed-by: Ali Saidi > > It's also good for me: > Reviewed-by: Leo Yan Thanks, applied. - Arnaldo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel