From: Corentin Labbe <clabbe.montjoie@gmail.com>
To: Kevin Hilman <khilman@baylibre.com>
Cc: Peter Ujfalusi <peter.ujfalusi@gmail.com>,
dmaengine@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Nicolas Frayer <nfrayer@baylibre.com>
Subject: Re: [PATCH v2 2/3] dma/ti: convert k3-udma to module
Date: Wed, 28 Sep 2022 16:59:56 +0200 [thread overview]
Message-ID: <YzRhbNd4Dse+zLSb@Red> (raw)
In-Reply-To: <20220927230804.4085579-3-khilman@baylibre.com>
Le Tue, Sep 27, 2022 at 04:08:03PM -0700, Kevin Hilman a écrit :
> Currently k3-udma driver is built as separate platform drivers with a
> shared probe and identical code path, just differnet platform data.
>
> To enable to build as module, convert the separate platform driver
> into a single module_platform_driver with the data selection done via
> compatible string and of_match. The separate of_match tables are also
> combined into a single table to avoid the multiple calls to
> of_match_node()
>
> Since all modern TI platforms using this are DT enabled, the removal
> of separate platform_drivers shoul should nave no functional change.
>
Hello
You have some typo in last sentence. (extra shoul, nave->have)
Regards
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-28 15:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 23:08 [PATCH v2 0/3] dma/ti: enable udma and psil to be built as modules Kevin Hilman
2022-09-27 23:08 ` [PATCH v2 1/3] of/irq: export of_msi_get_domain Kevin Hilman
2022-09-27 23:08 ` [PATCH v2 2/3] dma/ti: convert k3-udma to module Kevin Hilman
2022-09-28 14:59 ` Corentin Labbe [this message]
2022-09-29 7:35 ` Vinod Koul
2022-09-29 23:31 ` Kevin Hilman
2022-09-27 23:08 ` [PATCH v2 3/3] dma/ti: convert PSIL to be buildable as module Kevin Hilman
2022-09-28 13:53 ` Péter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzRhbNd4Dse+zLSb@Red \
--to=clabbe.montjoie@gmail.com \
--cc=dmaengine@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=nfrayer@baylibre.com \
--cc=peter.ujfalusi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).