From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 820D4C04A95 for ; Wed, 28 Sep 2022 18:47:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1EuyBHVVFVpkJiLROxN0HNRgkfseaOzDwWymefJC9Z8=; b=j8IVaIu0vg2xm9 7iIckbZ0zZZpPatWZotBh1jLBzUgKpbvsX57xRoQQvvswmANBZPlZ3sQcIP/LTp4u8HbiMcxT9UEY I2BCTRB+5zr+RBm/zva9+bxnDHvhNagO3vY+ZNsXpWf7HAxURPMe4/jSL/5mxE0K6cTRHWZjtPh3b 11l0gvOIll3oG7w0BQ4zWX8fU37JipaoyKN82Vtq2HDNj5V2VSdXDhgZQJmEn9K2pA6yOgSOMvlKI x/2MX0w108W/dmgRjfAbJihZpsAuz/PaZBdTKHVFpieLuegpp7VYK5/uhHrvglzoMo9S6d/Dwdn68 d4MM9ffRUxsXDSHTbjYw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1odc4n-0003wM-2O; Wed, 28 Sep 2022 18:46:33 +0000 Received: from mail-il1-x132.google.com ([2607:f8b0:4864:20::132]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1odc4k-0003uf-AX for linux-arm-kernel@lists.infradead.org; Wed, 28 Sep 2022 18:46:31 +0000 Received: by mail-il1-x132.google.com with SMTP id o2so835167ils.0 for ; Wed, 28 Sep 2022 11:46:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=LpxoywpaQZbEd7HNklvkbE+pBYLLyfSwOdEaf41jsQ0=; b=kWM/3CIyRI6nfI+De5JUNdFwTItNaQXTWqbDTabs6UaUl/0MCPJIFdwWe1TWp0THQt pyuVI/kmr0tZXHf86RfvoAy2tWcuMABnOLuW9Hx3mry5zD2o7haITtjPCiSFjM2w7SMk OmTU9AKIiMlvgQ/AS4vDI7wJt4dCTGI/izxGoJAXjKUgLrbtrQK0iFKQSvp8hiIE460w 7K+IGuJlBsXOCkKO3CfPBBEq2dq75P1+C0RpyxQxXTccXXClJS6elMDN9J4+1PcOC1qX ni21VCsI+ZJbnh3VosmGkjkU06nDSzTiDMUgBqSuNo1eH1cMXYU7F2qVJRhcxfl2gC7G Ec1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=LpxoywpaQZbEd7HNklvkbE+pBYLLyfSwOdEaf41jsQ0=; b=fPf9Hj2kvqSRjCfukEYx3DdrvE5+yKp5LLwKY7iplBUHcMGVRyMyoqoI/OojnhvZfa /TYFtDq0ffyNrojMCkIN9n6+buLrxgr+DYi/5plwNJkFJk8CizdK24DkB/I3wAGIGRTv rp0ji3YEFFP9T1i/7Iqs/+tiN8PkRw2wMg/qpWbtmQ0LNVkmBKqs7bvyo2DFYwolfLZn vvl9Hexthb61R1ebXYOFfKlTLMeIy3dRnbemrkbC2U6MwIGnFXQq7mAmh8zG+E/4wVfL 7hEOcCAj4y9N3kYqLXdBxfAPJ1VF/qZ/XaS2qSV+8MyPqabnPjFfQiz2w3iJ8zD0Uj/3 fakg== X-Gm-Message-State: ACrzQf3vblnz2fFvaJ2Ja2a248MoYZdEuBzZb26r6Rb6ZDkKZDZQryDQ v9/8rKK5y2M1uH6I6FEZhPsHjA== X-Google-Smtp-Source: AMsMyM6KnMs6h0Vv/mW+gYrgQ8avvnHmbBJG/o6ac7PBd3Tr7J6tylm8KXP4s2KRm+MwddNuokxv1A== X-Received: by 2002:a05:6e02:16c7:b0:2f6:6eb4:8df3 with SMTP id 7-20020a056e0216c700b002f66eb48df3mr16415870ilx.31.1664390785536; Wed, 28 Sep 2022 11:46:25 -0700 (PDT) Received: from google.com ([2620:15c:183:200:e132:6c29:fb2a:a1b]) by smtp.gmail.com with ESMTPSA id cq5-20020a056638478500b003428c21ed12sm2058124jab.167.2022.09.28.11.46.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Sep 2022 11:46:25 -0700 (PDT) Date: Wed, 28 Sep 2022 12:46:20 -0600 From: Yu Zhao To: Andrew Morton Cc: Andi Kleen , Aneesh Kumar , Catalin Marinas , Dave Hansen , Hillf Danton , Jens Axboe , Johannes Weiner , Jonathan Corbet , Linus Torvalds , Matthew Wilcox , Mel Gorman , Michael Larabel , Michal Hocko , Mike Rapoport , Peter Zijlstra , Tejun Heo , Vlastimil Babka , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, page-reclaim@google.com, Brian Geffon , Jan Alexander Steffens , Oleksandr Natalenko , Steven Barrett , Suleiman Souhlal , Daniel Byrne , Donald Carr , Holger =?iso-8859-1?Q?Hoffst=E4tte?= , Konstantin Kharlamov , Shuang Zhai , Sofia Trinh , Vaibhav Jain Subject: Re: [PATCH mm-unstable v15 09/14] mm: multi-gen LRU: optimize multiple memcgs Message-ID: References: <20220918080010.2920238-1-yuzhao@google.com> <20220918080010.2920238-10-yuzhao@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220918080010.2920238-10-yuzhao@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220928_114630_370876_B9F2D765 X-CRM114-Status: GOOD ( 16.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andrew, Can you please take this fixlet? Thanks. Fix imprecise comments. Signed-off-by: Yu Zhao --- mm/vmscan.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index a8fd6300fa7e..5b565470286b 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -5078,7 +5078,7 @@ static bool should_abort_scan(struct lruvec *lruvec, unsigned long seq, DEFINE_MAX_SEQ(lruvec); if (!current_is_kswapd()) { - /* age each memcg once to ensure fairness */ + /* age each memcg at most once to ensure fairness */ if (max_seq - seq > 1) return true; @@ -5103,10 +5103,9 @@ static bool should_abort_scan(struct lruvec *lruvec, unsigned long seq, /* * A minimum amount of work was done under global memory pressure. For - * kswapd, it may be overshooting. For direct reclaim, the target isn't - * met, and yet the allocation may still succeed, since kswapd may have - * caught up. In either case, it's better to stop now, and restart if - * necessary. + * kswapd, it may be overshooting. For direct reclaim, the allocation + * may succeed if all suitable zones are somewhat safe. In either case, + * it's better to stop now, and restart later if necessary. */ for (i = 0; i <= sc->reclaim_idx; i++) { unsigned long wmark; -- 2.37.3.998.g577e59143f-goog _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel