From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1A32FC04A95 for ; Wed, 28 Sep 2022 19:38:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=K4TFmy34daKLlxpNdPgmXRWy7eRuU5NOUiZC0Rt0JNE=; b=I84N0HI7mOWeRq c1Xg16+nZK4KdPjH4YTOxhNUw+dIzx/R7N3X/sAG/o5Pv986uX2OdVvP4CeVValtOqwXM2iVTWgDn /+cjMeB1jKK6sOdWhaCK2c1YEhFQoalL5EI5riw969kufYbi5kEUBxccRepmz+Ns5iBOuWqpsSanu Cn3sU9uS8zlMUmTyMDMLbkhOrpJsQ07DuAGxStDBhByq1AXHUDyXsrP48UdIvk7T8woLfpGRfQia4 LaXCAGKQvU29x1kFr98/6UBaQf95zC9Od22SIu8qZpJuu3VB5I+64mYUAtp2T53Z9uZwSx0DHctfD 86t+m6Xl/6iGKzEFORhA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1odcrk-0009lA-Bj; Wed, 28 Sep 2022 19:37:08 +0000 Received: from mail-io1-xd2f.google.com ([2607:f8b0:4864:20::d2f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1odcrh-0009jn-2N for linux-arm-kernel@lists.infradead.org; Wed, 28 Sep 2022 19:37:06 +0000 Received: by mail-io1-xd2f.google.com with SMTP id v128so10973656ioe.12 for ; Wed, 28 Sep 2022 12:37:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=w+64nBC9flQuRlvFf/LyNi8vAIoeFZlmjiGW7/Cl9GA=; b=W1oLTSde5Qwb++pbSaUe4lWBe586C2QHURCizljXgg5WUYP5/EWw76ThSDAmN8HdLN 1bn2X8u17DOL6ZgiSEAOjjzoUl0ujoEeqIqAEMA3x4+hZclF9cxqSuvfrOm66gTJvflh A92GVUKk1qjCxsntZgVqbe2oBEeMo3tqY1nO/yRnkJRglartg9jnsTgHrlNRscXIikWy n2UW5230gSIvPlWMoDgw2rolIttjNi28MVW1qEFn6Ed0Q+1wPFYGc245TNoRKM4VXfHL rQZOyeQfp22g8RGWrVUD5FqoZ4l+WHWCEaG5YRAVet6EKIz5JM1019yWewHiNCSt3tYp 9DKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=w+64nBC9flQuRlvFf/LyNi8vAIoeFZlmjiGW7/Cl9GA=; b=wxmRDsVu6vvEi9HcVSVnzsNyz8RjwnhQ2GYbxlMDFSfkTrXV4dGjE5W5w9oPQP79jE X2mLJ/QeyGu7bY4K/7kGyqV8kohl5zpv5BHdDJ76cSN3n7HYQwyXomoVSN28z/EWTEZD GiVV9KT0AYHwpiIHaSkvSTeruhn3xEiKRbZ75zHBG+h2PUsZPljMmZTwid0XI6KmzQJa FMcyDgLo0MsAJ5sVf6Nh1fgsq0T2YG6BtRJZzwVtw776//PCGWLx61pO0jrcIrtLSRFR lUqOL/jTeT3t7GOzTIUtyHV0jDH7/loTvNVmHmXxYTjW9DsYUfjg8ZTysp/B5Vg87V9n Kf1g== X-Gm-Message-State: ACrzQf00nA6S4v1VuXRFh8GZnz1/ZytBMku7HKxANfRRSLuDCiZfup0M yWjqs+2/KrO/aVCoA8rD67xVhg== X-Google-Smtp-Source: AMsMyM4pvj/63KDkjqfOHv+ZDuiHOFQWJwmRPDGjn/J9jBlb8WWfq0hCxV1lxPeDvR8N5J4PM3KGgA== X-Received: by 2002:a02:c6d4:0:b0:35a:4ea3:4890 with SMTP id r20-20020a02c6d4000000b0035a4ea34890mr1234303jan.215.1664393823556; Wed, 28 Sep 2022 12:37:03 -0700 (PDT) Received: from google.com ([2620:15c:183:200:e132:6c29:fb2a:a1b]) by smtp.gmail.com with ESMTPSA id z25-20020a6be019000000b006814fd71117sm2283016iog.12.2022.09.28.12.37.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Sep 2022 12:37:03 -0700 (PDT) Date: Wed, 28 Sep 2022 13:36:58 -0600 From: Yu Zhao To: Andrew Morton Cc: Andi Kleen , Aneesh Kumar , Catalin Marinas , Dave Hansen , Hillf Danton , Jens Axboe , Johannes Weiner , Jonathan Corbet , Linus Torvalds , Matthew Wilcox , Mel Gorman , Michael Larabel , Michal Hocko , Mike Rapoport , Peter Zijlstra , Tejun Heo , Vlastimil Babka , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, page-reclaim@google.com, Brian Geffon , Jan Alexander Steffens , Oleksandr Natalenko , Steven Barrett , Suleiman Souhlal , Daniel Byrne , Donald Carr , Holger =?iso-8859-1?Q?Hoffst=E4tte?= , Konstantin Kharlamov , Shuang Zhai , Sofia Trinh , Vaibhav Jain Subject: Re: [PATCH mm-unstable v15 08/14] mm: multi-gen LRU: support page table walks Message-ID: References: <20220918080010.2920238-1-yuzhao@google.com> <20220918080010.2920238-9-yuzhao@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220918080010.2920238-9-yuzhao@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220928_123705_133599_1198DFD2 X-CRM114-Status: GOOD ( 14.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andrew, Can you please take another fixlet? Thanks. Don't sync disk for each aging cycle. wakeup_flusher_threads() was added under the assumption that if a system runs out of clean cold pages, it might want to write back dirty pages more aggressively so that they can become clean and be dropped. However, doing so can breach the rate limit a system wants to impose on writeback, resulting in early SSD wearout. Reported-by: Axel Rasmussen Signed-off-by: Yu Zhao --- mm/vmscan.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index 5b565470286b..0317d4cf4884 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -4413,8 +4413,6 @@ static bool try_to_inc_max_seq(struct lruvec *lruvec, unsigned long max_seq, if (wq_has_sleeper(&lruvec->mm_state.wait)) wake_up_all(&lruvec->mm_state.wait); - wakeup_flusher_threads(WB_REASON_VMSCAN); - return true; } -- 2.37.3.998.g577e59143f-goog _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel