From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 47065C433F5 for ; Thu, 29 Sep 2022 11:28:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2QwNdYCHAehILltEnOHwec7/b3PvuNEPk9aZa6UVFIw=; b=FfQv5vqQ8kdyl0 8g/dgC2tLwfSQOIHlfNh53hJ/HiLsRIvzbjK67Jn9iD6KxD0XYPm7RiRduQr90jV77NakGYmxZ56j G0gO/nGCcJ9KE7xfg3hLhvsitUnrtjjmB2wfPd3I1fNdVimC8bm8ccQvI0TbwD7kQS6masEkZiK/p FasDfrLrV9OXlrI7cwapkV+/LHLO3dhigbw+ug9KgG98IUCpGUGniT9jWETFRV67FAl/kwK0TGer+ hpI6ZuVLLwO51U5rWGc9QycWBe8+G4TQTX2k3fkMfwFAfiEE+WG4qGDyZ8fP2HGLrRRWAv5aneYTv uijMTmKXGyIgVJMG934A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1odrho-002de4-LX; Thu, 29 Sep 2022 11:27:52 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1odrhl-002dbt-3S for linux-arm-kernel@lists.infradead.org; Thu, 29 Sep 2022 11:27:50 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2048315BF; Thu, 29 Sep 2022 04:27:51 -0700 (PDT) Received: from FVFF77S0Q05N (unknown [10.57.81.100]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7A2563F73B; Thu, 29 Sep 2022 04:27:42 -0700 (PDT) Date: Thu, 29 Sep 2022 12:27:39 +0100 From: Mark Rutland To: Li Huafei Cc: catalin.marinas@arm.com, will@kernel.org, rostedt@goodmis.org, mingo@redhat.com, Julia.Lawall@inria.fr, akpm@linux-foundation.org, andreyknvl@gmail.com, elver@google.com, wangkefeng.wang@huawei.com, zhouchengming@bytedance.com, ardb@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] arm64: module: Make plt_equals_entry() static Message-ID: References: <20220929094134.99512-1-lihuafei1@huawei.com> <20220929094134.99512-2-lihuafei1@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220929094134.99512-2-lihuafei1@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220929_042749_210240_72061802 X-CRM114-Status: GOOD ( 16.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 29, 2022 at 05:41:32PM +0800, Li Huafei wrote: > Since commit 4e69ecf4da1e ("arm64/module: ftrace: deal with place > relative nature of PLTs"), plt_equals_entry() is not used outside of > module-plts.c, so make it static. > > Signed-off-by: Li Huafei Acked-by: Mark Rutland Mark. > --- > arch/arm64/include/asm/module.h | 1 - > arch/arm64/kernel/module-plts.c | 3 ++- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/include/asm/module.h b/arch/arm64/include/asm/module.h > index 4e7fa2623896..28514b989a0b 100644 > --- a/arch/arm64/include/asm/module.h > +++ b/arch/arm64/include/asm/module.h > @@ -58,7 +58,6 @@ static inline bool is_forbidden_offset_for_adrp(void *place) > } > > struct plt_entry get_plt_entry(u64 dst, void *pc); > -bool plt_entries_equal(const struct plt_entry *a, const struct plt_entry *b); > > static inline bool plt_entry_is_initialized(const struct plt_entry *e) > { > diff --git a/arch/arm64/kernel/module-plts.c b/arch/arm64/kernel/module-plts.c > index a3d0494f25a9..5a0a8f552a61 100644 > --- a/arch/arm64/kernel/module-plts.c > +++ b/arch/arm64/kernel/module-plts.c > @@ -37,7 +37,8 @@ struct plt_entry get_plt_entry(u64 dst, void *pc) > return plt; > } > > -bool plt_entries_equal(const struct plt_entry *a, const struct plt_entry *b) > +static bool plt_entries_equal(const struct plt_entry *a, > + const struct plt_entry *b) > { > u64 p, q; > > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel