From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A348BC4332F for ; Thu, 29 Sep 2022 11:42:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6lA7ZyrQf1cwJ1uV397tha1x5hA3GdqEd8iCUT2QN68=; b=sLR8HIAvdyuVkC y8iU1Yu+6Pb17vYaubj3G+I7uB8tg/wFZ1cTW7dOVL+e1xw5Yoe1JYCSmbQXgl2tgrXpP9j9ObY4j qUUJtAlpBne57D66sE59DMTwaKqfw0U3BVhaUrPNTWYRm9mvjFICI8AemFfH5vINDtqzLMGyhN9IO fgS2mJAc8SrYt6G1dMVSfNqy2UIRCMeEhvWMYfxG6AZlLeUu+sqxVdv+zULVKL98/8CPheJEsVclC id7Rpv4ps8YZBaBznZen6ZNNYm54mdIoscEG4fKPzJf6Eea+3UMjMi/XrXuAno0j5IQvg7RfAVukt AytvZcd0wk1QqbCkwrTQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1odruf-002hWh-9N; Thu, 29 Sep 2022 11:41:09 +0000 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1odrud-002hVc-9C for linux-arm-kernel@lists.infradead.org; Thu, 29 Sep 2022 11:41:08 +0000 Received: by mail-ed1-x52c.google.com with SMTP id u24so1552084edb.11 for ; Thu, 29 Sep 2022 04:41:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=Dw83wxyiv8d9x5gzkn+1kB/8arfTKV9yvRNBKmJCj1w=; b=HYhIixFmCMcXWuK0s+gqC/gCRpGPJvlcnCY0+n5kIOvBMxShrjzttWLHNjaFgQbehG mU9l+hsqyFarc1jW/xT3lTrQiPEdHr/hrvYoIKvN5DS2cZq5IY3mi0FWT17CO191utFO H86TI/w8jonw+bEnTxU5yB5wy+8W++oe6BFaGBESddWmETX2UjFQHdFSurvwLlvfD1y/ A3ggxGJ65FoD0Kim9IqtCeT5GvltP5mMY53nuqvA6iGp1JMmjxpCe/wtbQGThVo+NcBw oEhhXd8eFdXXt36bijLPz3+eElPV3m7Pv+PpaH5R/fcUZc3fx1iMbNNnkMYEgT10Z5jG o3YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=Dw83wxyiv8d9x5gzkn+1kB/8arfTKV9yvRNBKmJCj1w=; b=LOk92sgVgzrv9lcFXtJ2N1pgosnmrxtpb7/MBDMyCXmFLavNW1zHow+v55z5kcyTLM Zr1b3I4lPONgfI/DG7eP82aqftMD6o2TUHHZ/f2xfzt96CvsgWW+PbAWwv8T3kAgKeLN 1YYj9TAX5ktPKfp/GBipjYzOzbM8CoCzI9zbcSYe1ZRvgj9jHvumJ4cjfeGarEFeTBRt 9zSi3JY5QQ56LgiFrKdUbwwLThAhV7FaNdRZG9BPMmOb0MjT3C2YmcNyt4IUasf/t1dl sRzuL6ctXYgaKGYXeCDoVo+6V1VYlmhMifGLti6ZKj3ltRgSuiRzBSCpK3JSn6aepvE1 Lxww== X-Gm-Message-State: ACrzQf0MMEAsGOO6g2QNSbYjyPoOkSaZbMhe3R4p1XaVc4+bAYW1REH9 e5UBCk0/ih1IG/0a1RLP0QQi+A== X-Google-Smtp-Source: AMsMyM7PI78XuR+onhPJYVzNFqVptvRezUc+DvwBLhZWgOXy6OHV4kaokvdBly8hqNswcRHqhAckJg== X-Received: by 2002:a05:6402:50cc:b0:451:bf26:8c51 with SMTP id h12-20020a05640250cc00b00451bf268c51mr3041588edb.336.1664451664374; Thu, 29 Sep 2022 04:41:04 -0700 (PDT) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id g15-20020aa7d1cf000000b0044e937ddcabsm5265346edp.77.2022.09.29.04.41.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Sep 2022 04:41:03 -0700 (PDT) Date: Thu, 29 Sep 2022 13:40:57 +0200 From: Jiri Pirko To: Vadim Fedorenko Cc: Jakub Kicinski , Arkadiusz Kubalewski , Jonathan Lemon , Vadim Fedorenko , Aya Levin , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org Subject: Re: [RFC PATCH v2 0/3] Create common DPLL/clock configuration API Message-ID: References: <20220626192444.29321-1-vfedorenko@novek.ru> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220626192444.29321-1-vfedorenko@novek.ru> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220929_044107_341504_AFFADF8C X-CRM114-Status: GOOD ( 13.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Sun, Jun 26, 2022 at 09:24:41PM CEST, vfedorenko@novek.ru wrote: >From: Vadim Fedorenko > >Implement common API for clock/DPLL configuration and status reporting. >The API utilises netlink interface as transport for commands and event >notifications. This API aim to extend current pin configuration and >make it flexible and easy to cover special configurations. Do you have the userspace part somewhere? It is very nice to add example outputs of user cmdline of such tool to the patch description/cover letter. Also, did you consider usage of sysfs? Why it isn't a better fit than netlink? Regarding the naming, is "dpll" the correct one. Forgive me for being a syncE greenie, but isn't dpll just one algo to achieve syntonous clocks? Perhaps "dco" as for "Digitally Controlled Oscillator" would be somewhat better fit? > >v1 -> v2: > * implement returning supported input/output types > * ptp_ocp: follow suggestions from Jonathan > * add linux-clk mailing list >v0 -> v1: > * fix code style and errors > * add linux-arm mailing list > > >Vadim Fedorenko (3): > dpll: Add DPLL framework base functions > dpll: add netlink events > ptp_ocp: implement DPLL ops > > MAINTAINERS | 8 + > drivers/Kconfig | 2 + > drivers/Makefile | 1 + > drivers/dpll/Kconfig | 7 + > drivers/dpll/Makefile | 7 + > drivers/dpll/dpll_core.c | 161 ++++++++++ > drivers/dpll/dpll_core.h | 40 +++ > drivers/dpll/dpll_netlink.c | 595 ++++++++++++++++++++++++++++++++++++ > drivers/dpll/dpll_netlink.h | 14 + > drivers/ptp/Kconfig | 1 + > drivers/ptp/ptp_ocp.c | 169 +++++++--- > include/linux/dpll.h | 29 ++ > include/uapi/linux/dpll.h | 81 +++++ > 13 files changed, 1079 insertions(+), 36 deletions(-) > create mode 100644 drivers/dpll/Kconfig > create mode 100644 drivers/dpll/Makefile > create mode 100644 drivers/dpll/dpll_core.c > create mode 100644 drivers/dpll/dpll_core.h > create mode 100644 drivers/dpll/dpll_netlink.c > create mode 100644 drivers/dpll/dpll_netlink.h > create mode 100644 include/linux/dpll.h > create mode 100644 include/uapi/linux/dpll.h > >-- >2.27.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel