From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7B08EC433FE for ; Thu, 29 Sep 2022 14:40:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Le17CVsZZCJ3bP92gE9g8T2DeWNZxYDhBO/Y1MhqcKU=; b=dz15tvtYABpDNJ Ojh7kTnZRfvh3i2xbgAQEZgR77aQZqeXc8SCsa4swERrVBQDRzbq/Tyc3E5s5UosOpkTHpQWeHkhx 0r8l60nvPQpNrVVT+mVYznzMNGd912XJYsoo8h75898+6HnLLf/i5jhtqLQuM/XAjzUrvpQyCCwm5 fcIUolPtl3kp5Z6+X03DBr9eO5P2AkPlsAPy7wMV4qTodHLggYD6ceMYZbzQrndjwY2KCxRFAULrF 9PFqBHMb5MQY0Cscglwj+5bZDJdyCqlswfU/W82NssYSAmbIcBmflAb4RLAXHs+jcG/ZnXTSS3Y38 SD2S7ADm9oKGGt80D5Tg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1odugr-003cEp-Nw; Thu, 29 Sep 2022 14:39:05 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1odugn-003cDm-NR for linux-arm-kernel@lists.infradead.org; Thu, 29 Sep 2022 14:39:03 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 735B11650; Thu, 29 Sep 2022 07:39:06 -0700 (PDT) Received: from FVFF77S0Q05N (unknown [10.57.81.100]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4868B3F792; Thu, 29 Sep 2022 07:38:58 -0700 (PDT) Date: Thu, 29 Sep 2022 15:38:52 +0100 From: Mark Rutland To: Jon Hunter Cc: linux-arm-kernel@lists.infradead.org, ardb@kernel.org, catalin.marinas@arm.com, james.morse@arm.com, joey.gouly@arm.com, maz@kernel.org, will@kernel.org, "linux-tegra@vger.kernel.org" Subject: Re: [PATCH v2 6/8] arm64: alternatives: have callbacks take a cap Message-ID: References: <20220912162210.3626215-1-mark.rutland@arm.com> <20220912162210.3626215-7-mark.rutland@arm.com> <3cecc3a5-30b0-f0bd-c3de-9e09bd21909b@nvidia.com> <9317eb32-4dc3-c865-a1ac-320a14ebea56@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220929_073901_876351_35A2A41C X-CRM114-Status: GOOD ( 19.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 29, 2022 at 02:37:54PM +0100, Jon Hunter wrote: > > On 29/09/2022 12:09, Mark Rutland wrote: > > ... > > > > Yes that fixes it. > > > > > > Tested-by: Jon Hunter > > > > Great! > > > > Could you please let me know which version of binutils, so that we can add > > something regarding that in a comment and in the commit message? > > > > The output of ${CROSS_COMPILE}as --version would suffice. > > > > With that, I can clean this up and send as a proper patch. > > > Yes it is ... > > GNU ld (Linaro_Binutils-2017.08) 2.27.0.20161019 Thanks for that! FWIW< I can reproduce that with the Linaro 17.05 toolchain release: | [mark@lakrids:~/src/linux]% uselinaro 17.05 aarch64-linux-gnu-as --version | GNU assembler (Linaro_Binutils-2017.05) 2.27.0.20161019 | Copyright (C) 2016 Free Software Foundation, Inc. | This program is free software; you may redistribute it under the terms of | the GNU General Public License version 3 or later. | This program has absolutely no warranty. | This assembler was configured for a target of `aarch64-linux-gnu'. | [mark@lakrids:~/src/linux]% uselinaro 17.05 make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -s defconfig | [mark@lakrids:~/src/linux]% uselinaro 17.05 make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -s Image | /tmp/ccAy74PK.s: Assembler messages: | /tmp/ccAy74PK.s:2528: Error: found 'L', expected: ')' | /tmp/ccAy74PK.s:2528: Error: found 'L', expected: ')' | /tmp/ccAy74PK.s:2528: Error: found 'L', expected: ')' | /tmp/ccAy74PK.s:2528: Error: found 'L', expected: ')' | /tmp/ccAy74PK.s:2528: Error: junk at end of line, first unrecognized character is `L' | /tmp/ccAy74PK.s:3562: Error: found 'L', expected: ')' | /tmp/ccAy74PK.s:3562: Error: found 'L', expected: ')' | /tmp/ccAy74PK.s:3562: Error: found 'L', expected: ')' | /tmp/ccAy74PK.s:3562: Error: found 'L', expected: ')' | /tmp/ccAy74PK.s:3562: Error: junk at end of line, first unrecognized character is `L' | make[1]: *** [scripts/Makefile.build:249: init/main.o] Error 1 | make: *** [Makefile:1853: init] Error 2 ... but curiously the 17.08 release seems to have a new, working version of binutils: | [mark@lakrids:~/src/linux]% uselinaro 17.08 aarch64-linux-gnu-as --version | GNU assembler (Linaro_Binutils-2017.08) 2.28.2.20170706 | Copyright (C) 2017 Free Software Foundation, Inc. | This program is free software; you may redistribute it under the terms of | the GNU General Public License version 3 or later. | This program has absolutely no warranty. | This assembler was configured for a target of `aarch64-linux-gnu'. | [mark@lakrids:~/src/linux]% uselinaro 17.08 make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -s defconfig | [mark@lakrids:~/src/linux]% uselinaro 17.08 make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j50 -s Image | [mark@lakrids:~/src/linux]% echo $? | 0 ... so I'm not sure why your copy has an older binutils. Regardless, I'll go prep that patch with a real commit message, and add your Tested-by. Thanks, Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel