From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BA540C433F5 for ; Fri, 30 Sep 2022 08:35:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3k9b/E3RjxsIsRzwA58ehXtbjS2OIZO/AuYk+du9JV4=; b=qPNENpRFCXuFfA Qnh1UoK6EpY2fyZRYV1/23qYN0751hgQrMNBhrUj+W0qnkydar7OTcI/jxCggnoYUwmnIl7N1phie GJge7NufrlFgKHk6ItS459If1nLyyV3gSFpt5zRqeeZQX/g9veaJkSz/fa8OAq9zi7PAHvBLu8gtz 4njCOj5jENMNJ53zYPH+7fgJdv1HRGSQmYe06i6kGyJEMsBa94aXn7FKbSsZXUWNs3d7gkQKbpHxp R7DUadSmFstBZqCkfMG6nw2e1qdqftoYstRf+RIJEP7+YCyXCR5btnyBWarWT1MZJIEvXcSxQhMfN uas92MHNZM7KgeRNNZLA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oeBTC-0085vy-B9; Fri, 30 Sep 2022 08:34:06 +0000 Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oeBT7-0085uE-NX for linux-arm-kernel@lists.infradead.org; Fri, 30 Sep 2022 08:34:04 +0000 Received: by mail-ej1-x62e.google.com with SMTP id r18so7525277eja.11 for ; Fri, 30 Sep 2022 01:34:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=zpubVR36akS3Npv0MEhp+71/irYCuHEE1UMxNS0pFeQ=; b=AXmy0ECatIW7X7saqCouPx5jCS/k+FxsqM1Oabkp5bdFgr4MLqKU12l9BGy8m3EGSG SOYRbC4Jyjr23fdAmM3KxKvteauoz5bIBjHnKxk7qzLAz7mQVi+EpZKR6Rtw8/r6JQn0 Xk/Ut9ZwCnEbDDNY+j2FrvTAtmd8cTIDqzpycvfqrovhbDJOVQvL/q65pHz8iFhVN1vf zhyR2Y/75ZNRkViCbWexNrYitDZk8yn657+JgsI9MWGpn9aElrauytccW1lOta8ORgeV 9HfZy91QRr/tV3/cgTCWyTuKkErJQQcX2jpGccpxHF2i9yypUKlC4iRjP2fIvIO7UVCG T44Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=zpubVR36akS3Npv0MEhp+71/irYCuHEE1UMxNS0pFeQ=; b=xfHzUWGErnRtyJRiyOgkaPgqz2MrMk9uIiFI1O8+NjVUo7NTBKl6oCUxdQti1fIx0R AANHsCMhfdfsngw5FUxmOzjcFk8K4JSXXg4f7qNYOQJEtacPOKDYNM4vcB0hdlI7BGwZ GrZ5aYpuHPd49unT2fuC3bruy9m2jsJ7+Kb4kYH0+NW0J0kJMOZbN8QWacQDA2UKCFl7 nkOfFByxDc4OvRE6qHaJ9ATCnBjy0dbe38zdX4qXLfZqyOgGLQ4R89ac8evVuyYHA6u+ fa8pEMcBTACFWB/zGU8kcWVogLkVgxHFePjrcmEyZ8aEQyECb+7F88mcWRA7kFtOvKqw PYIw== X-Gm-Message-State: ACrzQf2CYfWi6yaOEQ8h5xmYSOkGocpgozVNZvUkniYeoypdYMBHRkvJ toTCUditgYjJ5Dq4Nwe0GW6k9g== X-Google-Smtp-Source: AMsMyM5i2deVFFXg/iT90BwccmJSsM6RxySs3C51OSMncVveyqyywH19GoCOiWgNOSIdRX8qb3BPvA== X-Received: by 2002:a17:907:2bd8:b0:770:77f2:b7af with SMTP id gv24-20020a1709072bd800b0077077f2b7afmr5660781ejc.545.1664526839278; Fri, 30 Sep 2022 01:33:59 -0700 (PDT) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id 6-20020a170906318600b0078116c361d9sm874085ejy.10.2022.09.30.01.33.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Sep 2022 01:33:58 -0700 (PDT) Date: Fri, 30 Sep 2022 10:33:57 +0200 From: Jiri Pirko To: Vadim Fedorenko Cc: Jakub Kicinski , Arkadiusz Kubalewski , Jonathan Lemon , Vadim Fedorenko , Aya Levin , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org Subject: Re: [RFC PATCH v2 0/3] Create common DPLL/clock configuration API Message-ID: References: <20220626192444.29321-1-vfedorenko@novek.ru> <6b80b6c8-29fd-4c2a-e963-1f273d866f12@novek.ru> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6b80b6c8-29fd-4c2a-e963-1f273d866f12@novek.ru> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220930_013401_793230_B212D2F3 X-CRM114-Status: GOOD ( 23.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Fri, Sep 30, 2022 at 02:44:25AM CEST, vfedorenko@novek.ru wrote: >On 29.09.2022 12:40, Jiri Pirko wrote: >> Sun, Jun 26, 2022 at 09:24:41PM CEST, vfedorenko@novek.ru wrote: >> > From: Vadim Fedorenko >> > >> > Implement common API for clock/DPLL configuration and status reporting. >> > The API utilises netlink interface as transport for commands and event >> > notifications. This API aim to extend current pin configuration and >> > make it flexible and easy to cover special configurations. >> >> Do you have the userspace part somewhere? >> It is very nice to add example outputs of user cmdline of such tool to >> the patch description/cover letter. > >Sorry, but we don't have any user-space part for now. It's still WIP and >there are too many changes in the protocol to implement anything useful on What protocol? >top of it. Once we will get to a kind of "stable" proto, I will implement a >library to use it. > >> >> Also, did you consider usage of sysfs? Why it isn't a better fit than >> netlink? > >We already have sysfs implemented in the ptp_ocp driver. But it looks like >more hardware is going to be available soon with almost the same functions, >so it would be great to have common protocol to configure such devices. Sure, but more hw does not mean you can't use sysfs. Take netdev as an example. The sysfs exposed for it is implemented net/core/net-sysfs.c and is exposed for all netdev instances, no matter what the driver/hardware is. >> >> Regarding the naming, is "dpll" the correct one. Forgive me for being a >> syncE greenie, but isn't dpll just one algo to achieve syntonous >> clocks? Perhaps "dco" as for "Digitally Controlled Oscillator" would be >> somewhat better fit? >> > >We will discuss the naming too, thanks! > >> >> > >> > v1 -> v2: >> > * implement returning supported input/output types >> > * ptp_ocp: follow suggestions from Jonathan >> > * add linux-clk mailing list >> > v0 -> v1: >> > * fix code style and errors >> > * add linux-arm mailing list >> > >> > >> > Vadim Fedorenko (3): >> > dpll: Add DPLL framework base functions >> > dpll: add netlink events >> > ptp_ocp: implement DPLL ops >> > >> > MAINTAINERS | 8 + >> > drivers/Kconfig | 2 + >> > drivers/Makefile | 1 + >> > drivers/dpll/Kconfig | 7 + >> > drivers/dpll/Makefile | 7 + >> > drivers/dpll/dpll_core.c | 161 ++++++++++ >> > drivers/dpll/dpll_core.h | 40 +++ >> > drivers/dpll/dpll_netlink.c | 595 ++++++++++++++++++++++++++++++++++++ >> > drivers/dpll/dpll_netlink.h | 14 + >> > drivers/ptp/Kconfig | 1 + >> > drivers/ptp/ptp_ocp.c | 169 +++++++--- >> > include/linux/dpll.h | 29 ++ >> > include/uapi/linux/dpll.h | 81 +++++ >> > 13 files changed, 1079 insertions(+), 36 deletions(-) >> > create mode 100644 drivers/dpll/Kconfig >> > create mode 100644 drivers/dpll/Makefile >> > create mode 100644 drivers/dpll/dpll_core.c >> > create mode 100644 drivers/dpll/dpll_core.h >> > create mode 100644 drivers/dpll/dpll_netlink.c >> > create mode 100644 drivers/dpll/dpll_netlink.h >> > create mode 100644 include/linux/dpll.h >> > create mode 100644 include/uapi/linux/dpll.h >> > >> > -- >> > 2.27.0 >> > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel