From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3A60DC433F5 for ; Mon, 3 Oct 2022 09:34:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Khvdm4JY5VhmjDAv/UcAbsa57/u0KWOO27EyiYdwwuY=; b=xQUO7GILFPTkAz pxUPWw/QKldP17vp40Y6f8XX6Bh3AuLku5fginkstZKyb7meRTTum+R03n8JgLMmjXbr2f5yAj83+ bvDcSKToSTH1vL75ggTCoVL3FgQU1Hm786JAx0bK6kQq+vQouYKOeCoZGB3HUlLxntSF35npN2dIp Rtj1lWTp7iCElrM+/o/9+nr4XDMpX21Go+zIaq4BNo/dMHYrFTUy7JXxHNcV4MH2rjsozYvlIDvVf f6M6O30JYTFm6XZDdOwfJyaID5k+X/GcyRdWO2ok4GFTU9i/A02un3WmZnA9fivqMRRrLEEzFYOvR 1zBT0xYBEq0V/DUykpjQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ofHpe-0054Co-Vp; Mon, 03 Oct 2022 09:33:51 +0000 Received: from esa.microchip.iphmx.com ([68.232.153.233]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ofHpb-0054BU-0d for linux-arm-kernel@lists.infradead.org; Mon, 03 Oct 2022 09:33:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1664789627; x=1696325627; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=PYeei6SZcVZxGnMlsYmYsEkttjI1rAXmMoWB8ROufiU=; b=vSMoNW0OBAKb0E1/rFreA+coMjuc/yrU6vX3dOhXCaITSC03+mc3vtv0 rhlfMhL+3QiVQxHy8n1KTBaWErm5ZvbTknJyq4HhCkPm61CwQD/ff8wZP w5ztLKOfm+B+1rPFJZj8yR3L9oyDBd/mo76EP91/spyhEasCU2opb9+8U 3UaUC1hqeCZrITe8MFZEsAfJUNyx0AtruVHujIdK35y3Eo0XRVU8nMaFc wSqs/T9OpOqBc23OTi/MBFLQizfNOhDt37UUWWmtRSkPoDzhITrUrWRsa 8YYcgljviIVgeTiWTUGjBkQUhMb6/p3/HSGeaZumGt7HJIBWgXCqjKQEy Q==; X-IronPort-AV: E=Sophos;i="5.93,365,1654585200"; d="scan'208";a="183070105" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa3.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 03 Oct 2022 02:33:43 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Mon, 3 Oct 2022 02:33:43 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12 via Frontend Transport; Mon, 3 Oct 2022 02:33:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UJYI8ZeQgOkZ6SBbEuYlmmbI0sHUoXN/sX61L/ryUktJMh5uwRFxsLKKLOOdBb1Qs3cbR5WByLdXTU6WXxTUxWecTzK4jzV5TyDahFfGpoLmPlAXn2INHtePJaPGHBhQf84B+AuOMkjWbQjAoXa5rnZ/+4EchmzP2zAquVCkFh3/jp8hOopg7KrkI5uwAgRBfG67mA3ZH9D28j7X346AYNqVLhqQi5BgZdlCeG7kWmK7iNAZTn/QraxKHfqzdeEVTAWKSgxX2ixjBbBIrrd5WpzidaEJ6zrsnb9/urxzqT48ih0F+hCEA8cscDUrEJJESr62VFNtI70nEw2U5NjEGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PYeei6SZcVZxGnMlsYmYsEkttjI1rAXmMoWB8ROufiU=; b=N9uGAIq4VfwWGgsLBT7473D7T+u4bRDI3600m5qwhrxm8qYZkBM1kVDcZbJWnn86AreD8QE1ixdOX5WPeQwZnTn4kmsoxMtEZ2GbAUdOHm19rJ0oScUTmqCRaDTRtts+WRqzi65nmHMV9KIeOSDnrv0W0+EeErT1I6ehaLFLO3Zyu5kSew+SdgtWrRPDpTBSx2i5t10seE9uDZMUILXazzODEGDEi0ECjp4WG9eWkw/4vqC4Q81fRRoRbzl8SZw6dB48lof7Fu8XoHQUmeczC7F29Qqu0UnwcowqU+UdfL5q6fPVd5vgJv5/OzlCoONnhheRYtAcmlZee0MKDcn/3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PYeei6SZcVZxGnMlsYmYsEkttjI1rAXmMoWB8ROufiU=; b=KmA+mNN6BGrx8c/5459c/mfn/2wt1UmOLJ5scbHQ3HxA18dauc2HRvPrJkDXQrW71xKE3Bc5alP9tmLbTMCBUyWw9q07er8Tl83VGrE0Vc8zfM/iRfl2zuA8we1N9uwJpNXD/57V7YFq3a5HXFjQHBCaiIpwPxfnjoPqyYQjjow= Received: from PH0PR11MB5580.namprd11.prod.outlook.com (2603:10b6:510:e5::10) by CY8PR11MB6889.namprd11.prod.outlook.com (2603:10b6:930:5e::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Mon, 3 Oct 2022 09:33:41 +0000 Received: from PH0PR11MB5580.namprd11.prod.outlook.com ([fe80::782e:76ed:b02d:c99a]) by PH0PR11MB5580.namprd11.prod.outlook.com ([fe80::782e:76ed:b02d:c99a%5]) with mapi id 15.20.5676.028; Mon, 3 Oct 2022 09:33:41 +0000 From: To: CC: , , , , , , , , , , , , , , , , Subject: Re: [PATCH net-next v2 1/6] net: dcb: add new pcp selector to app object Thread-Topic: [PATCH net-next v2 1/6] net: dcb: add new pcp selector to app object Thread-Index: AQHY1DNRRCKA3W+lZk2MiTdViI2XRa335cAAgARc1ICAABepAIAAFpsA Date: Mon, 3 Oct 2022 09:33:41 +0000 Message-ID: References: <20220929185207.2183473-1-daniel.machon@microchip.com> <20220929185207.2183473-2-daniel.machon@microchip.com> <87leq1uiyc.fsf@nvidia.com> <87czb9xpsi.fsf@nvidia.com> In-Reply-To: <87czb9xpsi.fsf@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microchip.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5580:EE_|CY8PR11MB6889:EE_ x-ms-office365-filtering-correlation-id: 929a3a86-d031-4ec2-7521-08daa5225bc0 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8JYAXBcsc9pVeC9KMPnilru7CGj7CRn2bDO5nw1RrSYIP9cOpZHGrBJU5Mljwlg7CC2v8Ic2h7zUdsNU8KKDndxagbuH9I9DI+Dk4NZiBXsiplZD+2TmyA7yskX/0TuBTqS4avcNU1z7lNqwE+X7RxvwxZEGY++0NSb6Gx/2qfRPEavEUxUJrqRkh6T2UxlSIIiaJw8UoO6XhcSftSgKJvlZDrE1G6SeFo0SyFYCGxQ9KUpQA0keTs46fL6Ey+MQqxRgV63DCcjkdeo38yZ7URZUdII8VYiFObocbP0jb/FbTUEn/nqXBp1o3oInVNpIiNW8rGmrKQbsyhO5VqBtTfpDCOc/WMXiYWCJFzabTBOetEvNk6PgejYh6QjUvgVUyuNp4TTOTFQRCPLCJiUGlwG4i612nO+Km7VETdZBNe+a1fzRur3PaPDeKywWLraIbC1aZ149kwA9L0kVwrcuZP2O1jadqxWVe93CwlXEuiO8jPc9jul31y7EyEOfb8OfSflAStxeDwhjnU5Kdazj9Ich3i8VEr7Z4DJWroIMUPV9/bkuvVBeQFL35QNSo2r4HU3xdDLm3yWJqH580tdM5jilcuXvz93a4PzPHnJ8yVn3s7BXMPSD2nlIIKGc3dnlgOYFiR0ZjHWt4BJPLTQ1X2YxF1behROB8kX78tmxedCKq+0TBhUfOqSabe+BTLW7Y2RCFZ5Qhz0PU2lKrG4M5u64mYzGcdMK6CtBeJTAsh4FfNNqi/pmaU3Wd+eW5vS9mP60B3SJFdiM++DYoPDavE8u0kC07vsdpuJSAaNEG14= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5580.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(376002)(366004)(39860400002)(346002)(136003)(396003)(451199015)(316002)(54906003)(6916009)(6506007)(6512007)(9686003)(86362001)(38100700002)(66946007)(76116006)(66476007)(33716001)(6486002)(8676002)(71200400001)(4326008)(26005)(66556008)(478600001)(91956017)(7416002)(186003)(5660300002)(64756008)(66446008)(41300700001)(8936002)(122000001)(2906002)(38070700005)(67856001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ht9j2MPYFBWcIMBtm3mwsF7zs4RnyWF07D9DxwT/fufjjk+RxS1is8+n0KTa?= =?us-ascii?Q?L59mxvSfDtri0tCgh5LvA9HDIvsKA7tic6mU+zsCN6c1WMc6EWujMrY1eSKN?= =?us-ascii?Q?E/OJN4yTbqeTAsAvV9kIGel2XwEXGIVBVfeNfgVal29GmFUbPSGy3LBLs3e8?= =?us-ascii?Q?4V2c9pbjJ6hYnA44Dv1f4NvxkjcroVZXFqQPbHrj/8n/Df0ZKxKEPXIX6s63?= =?us-ascii?Q?8Chzu23akCqlu3M5/D0fpgT8HbI6DfwN6UUG/P29mQ5Dse4RLWsL50eZi06L?= =?us-ascii?Q?p1EzYie15EeXGgoQsrOY34GHV75zYT960Imqd5SbDaOGGZtblXqJZ1/7c6Pw?= =?us-ascii?Q?M4fjyQn0USlw7GUeEqKsI/K1WNpbUm2F1a1FAPSWpgcJme16260fTkKoAj6P?= =?us-ascii?Q?7K8W9Q6wEkREkkS5XF0Q/ig2xftD9L6k3iHnklsu/ucb56DIDjYJ0S+jw+zs?= =?us-ascii?Q?t28TdLCaacaIiAcrJIK1fbSsjKzUQh8+MRhDp1CaTX4RBieYR6+l3zVS7HVs?= =?us-ascii?Q?nnq7bNMvRDTj7AwgGIG9NzdFAPVWsI3KugubJqTPpoFszZiXALovDj6tVgf2?= =?us-ascii?Q?vNx4MpCKbydAm/IwFwzQx6H9Tve3e6Fd73Zh4L6DtapiRVppCrKoRvdyXNo+?= =?us-ascii?Q?HFfO/wtJp7vlxfzso987f4OdraQvgmJjmlVXRxsGHdC+fuoz4DB/hF1KFKn6?= =?us-ascii?Q?WJ0CV8UHzHOqw/t+LHpd9+xeci1iP7AiU0LnpSSAPTr0qlt1azQnpvCv165+?= =?us-ascii?Q?nNdEm/bhi7xcbr8lmOasqjPn9gWDW6wYpM7CC8IBL+Fer0SDu4c2eCqny1zs?= =?us-ascii?Q?RezBZEkQDU177ZEtMolAT4kkJ0COLhsKTKMqvujDOQsNFX1FJDSzJLXY2c+f?= =?us-ascii?Q?e0z1UUkX5UtwqzePHqkInC3H7uHIzB7CRt6QdFXPpveTd2jZHscP8WQ7Iz2k?= =?us-ascii?Q?e6d6m6AtX8epKhNQtoiwo7JBHsRGdG6NnRnjC7fI0cJ0xSUy4BAzSP29ou5b?= =?us-ascii?Q?SBUmWEsGajIawyI9t98tME6AumKsduRe92KGLLSqyaNYtPmG3plUfZXdCC14?= =?us-ascii?Q?DA2Mqag0xAZLe+vvu2IlgJ0+y6Txt6m/0R6zBixDChF62k7JxS8V4FVuB8EK?= =?us-ascii?Q?zwKMR/FQynZ01SB+PBgBqHkNyamhgl9wWvu7m9noxLJTczJjHlGIKppaVZ5s?= =?us-ascii?Q?xllKwkbpaL3TEQliPbGGXAwNBbmmPZwfTC7n0SO7IHnDOYt/0h8mWTjuhZoB?= =?us-ascii?Q?jNCiDOKm3yYnw9duU/o9mV9nVITt5wxkOihWy0aAIt2398/Vnqg81wv633/3?= =?us-ascii?Q?9tUDl2GeeUI5dcLQ55SvpCYn4kJGUY+IVb7lPSSHoErRineu6RfIwJJ2RcqZ?= =?us-ascii?Q?bfP3IzwTdzbHnenFHYi2/DCWUR2YB4mocfqICyvZmNMgW+CAuI8/oQiVNg/+?= =?us-ascii?Q?dsUpwU3srM4DPCYHmGMvpqmGXHuEgg+2ExZF4RakbyCkLHiu1k7h2O5S3s+d?= =?us-ascii?Q?jXa5B+T9SQPUzO3iqVgGJHZ5mc67LqIfuU6naLonwl55IAZ4TZx6WG3e32ou?= =?us-ascii?Q?ctR9bmLHd3BvHzvgxJz5N2Q+W/QyagxIXGpmkSb5DFnndvqGySXcFSR0W8rJ?= =?us-ascii?Q?u+O+wfaDSl7hwAMHXv7PaLc=3D?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5580.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 929a3a86-d031-4ec2-7521-08daa5225bc0 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Oct 2022 09:33:41.3000 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LSArfjyfkncSFNAZMMsB0XTTDEPOzM1remYOGq/tCw4gR2mPAUbTy4UYI9PQp0OcK+/qv5qBJgnpqZQmtbh3cehpHVm8IRKr7wJweHVAiOA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB6889 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221003_023347_359148_9464978C X-CRM114-Status: GOOD ( 19.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Den Mon, Oct 03, 2022 at 10:22:48AM +0200 skrev Petr Machata: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > writes: > > > Right, I see your point. But. First thought; this starts to look a little > > hackish. > > So it is. That's what poking backward compatible holes in an existing > API gets you. Look at modern C++ syntax for an extreme example :) > > But read Jakub's email. It looks like we don't actually need to worry > about this. > > > Looking through the 802.1Q-2018 std again, sel bits 0, 6 and 7 are > > reserved (implicit for future standard implementation?). Do we know of > > any cases, where a new standard version would introduce new values beyond > > what was reserved in the first place for future use? I dont know myself. > > > > I am just trying to raise a question of whether using the std APP attr > > with a new high (255) selector, really could be preferred over this new > > non-std APP attr with new packed payload. > > Yeah. We'll need to patch lldpad anyway. We can basically choose which > way we patch it. And BTW, using the too-short attribute payload of > course breaks it _as well_, because they don't do any payload size > validation. Right, unless we reconstruct std app entry payload from the "too-short" attribute payload, before adding it the the app list or passing it to the driver. Anyway. Considering Jakub's mail. I think this patch version with a non-std attribute to do non-std app table contributions separates non-std from std stuff nicely and is preffered over just adding the new selector. So if we can agree on this, I will prepare a new v. with the other changes suggested. Wrt. lldpad we can then patch it to react on attrs or selectors > 7. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel