Re: [PATCH 1/1] dt-bindings: media: convert imx.txt to yaml format

[Frank Li <Frank.li@nxp.com>]

On Wed, Apr 16, 2025 at 05:26:19PM +0200, Philipp Zabel wrote:
> On Mi, 2025-04-16 at 11:17 -0400, Frank Li wrote:
> > On Wed, Apr 16, 2025 at 07:42:26AM -0500, Rob Herring wrote:
> > > On Mon, Apr 14, 2025 at 05:07:18PM -0400, Frank Li wrote:
> > > > Convert binding doc imx.txt to yaml format. Create two yaml files:
> > > > fsl,imx6-mipi-csi2.yaml and fsl,imx-capture-subsystem.yaml.
> > > >
> > > > Additional changes:
> > > > - add example for fsl,imx6-mipi-csi2
> > > >
> > > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > > ---
> > > >  .../media/fsl,imx-capture-subsystem.yaml      |  38 ++++++
> > > >  .../bindings/media/fsl,imx6-mipi-csi2.yaml    | 126 ++++++++++++++++++
> > > >  .../devicetree/bindings/media/imx.txt         |  53 --------
> > > >  3 files changed, 164 insertions(+), 53 deletions(-)
> > > >  create mode 100644 Documentation/devicetree/bindings/media/fsl,imx-capture-subsystem.yaml
> > > >  create mode 100644 Documentation/devicetree/bindings/media/fsl,imx6-mipi-csi2.yaml
> > > >  delete mode 100644 Documentation/devicetree/bindings/media/imx.txt
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/media/fsl,imx-capture-subsystem.yaml b/Documentation/devicetree/bindings/media/fsl,imx-capture-subsystem.yaml
> > > > new file mode 100644
> > > > index 0000000000000..77be3c1f37c5b
> > > > --- /dev/null
> > > > +++ b/Documentation/devicetree/bindings/media/fsl,imx-capture-subsystem.yaml
> > > > @@ -0,0 +1,38 @@
> > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > > +%YAML 1.2
> > > > +---
> > > > +$id: http://devicetree.org/schemas/media/fsl,imx-capture-subsystem.yaml#
> > > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > > +
> > > > +title: Freescale i.MX Media Video Device
> > > > +
> > ...
> > > > +        reg = <0x021dc000 0x4000>;
> > > > +        #address-cells = <1>;
> > > > +        #size-cells = <0>;
> > > > +        clocks = <&clks IMX6QDL_CLK_HSI_TX>,
> > > > +                 <&clks IMX6QDL_CLK_VIDEO_27M>,
> > > > +                 <&clks IMX6QDL_CLK_EIM_PODF>;
> > > > +        clock-names = "dphy", "ref", "pix";
> > > > +
> > > > +        port@0 {
> > > > +            reg = <0>;
> > > > +
> > > > +            endpoint {
> > > > +                remote-endpoint = <&ov5640_to_mipi_csi2>;
> > > > +                clock-lanes = <0>;
> > > > +                data-lanes = <1 2>;
> > > > +            };
> > > > +        };
> > >
> > > I would think at least 1 output port is required?
> >
> > I checked dts file, only input port. I think old csi2 only need get data
> > from camera. csi's dma should save to memory.
>
> There are no ports in imx6qdl.dtsi, but there's a &mipi_csi with four
> output ports in imx6q.dtsi and imx6dl.dtsi each, because whether data
> flows through a mux or directly into the IPU CSI ports differs between
> the two platforms.

Thank you very much!

Frank
>
> regards
> Philipp
>