Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Frank Li <Frank.li@nxp.com>
To: Adam Ford <aford173@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org, aford@beaconembedded.com,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	devicetree@vger.kernel.org, imx@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/9] arm64: dts: imx8mm-beacon: Fix HDMI sound output
Date: Thu, 10 Apr 2025 12:07:19 -0400	[thread overview]
Message-ID: <Z/fst7AzAJ3q0iDi@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20250410005912.118732-4-aford173@gmail.com>

On Wed, Apr 09, 2025 at 07:58:58PM -0500, Adam Ford wrote:
> The HDMI bridge chip's sound card enumerates, but it does not generate
> sound. This is because the sai5 node is missing the flag telling it
> to set the mclk as output.
>
Suggest commit message:

arm64: dts: imx8mm-beacon: Set SAI5 MCLK direction to output for HDMI audio

The HDMI bridge chip fails to generate an audio source due to the SAI5
master clock (MCLK) direction not being set to output. This prevents proper
clocking of the HDMI audio interface.

Add the `fsl,sai-mclk-direction-output` property to the SAI5 node to ensure
the MCLK is driven by the SoC, resolving the HDMI sound issue.

Frank

> Fixes: 8ad7d14d99f3 ("arm64: dts: imx8mm-beacon: Add HDMI video with sound")
> Signed-off-by: Adam Ford <aford173@gmail.com>
> ---
>  arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dts | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dts b/arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dts
> index 97ff1ddd6318..734a75198f06 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dts
> @@ -124,6 +124,7 @@ &sai5 {
>  	assigned-clock-parents = <&clk IMX8MM_AUDIO_PLL1_OUT>;
>  	assigned-clock-rates = <24576000>;
>  	#sound-dai-cells = <0>;
> +	fsl,sai-mclk-direction-output;
>  	status = "okay";
>  };
>
> --
> 2.48.1
>


  reply	other threads:[~2025-04-10 17:27 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-10  0:58 [PATCH 1/9] arm64: dts: imx8mm-beacon: Fix RTC capacitive load Adam Ford
2025-04-10  0:58 ` [PATCH 2/9] arm64: dts: imx8mn-beacon: " Adam Ford
2025-04-10  0:58 ` [PATCH 3/9] arm64: dts: imx8mp-beacon: " Adam Ford
2025-04-10  0:58 ` [PATCH 4/9] arm64: dts: imx8mm-beacon: Fix HDMI sound output Adam Ford
2025-04-10 16:07   ` Frank Li [this message]
2025-04-10  0:58 ` [PATCH 5/9] arm64: dts: imx8mn-beacon: " Adam Ford
2025-04-10  0:59 ` [PATCH 6/9] arm64: dts: imx8mm-beacon: Configure Ethernet reset and IRQ GPIO Adam Ford
2025-04-10 16:11   ` Frank Li
2025-04-10  0:59 ` [PATCH 7/9] arm64: dts: imx8mn-beacon: " Adam Ford
2025-04-10  0:59 ` [PATCH 8/9] arm64: dts: imx8mm-beacon: Enable RTC interrupt and wakeup-source Adam Ford
2025-04-10 16:14   ` Frank Li
2025-04-10  0:59 ` [PATCH 9/9] arm64: dts: imx8mn-beacon: " Adam Ford
2025-04-10 15:58 ` [PATCH 1/9] arm64: dts: imx8mm-beacon: Fix RTC capacitive load Frank Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z/fst7AzAJ3q0iDi@lizhi-Precision-Tower-5810 \
    --to=frank.li@nxp.com \
    --cc=aford173@gmail.com \
    --cc=aford@beaconembedded.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox