Re: [PATCH v2 4/7] arm64: dts: exynos: gs101: Add 'local-timer-stop' to cpuidle nodes

Peter Griffin
2025-05-08T10:15:04Z

Hi Will,

On Thu, 3 Apr 2025 at 00:34, Will McVicker <willmcvicker@google.com> wrote:
>
> From: Will Deacon <willdeacon@google.com>
>
> In preparation for switching to the architected timer as the primary
> clockevents device, mark the cpuidle nodes with the 'local-timer-stop'
> property to indicate that an alternative clockevents device must be
> used for waking up from the "c2" idle state.
>
> Signed-off-by: Will Deacon <willdeacon@google.com>
> [Original commit from https://android.googlesource.com/kernel/gs/+/a896fd98638047989513d05556faebd28a62b27c]
> Signed-off-by: Will McVicker <willmcvicker@google.com>
> ---

Reviewed-by: Peter Griffin <peter.griffin@linaro.org>
Tested-by: Peter Griffin <peter.griffin@linaro.org>

Tested using gs101-oriole with linux-next plus this series. With these
MCT timer changes and another series I will send shortly for
exynos-pmu to program the correct hint to ACPM wakeup from c2 idle
state is then functional.

> arch/arm64/boot/dts/exynos/google/gs101.dtsi | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
> index 3de3a758f113..fd0badf24e6f 100644
> --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi
> +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
> @@ -155,6 +155,7 @@ ananke_cpu_sleep: cpu-ananke-sleep {
> idle-state-name = "c2";
> compatible = "arm,idle-state";
> arm,psci-suspend-param = <0x0010000>;
> + local-timer-stop;
> entry-latency-us = <70>;
> exit-latency-us = <160>;
> min-residency-us = <2000>;
> @@ -164,6 +165,7 @@ enyo_cpu_sleep: cpu-enyo-sleep {
> idle-state-name = "c2";
> compatible = "arm,idle-state";
> arm,psci-suspend-param = <0x0010000>;
> + local-timer-stop;
> entry-latency-us = <150>;
> exit-latency-us = <190>;
> min-residency-us = <2500>;
> @@ -173,6 +175,7 @@ hera_cpu_sleep: cpu-hera-sleep {
> idle-state-name = "c2";
> compatible = "arm,idle-state";
> arm,psci-suspend-param = <0x0010000>;
> + local-timer-stop;
> entry-latency-us = <235>;
> exit-latency-us = <220>;
> min-residency-us = <3500>;
> --
> 2.49.0.472.ge94155a9ec-goog
>