From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Maxim Uvarov <muvarov@gmail.com>
Cc: "谢致邦 (XIE Zhibang)" <Yeking@red54.com>,
ardb@kernel.org, bjorn.andersson@sonyericsson.com,
dave@vasilevsky.ca, ebiggers@google.com,
linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, liuyuntao12@huawei.com,
lumag@kernel.org, masahiroy@kernel.org, nathan@kernel.org,
nico@fluxnic.net, oskar.andero@sonyericsson.com,
ruanjinjie@huawei.com, victor.boivie@sonyericsson.com,
"Rob Herring" <robh@kernel.org>
Subject: Re: Re: [PATCH] ARM: Fix support for CMDLINE_EXTEND
Date: Mon, 31 Mar 2025 16:18:05 +0100 [thread overview]
Message-ID: <Z-qyLY-Moj5Uo8XH@shell.armlinux.org.uk> (raw)
In-Reply-To: <CAJGZr0+zcy+28bJydUo88zpNBN-M2-qcaahr8Pxg=yfdT6RAPg@mail.gmail.com>
On Mon, Mar 31, 2025 at 06:14:27PM +0300, Maxim Uvarov wrote:
> It will be good to have some constance here with other arches:
> ./arch/arm/kernel/atags_parse.c:#if defined(CONFIG_CMDLINE_EXTEND)
> ./arch/sh/kernel/setup.c:#ifdef CONFIG_CMDLINE_EXTEND
> ./arch/powerpc/kernel/prom_init.c: if
> (IS_ENABLED(CONFIG_CMDLINE_EXTEND) || l <= 0 || p[0] == '\0')
> ./arch/loongarch/kernel/setup.c: * CONFIG_CMDLINE_EXTEND is enabled.
> ./arch/loongarch/kernel/setup.c: if
> (IS_ENABLED(CONFIG_CMDLINE_EXTEND) && CONFIG_CMDLINE[0]) {
> ./arch/riscv/kernel/pi/cmdline_early.c: if
> (IS_ENABLED(CONFIG_CMDLINE_EXTEND) ||
>
> Or drop CONFIG_CMDLINE_EXTEND completely or make arm64 work as others.
I'm not changing something that has had 14 years of being the way it's
been - people will have come to rely upon it. Changing it now is way
too late.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
prev parent reply other threads:[~2025-03-31 15:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-28 10:20 [PATCH] ARM: Fix support for CMDLINE_EXTEND Yeking
2025-03-28 12:29 ` Russell King (Oracle)
[not found] ` <tencent_F967B6C3FF5405F2D17EF660590BFD213C0A@qq.com>
2025-03-31 12:55 ` Russell King (Oracle)
2025-03-31 13:34 ` Russell King (Oracle)
2025-03-31 15:14 ` Maxim Uvarov
2025-03-31 15:18 ` Russell King (Oracle) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-qyLY-Moj5Uo8XH@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=Yeking@red54.com \
--cc=ardb@kernel.org \
--cc=bjorn.andersson@sonyericsson.com \
--cc=dave@vasilevsky.ca \
--cc=ebiggers@google.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyuntao12@huawei.com \
--cc=lumag@kernel.org \
--cc=masahiroy@kernel.org \
--cc=muvarov@gmail.com \
--cc=nathan@kernel.org \
--cc=nico@fluxnic.net \
--cc=oskar.andero@sonyericsson.com \
--cc=robh@kernel.org \
--cc=ruanjinjie@huawei.com \
--cc=victor.boivie@sonyericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).