Re: [boot-wrapper v5] aarch64: Start Xen on Armv8-R at EL2

[Mark Rutland <mark.rutland@arm.com>]

On Thu, Nov 28, 2024 at 11:06:14AM +0000, Luca Fancellu wrote:
> > On 28 Nov 2024, at 11:03, Mark Rutland <mark.rutland@arm.com> wrote:
> > On Wed, Nov 27, 2024 at 10:23:00AM +0000, Luca Fancellu wrote:
> >> When bootwrapper is compiled with Xen support and it is started
> >> at EL2 on Armv8-R AArch64, keep the current EL and jump to the
> >> Xen image using the SPSR_KERNEL as spsr_el2 value.
> >>
> >> The only available boot method on Armv8-R AArch64 when starting
> >> Xen is spin table at the moment, reflect this in the build
> >> configuration.
> >>
> >> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>

> >> +# Don't allow PSCI + Xen + aarch64-r
> >> +AS_IF([test "x$USE_PSCI" = "xyes" -a "x$USE_ARCH" = "xaarch64-r" -a "x$X_IMAGE" != "x"],
> >> + [AC_MSG_ERROR([With aarch64-r and Xen, PSCI must be disabled.])]
> >> +)
> >
> > I'll delete the comment and change the message here to:
> >
> > With an AArch64-R Xen, boot method must be spin-table.
> >
> > ... since that's consistent with the other message above:
> >
> > With an AArch32 kernel, boot method must be PSCI.
> >
> > ... and it's slightly nicer to tell the user what will work rather than
> > what won't work.
> >
> > Otherwise this looks fine to me, and I will apply this shortly (with
> > those changes) if no-one objects.
> 
> Sounds good to me! Thanks!

Thanks; applied (with those fixups).

Mark.