From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 83090E69172 for ; Sat, 23 Nov 2024 19:32:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:Date:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+VIbTwyaBoGicddBdmbfrc9X51L9kzP0D91jG7G3nuM=; b=YhoQGD6FsQIzwt2IKgJtlNGt3T Ij4IY25p/4mr3syk/ZKSi6rfS5Ouiyi34E4ZFyCtQfZ2y8r7LRmLtV9TK+OR67alXmJ/o0OpdDAH+ tgJIWLHAxDqfdBPgE6NgddvJD/IRTxEDIa7Ep/R55jVI6YG7pyzaAYvozcf5W8qKBR6Qk6470Yqto 0fUa11g3zpn003MRgay0+KsVni/A14wP5n80AdMpRwjZdpmI505uDiySom8vOhuIoYKzxqQpFJUwt /LkiVrhcbIcF6n+qfCtaLLnW4d4ovvkmLgIdi5Wlzrd2WG3OMUVJRjU+qgtQ2xErS3qFBHBOu2FIS ySeiFcgw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tEvrU-00000004mU7-0u2c; Sat, 23 Nov 2024 19:32:08 +0000 Received: from fgw20-7.mail.saunalahti.fi ([62.142.5.81]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tEvqX-00000004mMd-2T6p for linux-arm-kernel@lists.infradead.org; Sat, 23 Nov 2024 19:31:10 +0000 Received: from localhost (88-113-25-143.elisa-laajakaista.fi [88.113.25.143]) by fgw23.mail.saunalahti.fi (Halon) with ESMTP id 79edaa06-a9d1-11ef-a0f6-005056bdfda7; Sat, 23 Nov 2024 21:31:05 +0200 (EET) From: Andy Shevchenko Date: Sat, 23 Nov 2024 21:31:02 +0200 To: Javier Carrasco Cc: Pavel Machek , Lee Jones , Matthias Brugger , AngeloGioacchino Del Regno , Gene Chen , Jacek Anaszewski , Bartosz Golaszewski , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Jonathan Cameron , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH 05/18] leds: cr0014114: switch to device_for_each_child_node_scoped() Message-ID: References: <20240927-leds_device_for_each_child_node_scoped-v1-0-95c0614b38c8@gmail.com> <20240927-leds_device_for_each_child_node_scoped-v1-5-95c0614b38c8@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240927-leds_device_for_each_child_node_scoped-v1-5-95c0614b38c8@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241123_113109_803368_E3D0977C X-CRM114-Status: UNSURE ( 9.89 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Fri, Sep 27, 2024 at 01:20:56AM +0200, Javier Carrasco kirjoitti: > Switch to device_for_each_child_node_scoped() to simplify the code by > removing the need for calls to fwnode_handle_put() in the error paths. > > This also prevents possible memory leaks if new error paths are added > without the required call to fwnode_handle_put(). ... > if (ret) { > dev_err(priv->dev, > "failed to register LED device, err %d", ret); > - fwnode_handle_put(child); > return ret; Now it can be return dev_err_probe(..., ret, "failed to register LED device"); > } -- With Best Regards, Andy Shevchenko