From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 84A3AE66882 for ; Sat, 23 Nov 2024 19:41:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:Date:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1pzcTJwG9WcXay0jNHX9JqAvwk4neYrcZe7pOZVIiJY=; b=z1zmlpuLrnYtAeHvD36LBLEkhR 3UfkyqiCaLsi96xwxzmtF9mt4TAECDZEOj/tNLAQbpczkGaAtFEh16nDdsZ/HvVE1N0/PQogi/yG0 6tT6T31ORt7ymfqH5oGexJlChkeB+QMkiz5OGZQ1ux/RFYdn6wJaSTvxYUmW/wRE0rNptUfiL9E53 Obt5EFDRjEj84XH1HEsitSsZU6CwBcMgugCODiLA+B5kfhd07Mo3qDshoXmVw3SN0XZ1kYVwgewqh OIrg7wBbdNB2ZIIS8Cu23VKh9WCtzk2WWNP+jVChwMyZkQNGQ0fhQr43JiBIIK08dl7mPzSOIhUq3 P+HH2b9w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tEw0A-00000004nYK-41Zn; Sat, 23 Nov 2024 19:41:06 +0000 Received: from fgw22-7.mail.saunalahti.fi ([62.142.5.83]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tEvzE-00000004nTe-2nD2 for linux-arm-kernel@lists.infradead.org; Sat, 23 Nov 2024 19:40:09 +0000 Received: from localhost (88-113-25-143.elisa-laajakaista.fi [88.113.25.143]) by fgw23.mail.saunalahti.fi (Halon) with ESMTP id bd3dc34a-a9d2-11ef-a0f6-005056bdfda7; Sat, 23 Nov 2024 21:40:06 +0200 (EET) From: Andy Shevchenko Date: Sat, 23 Nov 2024 21:40:05 +0200 To: Javier Carrasco Cc: Pavel Machek , Lee Jones , Matthias Brugger , AngeloGioacchino Del Regno , Gene Chen , Jacek Anaszewski , Bartosz Golaszewski , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Jonathan Cameron , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH 16/18] leds: tca6507: switch to device_for_each_child_node_scoped() Message-ID: References: <20240927-leds_device_for_each_child_node_scoped-v1-0-95c0614b38c8@gmail.com> <20240927-leds_device_for_each_child_node_scoped-v1-16-95c0614b38c8@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240927-leds_device_for_each_child_node_scoped-v1-16-95c0614b38c8@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241123_114008_860342_1DBFFB00 X-CRM114-Status: GOOD ( 10.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Fri, Sep 27, 2024 at 01:21:07AM +0200, Javier Carrasco kirjoitti: > Switch to device_for_each_child_node_scoped() to simplify the code by > removing the need for calls to fwnode_handle_put() in the error path. > > This also prevents possible memory leaks if new error paths are added > without the required call to fwnode_handle_put(). ... > ret = fwnode_property_read_u32(child, "reg", ®); > - if (ret || reg >= NUM_LEDS) { > - fwnode_handle_put(child); > + if (ret || reg >= NUM_LEDS) > return ERR_PTR(ret ? : -EINVAL); > - } It's now two nested conditionals instead of two independent ones: if (ret) return ERR_PTR(ret); if (reg >= NUM_LEDS) return ERR_PTR(-EINVAL); I believe my wariant is much better to read, understand, and maintain. -- With Best Regards, Andy Shevchenko