From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Kees Bakker <kees@ijzerbout.nl>
Cc: Manikanta Guntupalli <manikanta.guntupalli@amd.com>,
git@amd.com, michal.simek@amd.com, andi.shyti@kernel.org,
linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, radhey.shyam.pandey@amd.com,
srinivas.goud@amd.com, shubhrajyoti.datta@amd.com,
manion05gk@gmail.com
Subject: Re: [PATCH 2/2] i2c: xiic: Add atomic transfer support
Date: Sun, 24 Nov 2024 16:03:19 +0100 [thread overview]
Message-ID: <Z0NANy2xoSE7TDY3@ninjato> (raw)
In-Reply-To: <d50b2caa-4d3a-4c1d-986c-6fb3c0a2f850@ijzerbout.nl>
[-- Attachment #1: Type: text/plain, Size: 452 bytes --]
> > + while (xiic_rx_space(i2c)) {
> Let's remind what xiic_rx_space is
> #define xiic_rx_space(i2c) ((i2c)->rx_msg->len - (i2c)->rx_pos)
>
> > + if (xiic_getreg32(i2c, XIIC_IISR_OFFSET) & XIIC_INTR_RX_FULL_MASK) {
> > + if (!i2c->rx_msg) {
> This check is suspicious. If i2c->rx_msg is NULL then the while
> above already dereferenced a NULL pointer.
> What is going on?
Valid point. I'll remove the patches from the pull request.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-11-24 15:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-11 10:41 [PATCH 0/2] Add atomic transfer support to i2c-xiic Manikanta Guntupalli
2024-10-11 10:41 ` [PATCH 1/2] i2c: xiic: Relocate xiic_i2c_runtime_suspend and xiic_i2c_runtime_resume to facilitate atomic mode Manikanta Guntupalli
2024-10-11 10:41 ` [PATCH 2/2] i2c: xiic: Add atomic transfer support Manikanta Guntupalli
2024-11-22 21:29 ` Kees Bakker
2024-11-24 15:03 ` Wolfram Sang [this message]
2024-11-25 19:22 ` Andi Shyti
2024-11-14 9:54 ` [PATCH 0/2] Add atomic transfer support to i2c-xiic Michal Simek
2024-11-19 23:05 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z0NANy2xoSE7TDY3@ninjato \
--to=wsa+renesas@sang-engineering.com \
--cc=andi.shyti@kernel.org \
--cc=git@amd.com \
--cc=kees@ijzerbout.nl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manikanta.guntupalli@amd.com \
--cc=manion05gk@gmail.com \
--cc=michal.simek@amd.com \
--cc=radhey.shyam.pandey@amd.com \
--cc=shubhrajyoti.datta@amd.com \
--cc=srinivas.goud@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox