Re: [PATCH v4 02/10] dt-bindings: pinctrl: Add RaspberryPi RP1 gpio/pinctrl/pinmux bindings

Andrea della Porta
2024-11-29T17:12:37Z

Hi Krzysztof,

On 08:55 Wed 27 Nov , Krzysztof Kozlowski wrote:
> On Sun, Nov 24, 2024 at 11:51:39AM +0100, Andrea della Porta wrote:
> > + '#interrupt-cells':
> > + description:
> > + Specifies the Bank number [0, 1, 2] and Flags as defined in
> > + include/dt-bindings/interrupt-controller/irq.h.
> > + const: 2
> > +
> > + interrupt-controller: true
> > +
> > +patternProperties:
> > + "-state$":
> > + oneOf:
> > + - $ref: "#/$defs/raspberrypi-rp1-state"
> > + - patternProperties:
> > + "-pins$":
> > + $ref: "#/$defs/raspberrypi-rp1-state"
> > + additionalProperties: false
> > +
> > +$defs:
> > + raspberrypi-rp1-state:
> > + allOf:
> > + - $ref: pincfg-node.yaml#
> > + - $ref: pinmux-node.yaml#
> > +
> > + description:
> > + Pin controller client devices use pin configuration subnodes (children
> > + and grandchildren) for desired pin configuration.
> > + Client device subnodes use below standard properties.
> > +
> > + properties:
> > + pins:
> > + description:
> > + List of gpio pins affected by the properties specified in this
> > + subnode.
> > + items:
> > + pattern: "^gpio([0-9]|[1-5][0-9])$"
>
> You have 54 GPIOs, so up to 53.

Ack.

>
> Use also consistent quotes, either ' or ".

Ack.

>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Many thanks,
Andrea

>
> Best regards,
> Krzysztof
>