From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C89F9D729E7 for ; Fri, 29 Nov 2024 16:29:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:Date:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OwH5v+3GE18kFTNrayT4BgfE0WPSq36ccL8dVwg+Yh0=; b=SEhDUnqZa17ruzg/oFWMGlV6ZV PSyfu7nPC9zM8ecylJNAn4T60QcIkxkJOh3kO04RFLMTzU9U9oozigBnbmuuOXANaeCg5Aid7Cl91 aKto7+nK2OrD1i8tPLmUfV6qw9hcRjEXM7qV+SmZ29dVIELPByjen5F49lVn6FpUE3zlSiJd4aAf2 QQsGWMLU+hDRWc28Y4z9WNAfgmd809/DYDjxrER/qBLiDAqA/FyU9JcGNAZ7QV9WxCm8VfurFkKLY bylkz30mt+2Z8XCh2oYIF/EXJ+Nf6ju3qnn7fI6alT4HxO3D2m5ZaFJ9YhCcwyf/JdZXaXKHfNyf2 fLdILDfg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tH3rO-00000000bGi-2ys8; Fri, 29 Nov 2024 16:28:50 +0000 Received: from mail-ej1-x62f.google.com ([2a00:1450:4864:20::62f]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tH3qO-00000000b67-35rZ for linux-arm-kernel@lists.infradead.org; Fri, 29 Nov 2024 16:27:49 +0000 Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-aa53ebdf3caso392810066b.2 for ; Fri, 29 Nov 2024 08:27:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1732897666; x=1733502466; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=OwH5v+3GE18kFTNrayT4BgfE0WPSq36ccL8dVwg+Yh0=; b=fIuvnxkQU7geZM55vsIt9LPqNU8WlCUhuvoDmSl5zCePKp758dKV4QaAQzWw7wc2L3 gjp00W+S3CISfUwbKCoH/4ueGidY854zZoihPQ8dBPTxrAM1ZhhGlM8eL/jNkMDa2Xt0 i+u5olhlNJPGs54zVkrcXPI5KdWc24FHkUeQrgQr7P6R9CeAI+Q70IFo1VcdIXpymxvE ALp2ojU6sgk9iO8Io5OiEX+CjMWViiBZfjlBNHk62MKeDUrRZnGZwZnJEr7YLA9AMDbq b2gLdxOB1xIv2pn6Oko2/Gx5M9dUCGZiX8qlqMUVklJJQjVJ3GBSTsLG/eDHzw/CmVIN A0QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732897666; x=1733502466; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OwH5v+3GE18kFTNrayT4BgfE0WPSq36ccL8dVwg+Yh0=; b=rWFDYAlB7e45winxpMimxHsc97gaC3FGM5pAULAwrkZACA3ygozKIjOUlpefdgq0Pe IUNINOuWN1BxySSPY0oTQY4ou8k5uh8+ZxE+t8nIZlHa1c25VF5H8CZLsnV1jgeN6XaR QyWb6pr3o8gakYTNWtcR6g1Zz77FZavHLd+eRzfgUyXCvBkXNfndfBl80ncZ3qmTuxv8 u1ulhvO2VrPx9jaqVBXft+ea8zJO6aJ9upPdr8fbcZTS8Fk0SKayCfkuwAJH2f4I+Ma7 9PDs87BuIz2VJAAyhwZiZz5IaerWmHEHEglZxU4ohU3Q4SnQE/kd72/dOTp45iSuce5l Ad6g== X-Forwarded-Encrypted: i=1; AJvYcCW33bP7g10QwS/Y0ac5D1EkkBh3PjxYZ/VlbDS8Sobn//xf0uHD97g3CsYaEBId4UomDN6UpID//JVwyWtbBXOG@lists.infradead.org X-Gm-Message-State: AOJu0Yyzx9q//DYypyx6+mB77WoFP/oZZIMTvSpBBfti+/hpiaCsrqSf uWEMWTD3dByKjX0h6Dhbhz7FqbObrrD3RAyyUOdcLSHkjihSB3H4SmyvDXd4VUA= X-Gm-Gg: ASbGncsmdj9R0Im1kZSwakxmc6RalLv6LUyTN+EAbahiTaTq186ADGSmEM7xyhMGaFR GeRSwynoQT0pEmaqASObdf/WlB1K0q8/ECJAlJnvM7SmcroGoBZdXdf8JljX9DFOgzEbykZaGwW EZ4AH1VZn7d0cAhoQbDgr1SKUbAipMusVDfThvlr0pZ0KjluDmRMhKZRpAK7DUQjxXVhcUg10KN 7BbWlDB9fOtm7SlSfnbtYyi3Bp485mWX9mMXsdM5Zo9emUsD8G0CfhTolOt+GmdqidakS+f2NhM myglF/2IrJUu6ssc0WWJ X-Google-Smtp-Source: AGHT+IFdG9GOu7z7VbF3RaWxqyGcxIpQuKws1pr8ZUhjgAPYuz3ueFSPxNUGdj5E67EBohC3LgYQSw== X-Received: by 2002:a17:906:318d:b0:aa5:1957:3431 with SMTP id a640c23a62f3a-aa580edfbfcmr1150158266b.1.1732897666347; Fri, 29 Nov 2024 08:27:46 -0800 (PST) Received: from localhost (host-79-49-220-127.retail.telecomitalia.it. [79.49.220.127]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aa5996c193asm189510666b.38.2024.11.29.08.27.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Nov 2024 08:27:45 -0800 (PST) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Fri, 29 Nov 2024 17:28:19 +0100 To: Stefan Wahren Cc: Andrea della Porta , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Lorenzo Pieralisi , Krzysztof Wilczynski , Manivannan Sadhasivam , Bjorn Helgaas , Linus Walleij , Catalin Marinas , Will Deacon , Bartosz Golaszewski , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Greg Kroah-Hartman , Saravana Kannan , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-gpio@vger.kernel.org, Masahiro Yamada , Herve Codina , Luca Ceresoli , Thomas Petazzoni , Andrew Lunn Subject: Re: [PATCH v4 08/10] misc: rp1: RaspberryPi RP1 misc driver Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241129_082748_786894_4AAABC34 X-CRM114-Status: GOOD ( 25.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Stephan, On 19:35 Mon 25 Nov , Stefan Wahren wrote: > Hi Andrea, > > Am 24.11.24 um 11:51 schrieb Andrea della Porta: > > The RaspberryPi RP1 is a PCI multi function device containing > > peripherals ranging from Ethernet to USB controller, I2C, SPI > > and others. > > ... > > + Support the RP1 peripheral chip found on Raspberry Pi 5 board. > > + controller, USB controller, I2C, SPI and UART. > > + > > + The driver is responsible for enabling the DT node once the PCIe > > + endpoint has been configured, and handling interrupts. > > + > > + This driver uses an overlay to load other drivers to support for > > + RP1 internal sub-devices. > Please fix up the leading whitespace here Ack. > > diff --git a/drivers/misc/rp1/Makefile b/drivers/misc/rp1/Makefile > > new file mode 100644 > > index 000000000000..508b4cb05627 > > --- /dev/null > > +++ b/drivers/misc/rp1/Makefile > > @@ -0,0 +1,3 @@ > > +# SPDX-License-Identifier: GPL-2.0-only ... > > +#define RP1_INT_SYSCFG 58 > > +#define RP1_INT_CLOCKS_DEFAULT 59 > > +#define RP1_INT_VBUSCTRL 60 > > +#define RP1_INT_PROC_MISC 57 > > +#define RP1_INT_END 61 > > + > > +struct rp1_dev { > > + struct pci_dev *pdev; > > + struct irq_domain *domain; > > + struct irq_data *pcie_irqds[64]; > > + void __iomem *bar1; > > + int ovcs_id; > /* overlay changeset id */ Ack. > > + bool level_triggered_irq[RP1_INT_END]; > > +}; > > + > > +static void msix_cfg_set(struct rp1_dev *rp1, unsigned int hwirq, u32 value) > > +{ ... > > + struct device_node *rp1_node; > > + struct rp1_dev *rp1; > > + int err = 0; > Please remove the extra space after err Ack. > > + int i; > > + > > + rp1_node = dev_of_node(dev); > > + if (!rp1_node) { > > + dev_err(dev, "Missing of_node for device\n"); > > + return -EINVAL; > > + } > > + > > + rp1 = devm_kzalloc(&pdev->dev, sizeof(*rp1), GFP_KERNEL); > > + if (!rp1) > > + return -ENOMEM; > > + > > + rp1->pdev = pdev; ... > > + err = pci_alloc_irq_vectors(pdev, RP1_INT_END, RP1_INT_END, > > + PCI_IRQ_MSIX); > > + if (err < 0) > > + return dev_err_probe(&pdev->dev, err, > > + "pci_alloc_irq_vectors failed"); > > + else if (err != RP1_INT_END) { > Please add braces for the if case Ack. Many thanks, Andrea > > + dev_err(&pdev->dev, "Cannot allocate enough interrupts\n"); > > + return -EINVAL; > > + } > > + > >