From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8D2C5E7716C for ; Thu, 5 Dec 2024 09:00:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WvcR8sYGE6WOsKSE6b5g/eGm8oV2IdcxBRt9XP/8XLo=; b=Y1T3K/W4vHF+OC4vGRo2s4UygS E1eILn2B8wLYlxtSkNXfZHFOQFMssl0YdKZcSS3rJzNOqOh4xqXIhlChaXj+8ljKQHJphtwi7mFiF l3M06Z0P1MB/SZT58/xdZs7X3T8qGVhBvzg4CLhno2U12prs6vOGpwu/fnMIrRT3NWlYQztVQbVNd 339UJhUzY7TtfVkMqVdBAiaLY9++dbPLzPJth5ciNgydrxt+WyjM/ugJpHCe+212+kukK24GwiJsn WExKWxu64SEkoDpb1u5R/6yN1wDPVB0f60DKOieL7SiSFX17NXQB9IkjNLtKfDdJQJcb4WC42dO7j /9IdRURQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tJ7ie-0000000FGOD-05OR; Thu, 05 Dec 2024 09:00:20 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tJ7hc-0000000FGAj-1FZ6 for linux-arm-kernel@lists.infradead.org; Thu, 05 Dec 2024 08:59:17 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tJ7hI-0002Lp-T0; Thu, 05 Dec 2024 09:58:56 +0100 Received: from pty.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::c5]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tJ7hH-001nIO-0S; Thu, 05 Dec 2024 09:58:55 +0100 Received: from mtr by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1tJ7hH-00GP4g-2b; Thu, 05 Dec 2024 09:58:55 +0100 Date: Thu, 5 Dec 2024 09:58:55 +0100 From: Michael Tretter To: Yassine Ouaissa Cc: Mauro Carvalho Chehab , Pengutronix Kernel Team , Michal Simek , Hans Verkuil , Andrzej Pietrasiewicz , Wolfram Sang , Christophe JAILLET , Gaosheng Cui , Uwe Kleine-K??nig , Ricardo Ribalda , open list , "open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB)" , "moderated list:ARM/ZYNQ ARCHITECTURE" Subject: Re: [PATCH] media: allegro-dvt: Moving the current driver to subdirectory Message-ID: Mail-Followup-To: Michael Tretter , Yassine Ouaissa , Mauro Carvalho Chehab , Pengutronix Kernel Team , Michal Simek , Hans Verkuil , Andrzej Pietrasiewicz , Wolfram Sang , Christophe JAILLET , Gaosheng Cui , Uwe Kleine-K??nig , Ricardo Ribalda , open list , "open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB)" , "moderated list:ARM/ZYNQ ARCHITECTURE" References: <20241202102654.40472-1-yassine.ouaissa@allegrodvt.com> <46tabetrggwplddtssags6eyjcd6x7znaquerjg3z5a63ykle4@z5fqzikwv2o4> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <46tabetrggwplddtssags6eyjcd6x7znaquerjg3z5a63ykle4@z5fqzikwv2o4> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: mtr@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241205_005916_485048_9EB1553F X-CRM114-Status: GOOD ( 41.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Yassine, On Thu, 05 Dec 2024 08:11:48 +0000, Yassine Ouaissa wrote: > On 04.12.2024 17:27, Michael Tretter wrote: > > On Wed, 04 Dec 2024 14:44:31 +0000, Yassine Ouaissa wrote: > > > On 02.12.2024 11:55, Michael Tretter wrote: > > > > On Mon, 02 Dec 2024 11:26:38 +0100, Yassine Ouaissa wrote: > > > > What kind of conflicts do you encounter or expect? It's kind of > > > > surprising that your driver would conflict with anything in the existing > > > > driver. > > > > > > The current "NOT allegro" driver support only the ZynqMP (ex : ZCU106/ZCU104 ). > > > And the upcoming driver, has support for many platforms. > > > > What are the supported platforms of the new driver? Does your driver > > support ZynqMP, too? > > > The upcoming driver is not using the ZynqMP, it can be used by other > clients including Xilinx. > > If there are enough similarities between the encoders, I'd happily > > replace parts of the current driver with functionality of the upcoming > > driver or reuse the infrastructure of the new driver. > > > > For now, we do have only the decoder (stateful). the encoder is "in > progress". We prefer to have a separate driver core for each platform. Thanks! I'd like to wait until I've seen your patches before agreeing to move the driver to a subdirectory. Maybe even include this patch as the first patch in your series to give a full picture of the new structure. Michael > > > > > > > I'd like to see how you plan to integrate your driver, what it looks > > > > like and what conflicts with the existing driver actually occur. Without > > > > that information I don't see the point in moving the driver to a > > > > sub-directory. > > > > > > The upcoming driver is not using the parsing, conversion inside of the > > > driver. Actually the new Gen of ALLEGRO IP does that. > > > > Sorry, I don't understand what you mean by parsing and conversion. Do > > you mean the mailbox messages or the NAL units? > > > > Can you point me to some repository with your upcoming driver? I'd > > really like to know what's coming up to have an informed discussion how > > to structure the directory. > > > > Michael > > > > Yassine > > > > > > > > > > Signed-off-by: Yassine Ouaissa > > > > > --- > > > > > MAINTAINERS | 2 +- > > > > > drivers/media/platform/allegro-dvt/Kconfig | 4 ++-- > > > > > drivers/media/platform/allegro-dvt/Makefile | 8 ++------ > > > > > drivers/media/platform/allegro-dvt/zynqmp/Makefile | 6 ++++++ > > > > > .../media/platform/allegro-dvt/{ => zynqmp}/nal-h264.c | 0 > > > > > .../media/platform/allegro-dvt/{ => zynqmp}/nal-h264.h | 0 > > > > > .../media/platform/allegro-dvt/{ => zynqmp}/nal-hevc.c | 0 > > > > > .../media/platform/allegro-dvt/{ => zynqmp}/nal-hevc.h | 0 > > > > > .../media/platform/allegro-dvt/{ => zynqmp}/nal-rbsp.c | 0 > > > > > .../media/platform/allegro-dvt/{ => zynqmp}/nal-rbsp.h | 0 > > > > > .../{allegro-core.c => zynqmp/zynqmp-allegro-core.c} | 2 +- > > > > > .../{allegro-mail.c => zynqmp/zynqmp-allegro-mail.c} | 2 +- > > > > > .../{allegro-mail.h => zynqmp/zynqmp-allegro-mail.h} | 0 > > > > > 13 files changed, 13 insertions(+), 11 deletions(-) > > > > > create mode 100644 drivers/media/platform/allegro-dvt/zynqmp/Makefile > > > > > rename drivers/media/platform/allegro-dvt/{ => zynqmp}/nal-h264.c (100%) > > > > > rename drivers/media/platform/allegro-dvt/{ => zynqmp}/nal-h264.h (100%) > > > > > rename drivers/media/platform/allegro-dvt/{ => zynqmp}/nal-hevc.c (100%) > > > > > rename drivers/media/platform/allegro-dvt/{ => zynqmp}/nal-hevc.h (100%) > > > > > rename drivers/media/platform/allegro-dvt/{ => zynqmp}/nal-rbsp.c (100%) > > > > > rename drivers/media/platform/allegro-dvt/{ => zynqmp}/nal-rbsp.h (100%) > > > > > rename drivers/media/platform/allegro-dvt/{allegro-core.c => zynqmp/zynqmp-allegro-core.c} (99%) > > > > > rename drivers/media/platform/allegro-dvt/{allegro-mail.c => zynqmp/zynqmp-allegro-mail.c} (99%) > > > > > rename drivers/media/platform/allegro-dvt/{allegro-mail.h => zynqmp/zynqmp-allegro-mail.h} (100%) > > > > > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > > > index 7292e4a1ddb8..d79efe6f8992 100644 > > > > > --- a/MAINTAINERS > > > > > +++ b/MAINTAINERS > > > > > @@ -795,7 +795,7 @@ R: Pengutronix Kernel Team > > > > > L: linux-media@vger.kernel.org > > > > > S: Maintained > > > > > F: Documentation/devicetree/bindings/media/allegro,al5e.yaml > > > > > -F: drivers/media/platform/allegro-dvt/ > > > > > +F: drivers/media/platform/allegro-dvt/zynqmp > > > > > > > > > > ALLIED VISION ALVIUM CAMERA DRIVER > > > > > M: Tommaso Merciai > > > > > diff --git a/drivers/media/platform/allegro-dvt/Kconfig b/drivers/media/platform/allegro-dvt/Kconfig > > > > > index 2182e1277568..9bc7e99788b8 100644 > > > > > --- a/drivers/media/platform/allegro-dvt/Kconfig > > > > > +++ b/drivers/media/platform/allegro-dvt/Kconfig > > > > > @@ -2,8 +2,8 @@ > > > > > > > > > > comment "Allegro DVT media platform drivers" > > > > > > > > > > -config VIDEO_ALLEGRO_DVT > > > > > - tristate "Allegro DVT Video IP Core" > > > > > +config VIDEO_ZYNQMP_ALLEGRO_DVT > > > > > + tristate "Allegro DVT Video IP Core for ZynqMP" > > > > > depends on V4L_MEM2MEM_DRIVERS > > > > > depends on VIDEO_DEV > > > > > depends on ARCH_ZYNQMP || COMPILE_TEST > > > > > diff --git a/drivers/media/platform/allegro-dvt/Makefile b/drivers/media/platform/allegro-dvt/Makefile > > > > > index 66108a303774..04727c5f7ef4 100644 > > > > > --- a/drivers/media/platform/allegro-dvt/Makefile > > > > > +++ b/drivers/media/platform/allegro-dvt/Makefile > > > > > @@ -1,6 +1,2 @@ > > > > > -# SPDX-License-Identifier: GPL-2.0 > > > > > - > > > > > -allegro-objs := allegro-core.o allegro-mail.o > > > > > -allegro-objs += nal-rbsp.o nal-h264.o nal-hevc.o > > > > > - > > > > > -obj-$(CONFIG_VIDEO_ALLEGRO_DVT) += allegro.o > > > > > +# SPDX-License-Identifier: GPL-2.0-only > > > > > +obj-y += zynqmp/ > > > > > diff --git a/drivers/media/platform/allegro-dvt/zynqmp/Makefile b/drivers/media/platform/allegro-dvt/zynqmp/Makefile > > > > > new file mode 100644 > > > > > index 000000000000..a8ddb9cf93a8 > > > > > --- /dev/null > > > > > +++ b/drivers/media/platform/allegro-dvt/zynqmp/Makefile > > > > > @@ -0,0 +1,6 @@ > > > > > +# SPDX-License-Identifier: GPL-2.0 > > > > > + > > > > > +zynqmp-allegro-objs := zynqmp-allegro-core.o zynqmp-allegro-mail.o > > > > > +zynqmp-allegro-objs += nal-rbsp.o nal-h264.o nal-hevc.o > > > > > + > > > > > +obj-$(CONFIG_VIDEO_ZYNQMP_ALLEGRO_DVT) += zynqmp-allegro.o > > > > > diff --git a/drivers/media/platform/allegro-dvt/nal-h264.c b/drivers/media/platform/allegro-dvt/zynqmp/nal-h264.c > > > > > similarity index 100% > > > > > rename from drivers/media/platform/allegro-dvt/nal-h264.c > > > > > rename to drivers/media/platform/allegro-dvt/zynqmp/nal-h264.c > > > > > diff --git a/drivers/media/platform/allegro-dvt/nal-h264.h b/drivers/media/platform/allegro-dvt/zynqmp/nal-h264.h > > > > > similarity index 100% > > > > > rename from drivers/media/platform/allegro-dvt/nal-h264.h > > > > > rename to drivers/media/platform/allegro-dvt/zynqmp/nal-h264.h > > > > > diff --git a/drivers/media/platform/allegro-dvt/nal-hevc.c b/drivers/media/platform/allegro-dvt/zynqmp/nal-hevc.c > > > > > similarity index 100% > > > > > rename from drivers/media/platform/allegro-dvt/nal-hevc.c > > > > > rename to drivers/media/platform/allegro-dvt/zynqmp/nal-hevc.c > > > > > diff --git a/drivers/media/platform/allegro-dvt/nal-hevc.h b/drivers/media/platform/allegro-dvt/zynqmp/nal-hevc.h > > > > > similarity index 100% > > > > > rename from drivers/media/platform/allegro-dvt/nal-hevc.h > > > > > rename to drivers/media/platform/allegro-dvt/zynqmp/nal-hevc.h > > > > > diff --git a/drivers/media/platform/allegro-dvt/nal-rbsp.c b/drivers/media/platform/allegro-dvt/zynqmp/nal-rbsp.c > > > > > similarity index 100% > > > > > rename from drivers/media/platform/allegro-dvt/nal-rbsp.c > > > > > rename to drivers/media/platform/allegro-dvt/zynqmp/nal-rbsp.c > > > > > diff --git a/drivers/media/platform/allegro-dvt/nal-rbsp.h b/drivers/media/platform/allegro-dvt/zynqmp/nal-rbsp.h > > > > > similarity index 100% > > > > > rename from drivers/media/platform/allegro-dvt/nal-rbsp.h > > > > > rename to drivers/media/platform/allegro-dvt/zynqmp/nal-rbsp.h > > > > > diff --git a/drivers/media/platform/allegro-dvt/allegro-core.c b/drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-core.c > > > > > similarity index 99% > > > > > rename from drivers/media/platform/allegro-dvt/allegro-core.c > > > > > rename to drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-core.c > > > > > index e491399afcc9..8895d7755987 100644 > > > > > --- a/drivers/media/platform/allegro-dvt/allegro-core.c > > > > > +++ b/drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-core.c > > > > > @@ -31,7 +31,7 @@ > > > > > #include > > > > > #include > > > > > > > > > > -#include "allegro-mail.h" > > > > > +#include "zynqmp-allegro-mail.h" > > > > > #include "nal-h264.h" > > > > > #include "nal-hevc.h" > > > > > > > > > > diff --git a/drivers/media/platform/allegro-dvt/allegro-mail.c b/drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-mail.c > > > > > similarity index 99% > > > > > rename from drivers/media/platform/allegro-dvt/allegro-mail.c > > > > > rename to drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-mail.c > > > > > index aadc947a77ae..88a98f9e5d00 100644 > > > > > --- a/drivers/media/platform/allegro-dvt/allegro-mail.c > > > > > +++ b/drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-mail.c > > > > > @@ -12,7 +12,7 @@ > > > > > #include > > > > > #include > > > > > > > > > > -#include "allegro-mail.h" > > > > > +#include "zynqmp-allegro-mail.h" > > > > > > > > > > const char *msg_type_name(enum mcu_msg_type type) > > > > > { > > > > > diff --git a/drivers/media/platform/allegro-dvt/allegro-mail.h b/drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-mail.h > > > > > similarity index 100% > > > > > rename from drivers/media/platform/allegro-dvt/allegro-mail.h > > > > > rename to drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-mail.h > > > > > -- > > > > > 2.30.2 > > > > > > > > > >