From: Frank Li <Frank.li@nxp.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: "Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Anup Patel" <apatel@ventanamicro.com>,
"Marc Zyngier" <maz@kernel.org>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
imx@lists.linux.dev, "Niklas Cassel" <cassel@kernel.org>,
dlemoal@kernel.org, jdmason@kudzu.us,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v10 3/7] PCI: endpoint: pci-ep-msi: Add MSI address/data pair mutable check
Date: Thu, 5 Dec 2024 09:56:11 -0500 [thread overview]
Message-ID: <Z1G/CwFvO/aBLBe8@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <87ttbiqnq8.ffs@tglx>
On Thu, Dec 05, 2024 at 02:10:55PM +0100, Thomas Gleixner wrote:
> On Wed, Dec 04 2024 at 18:25, Frank Li wrote:
> > Some MSI controller change address/data pair when irq_set_affinity().
> > Current PCI endpoint can't support this type MSI controller. So add flag
> > MSI_FLAG_MUTABLE in include/linux/msi.h and check it when allocate
> > doorbell.
>
> Q: Who is going to annotate the affected domains with that flag?
>
> A: Nobody.
>
> Q: What's the value of the flag?
>
> A: Zero, as as it prevents exactly nothing.
>
> You want a MSI_FLAG_MSG_IMMUTABLE and set that on the domains which
> provide it. That way you ensure that someone looked at the domain to
> validate it.
Okay, at beginning I think most MSI controller is immutable. So I use
MSI_FLAG_MSG_MUTABLE.
It is fine change to MSI_FLAG_MSG_IMMUTABLE.
Frank
>
> Thanks,
>
> tglx
next prev parent reply other threads:[~2024-12-05 14:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-04 23:25 [PATCH v10 0/7] PCI: EP: Add RC-to-EP doorbell with platform MSI controller Frank Li
2024-12-04 23:25 ` [PATCH v10 1/7] irqchip/gic-v3-its: Avoid overwriting msi_prepare callback if provided by msi_domain_info Frank Li
2024-12-04 23:25 ` [PATCH v10 2/7] PCI: endpoint: Add RC-to-EP doorbell support using platform MSI controller Frank Li
2024-12-04 23:25 ` [PATCH v10 3/7] PCI: endpoint: pci-ep-msi: Add MSI address/data pair mutable check Frank Li
2024-12-05 13:10 ` Thomas Gleixner
2024-12-05 14:56 ` Frank Li [this message]
2024-12-05 18:05 ` Thomas Gleixner
2024-12-04 23:25 ` [PATCH v10 4/7] PCI: endpoint: Add pci_epf_align_inbound_addr() helper for address alignment Frank Li
2024-12-04 23:25 ` [PATCH v10 5/7] PCI: endpoint: pci-epf-test: Add doorbell test support Frank Li
2024-12-04 23:25 ` [PATCH v10 6/7] misc: pci_endpoint_test: Add doorbell test case Frank Li
2024-12-04 23:25 ` [PATCH v10 7/7] tools: PCI: Add 'B' option for test doorbell Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1G/CwFvO/aBLBe8@lizhi-Precision-Tower-5810 \
--to=frank.li@nxp.com \
--cc=apatel@ventanamicro.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=imx@lists.linux.dev \
--cc=jdmason@kudzu.us \
--cc=kishon@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=maz@kernel.org \
--cc=rafael@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox