linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] ARM: imx_v6_v7_defconfig: enable SND_SOC_SPDIF
@ 2024-11-08 15:34 Stefan Eichenberger
  2024-12-09  9:33 ` Shawn Guo
  0 siblings, 1 reply; 2+ messages in thread
From: Stefan Eichenberger @ 2024-11-08 15:34 UTC (permalink / raw)
  To: linux, shawnguo, s.hauer, kernel, festevam, wahrenst,
	elinor.montmasson
  Cc: linux-arm-kernel, imx, linux-kernel, Stefan Eichenberger

From: Stefan Eichenberger <stefan.eichenberger@toradex.com>

Enable SND_SOC_SPDIF in imx_v6_v7_defconfig to support SPDIF audio.

With commit d469b771afe1 ("ARM: dts: imx6: update spdif sound card node
properties"), the more generic audio-codec property is used instead of
the old spdif-controller property. Since most i.MX6 boards now use the
audio-codec property together with the linux,spdif-dit and
linux,spdif-dir compatible driver, it makes sense to enable
SND_SOC_SPDIF in the imx_v6_v7_defconfig. This will ensure compatibility
with the updated device tree.

Without this change, boards that use the audio-codec property will show
the following error message during boot when using the
imx_v6_v7_defconfig and spdif audio is not working:
[   24.165534] platform sound-spdif: deferred probe pending: fsl-asoc-card: snd_soc_register_card failed

Signed-off-by: Stefan Eichenberger <stefan.eichenberger@toradex.com>
---
Changes in v2:
- Improve the commit message. (Stefan)
- Removed the fixed tag because it is not fix. It just improves the
  example configuration. (Stefan)

 arch/arm/configs/imx_v6_v7_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
index 333ef55476a3..c771d7dbcadc 100644
--- a/arch/arm/configs/imx_v6_v7_defconfig
+++ b/arch/arm/configs/imx_v6_v7_defconfig
@@ -321,6 +321,7 @@ CONFIG_SND_SOC_IMX_SGTL5000=y
 CONFIG_SND_SOC_FSL_ASOC_CARD=y
 CONFIG_SND_SOC_AC97_CODEC=y
 CONFIG_SND_SOC_CS42XX8_I2C=y
+CONFIG_SND_SOC_SPDIF=y
 CONFIG_SND_SOC_TLV320AIC3X_I2C=y
 CONFIG_SND_SOC_WM8960=y
 CONFIG_SND_SOC_WM8962=y
-- 
2.43.0



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] ARM: imx_v6_v7_defconfig: enable SND_SOC_SPDIF
  2024-11-08 15:34 [PATCH v2] ARM: imx_v6_v7_defconfig: enable SND_SOC_SPDIF Stefan Eichenberger
@ 2024-12-09  9:33 ` Shawn Guo
  0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2024-12-09  9:33 UTC (permalink / raw)
  To: Stefan Eichenberger
  Cc: linux, shawnguo, s.hauer, kernel, festevam, wahrenst,
	elinor.montmasson, linux-arm-kernel, imx, linux-kernel,
	Stefan Eichenberger

On Fri, Nov 08, 2024 at 04:34:34PM +0100, Stefan Eichenberger wrote:
> From: Stefan Eichenberger <stefan.eichenberger@toradex.com>
> 
> Enable SND_SOC_SPDIF in imx_v6_v7_defconfig to support SPDIF audio.
> 
> With commit d469b771afe1 ("ARM: dts: imx6: update spdif sound card node
> properties"), the more generic audio-codec property is used instead of
> the old spdif-controller property. Since most i.MX6 boards now use the
> audio-codec property together with the linux,spdif-dit and
> linux,spdif-dir compatible driver, it makes sense to enable
> SND_SOC_SPDIF in the imx_v6_v7_defconfig. This will ensure compatibility
> with the updated device tree.
> 
> Without this change, boards that use the audio-codec property will show
> the following error message during boot when using the
> imx_v6_v7_defconfig and spdif audio is not working:
> [   24.165534] platform sound-spdif: deferred probe pending: fsl-asoc-card: snd_soc_register_card failed
> 
> Signed-off-by: Stefan Eichenberger <stefan.eichenberger@toradex.com>

Applied, thanks!



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-12-09  9:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-08 15:34 [PATCH v2] ARM: imx_v6_v7_defconfig: enable SND_SOC_SPDIF Stefan Eichenberger
2024-12-09  9:33 ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).