* [PATCH 1/1] arm64: dts: imx8mq-zii-ultra: remove #address-cells of eeprom@a4
@ 2024-10-18 18:31 Frank Li
2024-11-01 8:47 ` Shawn Guo
2024-12-09 7:33 ` Shawn Guo
0 siblings, 2 replies; 4+ messages in thread
From: Frank Li @ 2024-10-18 18:31 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list
Remove #address-cells and #size-cells of eeprom@a4 because no children
nodes under eeprom@a4.
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
index 0c960efd9b3d5..c7bbba45f3685 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
@@ -517,8 +517,6 @@ eeprom@a3 {
eeprom@a4 {
compatible = "zii,rave-sp-eeprom";
reg = <0xa4 0x4000>;
- #address-cells = <1>;
- #size-cells = <1>;
zii,eeprom-name = "main-eeprom";
};
};
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] arm64: dts: imx8mq-zii-ultra: remove #address-cells of eeprom@a4
2024-10-18 18:31 [PATCH 1/1] arm64: dts: imx8mq-zii-ultra: remove #address-cells of eeprom@a4 Frank Li
@ 2024-11-01 8:47 ` Shawn Guo
2024-11-04 20:36 ` Frank Li
2024-12-09 7:33 ` Shawn Guo
1 sibling, 1 reply; 4+ messages in thread
From: Shawn Guo @ 2024-11-01 8:47 UTC (permalink / raw)
To: Frank Li
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list
On Fri, Oct 18, 2024 at 02:31:16PM -0400, Frank Li wrote:
> Remove #address-cells and #size-cells of eeprom@a4 because no children
> nodes under eeprom@a4.
Hmm, bindings/nvmem/zii,rave-sp-eeprom.txt suggests there could be child
nodes?
Shawn
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> index 0c960efd9b3d5..c7bbba45f3685 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> @@ -517,8 +517,6 @@ eeprom@a3 {
> eeprom@a4 {
> compatible = "zii,rave-sp-eeprom";
> reg = <0xa4 0x4000>;
> - #address-cells = <1>;
> - #size-cells = <1>;
> zii,eeprom-name = "main-eeprom";
> };
> };
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] arm64: dts: imx8mq-zii-ultra: remove #address-cells of eeprom@a4
2024-11-01 8:47 ` Shawn Guo
@ 2024-11-04 20:36 ` Frank Li
0 siblings, 0 replies; 4+ messages in thread
From: Frank Li @ 2024-11-04 20:36 UTC (permalink / raw)
To: Shawn Guo
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list
On Fri, Nov 01, 2024 at 04:47:17PM +0800, Shawn Guo wrote:
> On Fri, Oct 18, 2024 at 02:31:16PM -0400, Frank Li wrote:
> > Remove #address-cells and #size-cells of eeprom@a4 because no children
> > nodes under eeprom@a4.
>
> Hmm, bindings/nvmem/zii,rave-sp-eeprom.txt suggests there could be child
> nodes?
"Data cells are child nodes of eerpom node, bindings for which are
documented in Documentation/devicetree/bindings/nvmem/nvmem.txt"
It should be optional property to declear offset, such as mac_address, or
watchdog_timeout value.
Here is no children nodes under eeprom@a4, so needn't #address-cells. It
should be added only when add children nodes.
Frank
>
> Shawn
>
> >
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> > index 0c960efd9b3d5..c7bbba45f3685 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> > @@ -517,8 +517,6 @@ eeprom@a3 {
> > eeprom@a4 {
> > compatible = "zii,rave-sp-eeprom";
> > reg = <0xa4 0x4000>;
> > - #address-cells = <1>;
> > - #size-cells = <1>;
> > zii,eeprom-name = "main-eeprom";
> > };
> > };
> > --
> > 2.34.1
> >
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] arm64: dts: imx8mq-zii-ultra: remove #address-cells of eeprom@a4
2024-10-18 18:31 [PATCH 1/1] arm64: dts: imx8mq-zii-ultra: remove #address-cells of eeprom@a4 Frank Li
2024-11-01 8:47 ` Shawn Guo
@ 2024-12-09 7:33 ` Shawn Guo
1 sibling, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2024-12-09 7:33 UTC (permalink / raw)
To: Frank Li
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list
On Fri, Oct 18, 2024 at 02:31:16PM -0400, Frank Li wrote:
> Remove #address-cells and #size-cells of eeprom@a4 because no children
> nodes under eeprom@a4.
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-12-09 8:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-18 18:31 [PATCH 1/1] arm64: dts: imx8mq-zii-ultra: remove #address-cells of eeprom@a4 Frank Li
2024-11-01 8:47 ` Shawn Guo
2024-11-04 20:36 ` Frank Li
2024-12-09 7:33 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).