From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E88BAE77180 for ; Thu, 12 Dec 2024 21:25:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:CC:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/g5c1CLfA4A05EW/opTPiWtw5JtK1rKH7INPILmt3d8=; b=2DAri5PbmSZCJXUndPn0y32eIH EcaZ+eaCK8gJoGC0YbRlQzBC0dsegwVchlBqS/KMvfFmCX5Vida6zH3WPenDTlka1O6Lu3vN4Bo5r 7e7zJS20LcexTh5juI0baoWHibEVnovc7RyW+pQh9tdYvO+3kEevxjK2pxnn+/UeV8T4KTe8ZEiYj YobqRPxKJj6I3RiN3yV6kWC5SuzeT0qAGGFDVJ3eJun9mQFA9v5s6QhecfBoJ+OvWdCkTzz7xLGw3 Xk9mNuq+rw3tTHnA0PqTUDCUVofDxhYuznx2rCv0jLtqOBp1a8CMcU8vOCYmTwsW1ovhBi6TOe3Px r0MXQ4Cw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tLqgC-00000001x0W-3OkO; Thu, 12 Dec 2024 21:25:04 +0000 Received: from mail-bn8nam04on20621.outbound.protection.outlook.com ([2a01:111:f403:2408::621] helo=NAM04-BN8-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tLqf8-00000001wqg-0erK for linux-arm-kernel@lists.infradead.org; Thu, 12 Dec 2024 21:23:59 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=r06p6pqtz+rb9ICzp4xxr22ZWGPfIA9bVtKHc4jOxuMbrjSjbBv4Dszn96KmN4TIyTrSZs88qMGDwPisGjuFqWv9Plv6ZYWGg0xpVU92+BVg+m104NgtURunv9MMRxWscK2qkfLYtP2LUeM8wNYY6KZwFQ1OxPd8Ezg43OXpacj525SFOrGiz8UFL9RDIYsFbLIlQetztwOC2BBlMEj6Gx/K7uejU74m7WS5ZPSh/DI0jIdcAXPrjcBmkNNtOxINV3H+r26M+UJwxHjq514wMeXwFYuEx2aaDCdYx0OY25v+J0goCAp5az0A0TscY9+9xj+8MM+eQ9qmSE3IABlEBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/g5c1CLfA4A05EW/opTPiWtw5JtK1rKH7INPILmt3d8=; b=c9KhCLmLmK2wqSpBzsw+ozBCDW8ZJdLfCNG9qqB1SBC5HI/1YkmSO3uC5C3hOrA+U+SI54RUWhOJfHn95KYClva3pwY6uBhR1i3waG0qn3XyvFawfbbplbPNKbdgrVeLUW4nb5V+SQznDXtrSsDkAA9JQAogcLu4wzZd3pW9WDyF8oYZiCsAtr7oo+JRUOWCURThaEYtfP9OQA1jo6o1tbFlHm1UjwZ8U/vgvMSJuSR4uZ6zZnGV4tbFVjHoOTHHXZVrEtKM1s+yeJTWUn7h9aKcjz5fjZOR0n9dka8zwO4TUf3MgopwOluSmsN9nBMkCPpu2owlruDlIoFcvK+jDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/g5c1CLfA4A05EW/opTPiWtw5JtK1rKH7INPILmt3d8=; b=o2e+Vtt3QbPMfA0wb6UD3Dplf50Op6cESA6OTk8cILMuelbo6V6kbuaIyP+EIY2oqz+CRnbJ/opnmVTLCW6mvOcWCKpqBg7x1C93NhSERHD9DP4S8LrkstChUImI/j90A87O4yAybd7CdFmRvX2wiewmzWTwZyAa5iEb9pjV68NRmm2FnEPpxdzAD+DlQHXZ9opVuKBaCAikU6B9m8sCsITYjSKwLnt8o5hdD7Ur/kVaSaSG25QbIq1TNvZ54yI0b4xdQPpRDLID+NOGSsy3t311I0FdyXRUeNyhYWI3prnFgFz9tiT8rBp9IH5bG3H5tg7hvKJhQ56S5sqUpeAjfg== Received: from BL1PR13CA0021.namprd13.prod.outlook.com (2603:10b6:208:256::26) by DS0PR12MB8217.namprd12.prod.outlook.com (2603:10b6:8:f1::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8251.16; Thu, 12 Dec 2024 21:23:46 +0000 Received: from BL6PEPF0001AB77.namprd02.prod.outlook.com (2603:10b6:208:256:cafe::9f) by BL1PR13CA0021.outlook.office365.com (2603:10b6:208:256::26) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8272.5 via Frontend Transport; Thu, 12 Dec 2024 21:23:46 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.232) by BL6PEPF0001AB77.mail.protection.outlook.com (10.167.242.170) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8251.15 via Frontend Transport; Thu, 12 Dec 2024 21:23:45 +0000 Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Thu, 12 Dec 2024 13:23:34 -0800 Received: from drhqmail202.nvidia.com (10.126.190.181) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Thu, 12 Dec 2024 13:23:33 -0800 Received: from Asurada-Nvidia (10.127.8.11) by mail.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4 via Frontend Transport; Thu, 12 Dec 2024 13:23:32 -0800 Date: Thu, 12 Dec 2024 13:23:31 -0800 From: Nicolin Chen To: "Tian, Kevin" CC: "jgg@nvidia.com" , "will@kernel.org" , "corbet@lwn.net" , "joro@8bytes.org" , "suravee.suthikulpanit@amd.com" , "robin.murphy@arm.com" , "dwmw2@infradead.org" , "baolu.lu@linux.intel.com" , "shuah@kernel.org" , "linux-kernel@vger.kernel.org" , "iommu@lists.linux.dev" , "linux-arm-kernel@lists.infradead.org" , "linux-kselftest@vger.kernel.org" , "linux-doc@vger.kernel.org" , "eric.auger@redhat.com" , "jean-philippe@linaro.org" , "mdf@kernel.org" , "mshavit@google.com" , "shameerali.kolothum.thodi@huawei.com" , "smostafa@google.com" , "ddutile@redhat.com" , "Liu, Yi L" Subject: Re: [PATCH v2 07/13] iommufd/viommu: Add iommufd_viommu_report_irq helper Message-ID: References: <7e9842376e6235d9e3471356d035afe2bfe8f33b.1733263737.git.nicolinc@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-NV-OnPremToCloud: AnonymousSubmission X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0001AB77:EE_|DS0PR12MB8217:EE_ X-MS-Office365-Filtering-Correlation-Id: 9f34c54e-4308-451b-9ee5-08dd1af3430c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|36860700013|376014|7416014|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?kL6+nQcILic6TCw9r8Asd1hpqElCAgz+u4+ZoR3rHkzNeOGNAR9xLIoX/ltT?= =?us-ascii?Q?Q8z59nM7wOAkAmGYUOLgSmASwlYBBR7BEmHiGui1d5i9LnGzdC2MFMdajkBV?= =?us-ascii?Q?kfoo0NDSKMop84EIdD61eqVZpfndnMFymbG7d/Q6gu2SxatwkjEDMGpxxohs?= =?us-ascii?Q?vdU696fdFF2CKR9OzZql0ABhWE5gZknD2PwgJKVB/SGfQCGTQne1j3GPh1nU?= =?us-ascii?Q?NE9KUtxM0gyW2kqy3P4K+tYPuRYN8zPjhFqe7q3QtASZ4KY/fEFVmHnwgQmA?= =?us-ascii?Q?BGOcyk/J4zLQnKhNJRCZvmICoK83edH3Oa+dkG7X4oFMheROVgw+dTX4tGVI?= =?us-ascii?Q?/5U3HEkdFwUqlbFqJazSIovgSTb+MciofBdq5VrcQKNenpBGRwz+ZPJZ/8zn?= =?us-ascii?Q?9O2i7g4PmPahqt7tUBEQWc8Cx+Dh0nUk+gEiD7BIBOkY9nmIJoi9ywaX7WKW?= =?us-ascii?Q?U0GfF7kXfkeNWXneIfr0hmuToH5zmT+tvyjprz98u1UbwHH/9UuO/ffTcGsM?= =?us-ascii?Q?L9MJCyVtU9ifAbYleqiaFdTPnNdBjxUYuoidpbZ5NCBdV76TnoSjli98M7JG?= =?us-ascii?Q?2FQIrPo7K12KSw973tZtYcWX7XTWGT++MTbFn4m1OTuTCjszkqW3MzBPzu2W?= =?us-ascii?Q?Ac0FvPblZgviKoteM/NJwNT2Li8a7Lwv4X+SpAZGpQ/9YQoc7Nn1IZHpnZxF?= =?us-ascii?Q?nBsXioV3PAwJFXSFgMmB0SdREAY9le6u6lEH+baZ6YDvu94AwbpwUn6S3WEx?= =?us-ascii?Q?aII2ztYQPuGSYYmdyA01o4r9NQCqECU4SdNggwdOAnQqDXZHSjDyUfuySpxA?= =?us-ascii?Q?CfAI2rb/Je+XyTk+8nFe0p3M0jLmQl9HHHXDoC3/DkU1NJy3yes6DjmmEGra?= =?us-ascii?Q?9Qa05ResXlfY8XvH+1XXpsuAa23qdeVypt70qVZnAf0xfhCTDsbL+1QWqEmz?= =?us-ascii?Q?6JW8R3TPpX2kR7j0Awg9TPWIeQ/q0w13f7baHA8xkTOehufuiipbHQqdQnM/?= =?us-ascii?Q?6Bd8+lrHQAl0EMC8crZjHol6HHyXCA9oTFDbkuFpoz3nr39eJRhDW1kDAhUh?= =?us-ascii?Q?HNWcgZRIRe7WbCIe1386NqkqfLwbrMf8Mb3FusRKTgTd7WLVMy9Y1BSMNx65?= =?us-ascii?Q?d8L2WNM/zYE6fOAJyvSOabyvjmkAiMNf7ydtb3fqQpJQPJJ0RmJX83hIbw9o?= =?us-ascii?Q?ewbf6IiW8UF8hFyayxzenlMH+6BM9ogycpv1Z391LqR3DT0vdOzWfNiyh6Ku?= =?us-ascii?Q?c6n+9r3eMiAS5gMRHbE//b9+9w7nlhMMxdghx5uQLdHwayHsvFURIdZ9nPDg?= =?us-ascii?Q?1EQwz/8OTBoHp+xXYBdKn4istMyBTX7zkogEAe8KSXnYa8YvzA9zoYnpzi68?= =?us-ascii?Q?4rtsUqivfWbugdg12efzY7OhLf9e4rlyhYxiJcsiODMqmhnLf3kF1Q4Exn67?= =?us-ascii?Q?92dMtjjJ/Y03C855BDepJaTYTfZ0NJS3?= X-Forefront-Antispam-Report: CIP:216.228.118.232;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge1.nvidia.com;CAT:NONE;SFS:(13230040)(1800799024)(36860700013)(376014)(7416014)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Dec 2024 21:23:45.8879 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9f34c54e-4308-451b-9ee5-08dd1af3430c X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.232];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0001AB77.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8217 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241212_132358_190148_3409CC61 X-CRM114-Status: GOOD ( 13.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Dec 11, 2024 at 08:05:45AM +0000, Tian, Kevin wrote: > > From: Nicolin Chen > > Sent: Wednesday, December 4, 2024 6:10 AM > > > > +/* Typically called in driver's threaded IRQ handler */ > > +int iommufd_viommu_report_irq(struct iommufd_viommu *viommu, > > unsigned int type, > > + void *irq_ptr, size_t irq_len) > > +{ > > + struct iommufd_eventq_virq *eventq_virq; > > + struct iommufd_virq *virq; > > + int rc = 0; > > + > > + might_sleep(); > > why is it required here but not in the iopf path? It might not be that *required* as there is a might_sleep inside the down_read(). So, I can drop this. > > + > > + if (!viommu) > > + return -ENODEV; > > + if (WARN_ON_ONCE(!irq_len || !irq_ptr)) > > + return -EINVAL; > > + > > + down_read(&viommu->virqs_rwsem); > > + > > + eventq_virq = iommufd_viommu_find_eventq_virq(viommu, type); > > + if (!eventq_virq) { > > + rc = -EOPNOTSUPP; > > + goto out_unlock_vdev_ids; > > s/out_unlock_vdev_ids/out_unlock_virqs/ Yes.. Thanks! Nic