From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44C6BE7717F for ; Thu, 12 Dec 2024 21:33:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:CC:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CThhBif+vhRz92wc+pKxEEiw0oCAM4vT63BYscwCdK8=; b=dwLYhO8/7i7FZ6io0arFhpf0MI x3cEawIrmiS0V6utx2J5VPvXcM1qti+zlWVYFpeCk/yISCFOYUVN8unwbAg+DmFo2e0YM80sha6Vh 0BYVR30lJumAhaBOcDq3fV9Q8A+AaxdYP3i8u48nyLODiM6W9WG9xQtz4Z92XdfQCxuG0OziY0NNk SHt4VM5pE1LKMGTfuYh/AcsZkVEz7jJ3MFtXwR2JvdD/q2jKGWPZXuHubNttks8wUSkmgukmCfyty WW0mtejATfgiWPxW56oVSgnCN2e+YObVFx3xWlnceFj9Lg/WoWZ1LApXyLcUQqjmuQ+yA01EuL1OQ Qj0SHxew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tLqnk-00000001y6v-26yW; Thu, 12 Dec 2024 21:32:52 +0000 Received: from mail-mw2nam12on2060c.outbound.protection.outlook.com ([2a01:111:f403:200a::60c] helo=NAM12-MW2-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tLqme-00000001xqz-2N98 for linux-arm-kernel@lists.infradead.org; Thu, 12 Dec 2024 21:31:46 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=pGBwozStpmmTocW31+0u793ICh0kWcjUh6CRIx5QcTitPZm6etxwafWDAN72hR52JBrJR4Hwl4VlvxkV5WHJvUZcAfVxOnqnzLfluf//VTv44/Ogyoy3Ez9FaWqQBDx3/MaOY2tbJvOJmleLJmnS4f1rP6Jw6C7kIMw1Bh31KGQWS/3QSjfw1lYi6DPgILsagSPkUtmyIpV3wEyOk/+txF7uZsS47Ux46iH7XVSEa/PZUXNo369/QdsUfa+735iOFYbwmpBSC7jNVPL/WQXYpih/Akw1kjNsE5EZfQ3y4l/Z15dp1FzY/Nk+vhudoqaVI/+WtAFKBvmk77lQLhccxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CThhBif+vhRz92wc+pKxEEiw0oCAM4vT63BYscwCdK8=; b=vNYxA1XeU+8o4AHWzymaWVi8+UxfwqKDhXl2d5ol7ZdCDYDtzAd8E+Z2UODzeINfT6i1tnC/O/O8AfM0bnvU0nURpPA9qxc4BKPEmGURm5ERvr5Inv5MrdSvjneeaR/A5i0zmFBCPyQxYEq2RQDCOcI+SNtwO6RBqa7zkIgK2Ps91Bc9I7jmS750XpGGWalOayJ/oTdHiGOOyS8yiwGRDCbEgZWI5qugiB1aTssXDTce0JOjfbDzDv9dLAUY19x29E53RiEWf1G9xddMMUjTOsIBa703g0UqgUqAdoRCO6W60TJYhReWxHvri+6IRfDWXiivvRlACBxh+d5LcVsAqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CThhBif+vhRz92wc+pKxEEiw0oCAM4vT63BYscwCdK8=; b=izWb+jLIib1ccBNeZ4u6DAjnmyx4tsjGMxKuVniZK2ScHw0Au8+uXMXt/ftbWkvxPtv9rV0kMa/j8dsMdcb3h3uU6375L5EmHZmtDTyueH6wjQWZvJ36eJssxLPw+kkb1RLYwrSaWwtJ2+xQHgUMpqMyDoyDpAS4R04dYUO9kCBaiUKSfRLnLKYgdgsjhFBUCd26B9Ui9XzxZS+2F8zwnp5vYwO6fodA8O68VIj7MKIiTqTxQX1+u2Cg1H4n6cGdZpE5ealqmdvUhA7G33pTp7gozIYPW+nSiw4ZT6UNJ53YZluWoP8mO8OTf1rbjuPjjdji4Ru2eiXzZwjGvZ/LSw== Received: from DM6PR03CA0018.namprd03.prod.outlook.com (2603:10b6:5:40::31) by SA3PR12MB7806.namprd12.prod.outlook.com (2603:10b6:806:31d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8251.16; Thu, 12 Dec 2024 21:31:36 +0000 Received: from DS2PEPF00003444.namprd04.prod.outlook.com (2603:10b6:5:40:cafe::b5) by DM6PR03CA0018.outlook.office365.com (2603:10b6:5:40::31) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8158.18 via Frontend Transport; Thu, 12 Dec 2024 21:31:36 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by DS2PEPF00003444.mail.protection.outlook.com (10.167.17.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8251.15 via Frontend Transport; Thu, 12 Dec 2024 21:31:35 +0000 Received: from rnnvmail205.nvidia.com (10.129.68.10) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Thu, 12 Dec 2024 13:31:18 -0800 Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail205.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Thu, 12 Dec 2024 13:31:17 -0800 Received: from Asurada-Nvidia (10.127.8.11) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4 via Frontend Transport; Thu, 12 Dec 2024 13:31:15 -0800 Date: Thu, 12 Dec 2024 13:31:14 -0800 From: Nicolin Chen To: "Tian, Kevin" CC: "jgg@nvidia.com" , "will@kernel.org" , "corbet@lwn.net" , "joro@8bytes.org" , "suravee.suthikulpanit@amd.com" , "robin.murphy@arm.com" , "dwmw2@infradead.org" , "baolu.lu@linux.intel.com" , "shuah@kernel.org" , "linux-kernel@vger.kernel.org" , "iommu@lists.linux.dev" , "linux-arm-kernel@lists.infradead.org" , "linux-kselftest@vger.kernel.org" , "linux-doc@vger.kernel.org" , "eric.auger@redhat.com" , "jean-philippe@linaro.org" , "mdf@kernel.org" , "mshavit@google.com" , "shameerali.kolothum.thodi@huawei.com" , "smostafa@google.com" , "ddutile@redhat.com" , "Liu, Yi L" Subject: Re: [PATCH v2 12/13] iommu/arm-smmu-v3: Introduce struct arm_smmu_vmaster Message-ID: References: <6270c905fc8537ffc51f6f2ab2db0601c9f08a8d.1733263737.git.nicolinc@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-NV-OnPremToCloud: AnonymousSubmission X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS2PEPF00003444:EE_|SA3PR12MB7806:EE_ X-MS-Office365-Filtering-Correlation-Id: 144af03c-41d0-47c7-2147-08dd1af45b38 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|36860700013|376014|7416014|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?rUndh2F9YMH6bIFQv1UA4jJf5gPMPsdbqKoh9/fzgA9XjhNaGVaAlVNZx3cG?= =?us-ascii?Q?BbEnNqvShjtiRcWdzfcwruLbOd+h/Q6VOS0xLkLuO36FgZKg4yYdl+c4uw8d?= =?us-ascii?Q?iTPSzU/YonpgIwN2kYyH6IVZYL0qbO3j0t0LAA/KjUXF2WQ4GqWhai9gATOE?= =?us-ascii?Q?96PhIvLy1gK/SoZnSkFR1zYM27bq7OGA/NL15lx6Eyl0xV2MkzJsjzILxDtl?= =?us-ascii?Q?TpefCi7QybGHfv7FlYI9gk6QnjXZrb2NfAj7VNA1d+rT+vs90Eb6sxbe3VwN?= =?us-ascii?Q?4Il9IAGlF4Zffye9KVstZ39QVQd/Wj2xcP+rsc/uL6N8Js2bX49ZYlIuIR/R?= =?us-ascii?Q?kzMGNwzKDx2cf/Al9BBg+VQEPNIU3X+Z7lV0beFDuCVuko9r5jNcb2EXN8x9?= =?us-ascii?Q?UZB4EbAfO+I3Tq3rRchs/ug6MZQWBpryTvYnjJq6JWQgfu8Z4ntz1uXlW0xP?= =?us-ascii?Q?ZY4rHDcitQPyfSCrF5IArknsDe84FsomSApUEYHrNlDF6GavX7sB2G4LJ2n3?= =?us-ascii?Q?moVrxS0Ubl48QLRkf2G2QSNq29X85Dt1oiWyXKOEBlhQ83Bzh2mo969I4gY2?= =?us-ascii?Q?HF/s9dbssv/gXANPkJ0mEkcPkUUyBge5fnjwykO0QeIaWMyaKj+4Lel7L+OG?= =?us-ascii?Q?Qf45+sOy6pJ2dECBmSYl/5Y4oJ/6d5W1uoBkTtoriWf1Xgih1cVopWdIgd2g?= =?us-ascii?Q?UCk09J31gAfhY95dH7uBrx1IyoipuaIia9HPw+R33wKX5omioP6cnE0IVgLP?= =?us-ascii?Q?O0Gms6fQtG5lFSBu4ufZuZ6nEH1JRfvjQgLk/wu72i1yRelXuO2w8Xb04D90?= =?us-ascii?Q?iB/87JsKMtEGGWeCceNZ4ZepsmyY+O0aiFTMbHgUdAuRnfVQ9WN6OvGK4lHb?= =?us-ascii?Q?Zehs10tv635eNAc1fjJx6CiX2WCSmZYWBEVPMfpD4PrbXD7HUSDLST05+vNM?= =?us-ascii?Q?k901RfpABtTqN1eXAyPPEN8ma9CSOmBgqSTceyd4zuk3LO+JaKB73yylW7FK?= =?us-ascii?Q?ptQ/m+Sg/CnkcQ64eqYfFzeMc+zcN8mv7DBQP28vHhyPEKE4n6anZeI4rHzX?= =?us-ascii?Q?HZBIr92KoObOyVxij/lHJZzYub2i+ptTDo6FyEu75dP/adwXW+i/z2l/eLhu?= =?us-ascii?Q?+pT63ccnga1eL0PROeYvU0DR/XXc3xNTIXQTYp5p0di092Dl3hlBreb0JYSI?= =?us-ascii?Q?Lv/seC5c6pRQJPIczyKPFlDdU0+4eQKmXcx8M7t/z9FGjmexT5Ba0Lnlaxmx?= =?us-ascii?Q?DTo7sOw/NNd2zJTaBT2Q30YJsA5SUDhz40W1+CqdQJwL9V9U9SGZIwf282dU?= =?us-ascii?Q?r/Qp4nXr/pOyN3MKi7AOtmJvirc8Cj+31DzgDTAbaKPE03QA9udNSttsebJf?= =?us-ascii?Q?QZ9YxiPQ8aduNAySp/Jq1z0Me91vn6JEQqoUSJsfYQR0USV9vMNScjzlyCmG?= =?us-ascii?Q?kQjwF3+d6vz9RhFYVqIZFGkMbW5hCeOD?= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(1800799024)(36860700013)(376014)(7416014)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Dec 2024 21:31:35.9819 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 144af03c-41d0-47c7-2147-08dd1af45b38 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS2PEPF00003444.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB7806 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241212_133144_605338_92ED5735 X-CRM114-Status: GOOD ( 15.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Dec 11, 2024 at 08:15:35AM +0000, Tian, Kevin wrote: > > From: Nicolin Chen > > Sent: Wednesday, December 4, 2024 6:10 AM > > > > Use it to store all vSMMU-related data. The vsid (Virtual Stream ID) will > > be the first use case. Then, add a rw_semaphore to protect it. > > > > Also add a pair of arm_smmu_attach_prepare/commit_vmaster helpers and > > put > > them in the existing arm_smmu_attach_prepare/commit(). Note that identity > > and blocked ops don't call arm_smmu_attach_prepare/commit(), thus > > simply > > call the new helpers at the top. > > Probably a dumb question. viommu is tied to a nested parent domain > which cannot be identity or blocked. Why do we need to change them > too? For identity/blocked domains, prepare() would return 0 without allocating a vmaster pointer, so later on commit() would update master->vmaster with a NULL, i.e. it's a cleanup routine when switching from a paging/dma domain to an identity/blocked one. I will update the commit message to make this clear. Thanks Nic