linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: Sasha Levin <sashal@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Will Deacon <will@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] arm64 fixes for 6.13-rc3
Date: Mon, 16 Dec 2024 17:36:22 +0000	[thread overview]
Message-ID: <Z2BlFtmP4QP3XyLe@J2N7QTR9R3.cambridge.arm.com> (raw)
In-Reply-To: <Z2BAQEuXJg01qWDp@lappy>

On Mon, Dec 16, 2024 at 09:59:12AM -0500, Sasha Levin wrote:
> On Mon, Dec 16, 2024 at 10:02:34AM +0000, Mark Rutland wrote:
> > On Sun, Dec 15, 2024 at 12:06:19PM -0500, Sasha Levin wrote:
> > > On Fri, Dec 13, 2024 at 05:41:38PM +0000, Catalin Marinas wrote:
> > > > - arm64 stacktrace: address some fallout from the recent changes to
> > > >  unwinding across exception boundaries
> > > 
> > > Hi Catalin, Mark,
> > > 
> > > It seems that kselftests can hit a warning that was addressed in the
> > > commit above:
> > 
> > I assume you're referring to commit:
> > 
> >  32ed1205682ec42a ("arm64: stacktrace: Skip reporting LR at exception boundaries")
> > 
> > ... ?
> 
> I was actually thinking 65ac33bed8b9 ("arm64: stacktrace: Don't WARN
> when unwinding other tasks"), sorry for the confusion

That commit should have no impact the case you report, which is seen
when unwinding the current task, not another task.

The commit immediately before that (32ed1205682ec42a) *should* fix the
issue triggered by the ftrace kselftests.

> > That was intended to fix this specific issue, as explained in the commit
> > message (with a very similar splat from running the ftrace kselftests).
> > 
> > Am I missing something? i.e. are you saying it *doesn't* fix that?
> 
> Right - LKFT is able to trigger the warning I copied on Linus's tree.

Is that "Right" as in "Right, that commit fixes it", or "Right, that
commit does not fix it"?

The warning you reported says:

	Not tainted 6.13.0-rc2 #1

... which is *before* either of the two fixes above, since the arm64
for-next/fixes branch is based on v6.13-rc2.

Are you seeing the warning with those applied? e.g. do you see this in
v6.13-rc3? I cannot reproduce the issue on v6.13-rc3 so far.

Mark.


      reply	other threads:[~2024-12-16 17:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-13 17:41 [GIT PULL] arm64 fixes for 6.13-rc3 Catalin Marinas
2024-12-13 22:34 ` pr-tracker-bot
2024-12-15 17:06 ` Sasha Levin
2024-12-16 10:02   ` Mark Rutland
2024-12-16 14:59     ` Sasha Levin
2024-12-16 17:36       ` Mark Rutland [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z2BlFtmP4QP3XyLe@J2N7QTR9R3.cambridge.arm.com \
    --to=mark.rutland@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sashal@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).