From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6CF3BE77184 for ; Wed, 18 Dec 2024 01:12:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=//AsXtq/PKwVlsB/6NdH9AeHKR9dR/Splpn+baz2miA=; b=UulSTm9Cp/akzhp5lVUIfyhT9K e7KEgLV+8Zo2VFu4ZoGhkZLovKLZrpJEIpE9gi9WIq0zZI1654Q9tmwZXpW0+MZ3W2IDNpKsN3pc+ CowWhzwTvPEta2r47ksTx70YVOx5Q9kv9ue2LNS2Ur7K7L6yVKStWvK4i899YLVVlFYpj4MZe9EJ9 rGAprqAHCaaVeTiuRi1hqGbPwTbq9K6HFFC2+1W+9dZm3NRokiH/QDNH3V0z9uzsWowuUnKnDgOj3 prCdGigqQTF92eJy8oW8qE/zHJPZnbexdZn4IswQ0YHl/KAilX1kW9tUkwLzxmr1GISBiB4DFHuvH UjWzVGlA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tNibw-0000000FHTF-3hsl; Wed, 18 Dec 2024 01:12:24 +0000 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tNiao-0000000FHIT-3rrn for linux-arm-kernel@lists.infradead.org; Wed, 18 Dec 2024 01:11:17 +0000 Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-21683192bf9so56358535ad.3 for ; Tue, 17 Dec 2024 17:11:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1734484274; x=1735089074; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=//AsXtq/PKwVlsB/6NdH9AeHKR9dR/Splpn+baz2miA=; b=XevAFXumJTr695sl/8ma3hMkb89AqOlzWcCvvsa2+mi46rUrLz1b+9ZwbJw14C2aiC GXQNkTFcy06bcRpcLHXxTWSJjrVCH0r4liO1AV1PSpS/ANmvjzaqHHqO9Z6QnMpM3Z/9 zb+snoLdTxS1Lms10/j32pmXVXUHhYW+Nh6l5wL/XhNWazw5nqQ9YgsZVbUbSekT8cvH Vw0qNsrMj8REp/yfAuDb0zrBvhGGK0S+egJJmnzKXKjDTDzG5FaMmzJs7vUHjSfBOr7M deI4ebLHyRPXP1Pe33GZbFl+z7oKKFINdA2RdpNknVbG+XhZv+lh0trf1gV8ixngVGR0 huPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734484274; x=1735089074; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=//AsXtq/PKwVlsB/6NdH9AeHKR9dR/Splpn+baz2miA=; b=FW8GQ1POXwY/B13lGhyjf+9AMy3joBNSaPW9zMGNvWG0ko8BiyOcg0g/NpLKfRzTs9 EMgDmKH2BlwdeIxM4sd/LNPC6lsyhCmu6ZaZ+fAv++8AnJvwBSmj7FkxwGdZeH2JfwOR BPNcrr0EKVOXVZKxeEnvvitDknCLF9liRlCipEufwQHLfGvG7MJZUT80gQU0Jc2OdD9c R9Gl8KUK1mez/dcuOF9mZzqhd/lXs3SPzlFiulAUjO3BD057cbkEv5rwUCzPWHumm4fw 8E6O49XVj4R2mV2lMLk5Q26PKcNzMF0YdxAzwMrOu0YfWOsWZW3MeJE12wHo/6ru/y41 0Leg== X-Forwarded-Encrypted: i=1; AJvYcCUNm+21RcBexgzdjhByUTDjwvcfK667XfAhjIaNKrhHI6ep0f1QFAneWW+0e7UvohQSdCsRjrCZZ1vKtEe4WsjJ@lists.infradead.org X-Gm-Message-State: AOJu0YxZV4b7FmBL55yzVHox/3V6KiiYevmJ9Xxst6gBHPcMS6YnJZsR rSR4+bE+tqC6KMlqAsoJ+OI22V4l/C/EW/YA1mrFjHma6HuerRLjJEAL0WVDsjc= X-Gm-Gg: ASbGnctb1djkjO9sx42UAPHOQxMEX8efJF6HVh7xyGOgY8+XAsyuYEz8pteCBfR3VwC fBDNae9cul90VNQcKGmzLxNT8/FMdTnY5EzMtzxLT3RtgHk9wQ7OByfSF5QGDE9D3uEJlTDFG9j W31fhL6wiNVBA0osO7+XrOS+m1KoAlew2gP0ejdMfwEz/llJ2Qxl5aD+0Du0W8hH5+uuO5fQ1o/ TxUwClfztf0lCY41iVoxGMjbApvroqf3mldh8wfKwXkJuQ= X-Google-Smtp-Source: AGHT+IEOXPRe9Wq6Eef0ftWD1QmBlV0TBPdEvvDl6Yjh3OVfGIkOaO5fTDZemiJS1rNtOnnDywF/wA== X-Received: by 2002:a17:902:f705:b0:216:2e5e:971d with SMTP id d9443c01a7336-218d726c177mr12199525ad.51.1734484273938; Tue, 17 Dec 2024 17:11:13 -0800 (PST) Received: from ghost ([50.145.13.30]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-218a1e657d1sm65805315ad.239.2024.12.17.17.11.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Dec 2024 17:11:12 -0800 (PST) Date: Tue, 17 Dec 2024 17:11:09 -0800 From: Charlie Jenkins To: Ian Rogers Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Adrian Hunter , Paul Walmsley , Palmer Dabbelt , =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= , =?iso-8859-1?Q?G=FCnther?= Noack , Christian Brauner , Guo Ren , John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Jonathan Corbet , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , Arnd Bergmann , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-riscv@lists.infradead.org, linux-security-module@vger.kernel.org, bpf@vger.kernel.org, linux-csky@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v3 00/16] perf tools: Use generic syscall scripts for all archs Message-ID: References: <20241216-perf_syscalltbl-v3-0-239f032481d5@rivosinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241217_171115_039371_9440AB19 X-CRM114-Status: GOOD ( 31.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 17, 2024 at 04:03:29PM -0800, Ian Rogers wrote: > On Mon, Dec 16, 2024 at 10:39 PM Charlie Jenkins wrote: > > > > Standardize the generation of syscall headers around syscall tables. > > Previously each architecture independently selected how syscall headers > > would be generated, or would not define a way and fallback onto > > libaudit. Convert all architectures to use a standard syscall header > > generation script and allow each architecture to override the syscall > > table to use if they do not use the generic table. > > > > As a result of these changes, no architecture will require libaudit, and > > so the fallback case of using libaudit is removed by this series. > > > > Testing: > > > > I have tested that the syscall mappings of id to name generation works > > as expected for every architecture, but I have only validated that perf > > trace compiles and runs as expected on riscv, arm64, and x86_64. > > > > Signed-off-by: Charlie Jenkins > > This is really great, thanks for taking the time for a substantial > clean up. I had difficulty applying the patches to the perf-tools-next > branch: > https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/log/?h=perf-tools-next > using patch and dealing with rejects I was able to test. > > Reviewed-by: Ian Rogers > On x86-64: > Tested-by: Ian Rogers Thank you! I will base my next version on perf-tools-next. - Charlie > > I think there are follow up patches that clean up the ABI, allow >1 > table at a time, .. but those things are best saved for a follow up. > > Thanks, > Ian > > > --- > > Changes in v3: > > - Fix compiliation when OUTPUT is empty > > - Correct unused headers to be .h instead of .c (Namhyung) > > - Make variable definition of supported archs (Namhyung) > > - Convert += into := for syscalls headers (Namhyung) > > - Link to v2: https://lore.kernel.org/r/20241212-perf_syscalltbl-v2-0-f8ca984ffe40@rivosinc.com > > > > Changes in v2: > > - Rebase onto 6.13-rc2 > > - Fix output path so it generates to /tools/perf/arch properly > > - Link to v1: https://lore.kernel.org/r/20241104-perf_syscalltbl-v1-0-9adae5c761ef@rivosinc.com > > > > --- > > Charlie Jenkins (16): > > perf tools: Create generic syscall table support > > perf tools: arc: Support generic syscall headers > > perf tools: csky: Support generic syscall headers > > perf tools: arm: Support syscall headers > > perf tools: sh: Support syscall headers > > perf tools: sparc: Support syscall headers > > perf tools: xtensa: Support syscall header > > perf tools: x86: Use generic syscall scripts > > perf tools: alpha: Support syscall header > > perf tools: parisc: Support syscall header > > perf tools: arm64: Use syscall table > > perf tools: loongarch: Use syscall table > > perf tools: mips: Use generic syscall scripts > > perf tools: powerpc: Use generic syscall table scripts > > perf tools: s390: Use generic syscall table scripts > > perf tools: Remove dependency on libaudit > > > > Documentation/admin-guide/workload-tracing.rst | 2 +- > > tools/build/feature/Makefile | 4 - > > tools/build/feature/test-libaudit.c | 11 - > > tools/perf/Documentation/perf-check.txt | 1 - > > tools/perf/Makefile.config | 39 +- > > tools/perf/Makefile.perf | 12 +- > > tools/perf/arch/alpha/entry/syscalls/Kbuild | 2 + > > .../arch/alpha/entry/syscalls/Makefile.syscalls | 5 + > > tools/perf/arch/alpha/entry/syscalls/syscall.tbl | 504 ++++++++++++++++++++ > > tools/perf/arch/alpha/include/syscall_table.h | 2 + > > tools/perf/arch/arc/entry/syscalls/Kbuild | 2 + > > .../perf/arch/arc/entry/syscalls/Makefile.syscalls | 3 + > > tools/perf/arch/arc/include/syscall_table.h | 2 + > > tools/perf/arch/arm/entry/syscalls/Kbuild | 4 + > > .../perf/arch/arm/entry/syscalls/Makefile.syscalls | 2 + > > tools/perf/arch/arm/entry/syscalls/syscall.tbl | 483 +++++++++++++++++++ > > tools/perf/arch/arm/include/syscall_table.h | 2 + > > tools/perf/arch/arm64/Makefile | 22 - > > tools/perf/arch/arm64/entry/syscalls/Kbuild | 3 + > > .../arch/arm64/entry/syscalls/Makefile.syscalls | 6 + > > tools/perf/arch/arm64/entry/syscalls/mksyscalltbl | 46 -- > > .../perf/arch/arm64/entry/syscalls/syscall_32.tbl | 476 +++++++++++++++++++ > > .../perf/arch/arm64/entry/syscalls/syscall_64.tbl | 1 + > > tools/perf/arch/arm64/include/syscall_table.h | 8 + > > tools/perf/arch/csky/entry/syscalls/Kbuild | 2 + > > .../arch/csky/entry/syscalls/Makefile.syscalls | 3 + > > tools/perf/arch/csky/include/syscall_table.h | 2 + > > tools/perf/arch/loongarch/Makefile | 22 - > > tools/perf/arch/loongarch/entry/syscalls/Kbuild | 2 + > > .../loongarch/entry/syscalls/Makefile.syscalls | 3 + > > .../arch/loongarch/entry/syscalls/mksyscalltbl | 45 -- > > tools/perf/arch/loongarch/include/syscall_table.h | 2 + > > tools/perf/arch/mips/entry/syscalls/Kbuild | 2 + > > .../arch/mips/entry/syscalls/Makefile.syscalls | 5 + > > tools/perf/arch/mips/entry/syscalls/mksyscalltbl | 32 -- > > tools/perf/arch/mips/include/syscall_table.h | 2 + > > tools/perf/arch/parisc/entry/syscalls/Kbuild | 3 + > > .../arch/parisc/entry/syscalls/Makefile.syscalls | 6 + > > tools/perf/arch/parisc/entry/syscalls/syscall.tbl | 463 +++++++++++++++++++ > > tools/perf/arch/parisc/include/syscall_table.h | 8 + > > tools/perf/arch/powerpc/Makefile | 25 - > > tools/perf/arch/powerpc/entry/syscalls/Kbuild | 3 + > > .../arch/powerpc/entry/syscalls/Makefile.syscalls | 6 + > > .../perf/arch/powerpc/entry/syscalls/mksyscalltbl | 39 -- > > tools/perf/arch/powerpc/include/syscall_table.h | 8 + > > tools/perf/arch/riscv/Makefile | 22 - > > tools/perf/arch/riscv/entry/syscalls/Kbuild | 2 + > > .../arch/riscv/entry/syscalls/Makefile.syscalls | 4 + > > tools/perf/arch/riscv/entry/syscalls/mksyscalltbl | 47 -- > > tools/perf/arch/riscv/include/syscall_table.h | 8 + > > tools/perf/arch/s390/Makefile | 21 - > > tools/perf/arch/s390/entry/syscalls/Kbuild | 2 + > > .../arch/s390/entry/syscalls/Makefile.syscalls | 5 + > > tools/perf/arch/s390/entry/syscalls/mksyscalltbl | 32 -- > > tools/perf/arch/s390/include/syscall_table.h | 2 + > > tools/perf/arch/sh/entry/syscalls/Kbuild | 2 + > > .../perf/arch/sh/entry/syscalls/Makefile.syscalls | 4 + > > tools/perf/arch/sh/entry/syscalls/syscall.tbl | 472 +++++++++++++++++++ > > tools/perf/arch/sh/include/syscall_table.h | 2 + > > tools/perf/arch/sparc/entry/syscalls/Kbuild | 3 + > > .../arch/sparc/entry/syscalls/Makefile.syscalls | 5 + > > tools/perf/arch/sparc/entry/syscalls/syscall.tbl | 514 +++++++++++++++++++++ > > tools/perf/arch/sparc/include/syscall_table.h | 8 + > > tools/perf/arch/x86/Build | 1 - > > tools/perf/arch/x86/Makefile | 25 - > > tools/perf/arch/x86/entry/syscalls/Kbuild | 3 + > > .../perf/arch/x86/entry/syscalls/Makefile.syscalls | 6 + > > tools/perf/arch/x86/entry/syscalls/syscalltbl.sh | 42 -- > > tools/perf/arch/x86/include/syscall_table.h | 8 + > > tools/perf/arch/xtensa/entry/syscalls/Kbuild | 2 + > > .../arch/xtensa/entry/syscalls/Makefile.syscalls | 4 + > > tools/perf/arch/xtensa/entry/syscalls/syscall.tbl | 439 ++++++++++++++++++ > > tools/perf/arch/xtensa/include/syscall_table.h | 2 + > > tools/perf/builtin-check.c | 1 - > > tools/perf/builtin-help.c | 2 - > > tools/perf/builtin-trace.c | 30 -- > > tools/perf/check-headers.sh | 9 + > > tools/perf/perf.c | 6 +- > > tools/perf/scripts/Makefile.syscalls | 61 +++ > > tools/perf/scripts/syscalltbl.sh | 86 ++++ > > tools/perf/tests/make | 7 +- > > tools/perf/util/env.c | 4 +- > > tools/perf/util/generate-cmdlist.sh | 4 +- > > tools/perf/util/syscalltbl.c | 90 +--- > > tools/scripts/syscall.tbl | 409 ++++++++++++++++ > > 85 files changed, 4102 insertions(+), 619 deletions(-) > > --- > > base-commit: fac04efc5c793dccbd07e2d59af9f90b7fc0dca4 > > change-id: 20240913-perf_syscalltbl-6f98defcc6f5 > > -- > > - Charlie > >