Re: [PATCH 10/10] arm64: dts: imx8mp-skov: increase I2C clock frequency for RTC

[Frank Li <Frank.li@nxp.com>]

On Thu, Dec 19, 2024 at 06:51:35PM +0100, Ahmad Fatoum wrote:
> On 19.12.24 18:47, Frank Li wrote:
> > On Thu, Dec 19, 2024 at 08:25:34AM +0100, Ahmad Fatoum wrote:
> >> From: Oleksij Rempel <o.rempel@pengutronix.de>
> >>
> >> The NXP PCF85063TP RTC we use is capable of up to 400 kHz of SCL clock
> >> frequency, so let's make use of this instead of the 100 kHz bus frequency
> >> we are currently using.
> >
> > Increase I2C frequency to 400khz from 100kHz because NXP PCF85063TP RTC
> > support it.
>
> Unlike your other suggestions, these is no information lost by rewriting
> the commit message as you suggest. I don't mind, but must admit it feels
> like bikeshedding. What is your concrete objection to my commit message?

According to
https://docs.kernel.org/process/submitting-patches.html

Describe your changes in imperative mood, e.g. “make xyzzy do frotz”
instead of “[This patch] makes xyzzy do frotz” or
“[I] changed xyzzy to do frotz”, as if you are giving orders to the
codebase to change its behaviour.

Generally, avoid use

"this patch ..."
"let's ...."
"we do ... for ... "

Just simple said

Do ... to ...
Do ... because ...

Frank

>
> Thanks,
> Ahmad
>
>
> >
> > Frank
> >
> >>
> >> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> >> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> >> ---
> >>  arch/arm64/boot/dts/freescale/imx8mp-skov-reva.dtsi | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-skov-reva.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-skov-reva.dtsi
> >> index a683f46fcbab..ec7857db7bf0 100644
> >> --- a/arch/arm64/boot/dts/freescale/imx8mp-skov-reva.dtsi
> >> +++ b/arch/arm64/boot/dts/freescale/imx8mp-skov-reva.dtsi
> >> @@ -333,7 +333,7 @@ reg_nvcc_sd2: LDO5 {
> >>  };
> >>
> >>  &i2c3 {
> >> -	clock-frequency = <100000>;
> >> +	clock-frequency = <400000>;
> >>  	pinctrl-names = "default";
> >>  	pinctrl-0 = <&pinctrl_i2c3>;
> >>  	status = "okay";
> >>
> >> --
> >> 2.39.5
> >>
> >
>
>
> --
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |