From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2EEBDE77184 for ; Thu, 19 Dec 2024 20:55:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To: Content-Type:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bUoZ2jjqS5qwFCmsSe5h68wiZT4ncLI3/LFFStBzVI4=; b=fJ5HrsKjX1d8H9vMFZeR14pdy+ vXg/8jUon3zBAZx+4AaovIGqDhOAxshHhWOwBVjYNYX9vTxDyjuqHi2B7arpq9Ft5J37QMdEAG2iv 4bUCImxe+7y0fqVfRlfShwjx+oss/BltmMucmoBm9aFjm3q9nzUPbr4yIPSR0y1gPUxjr2/MDRPX2 OjdNlC58vD2jZcrffZwtpd74dJ4EsT9b648LkbVx0IAGVQAG8GXl5og5LmB4z+G3rezHcrS8KAiFq /Fb7qRB5vnAOivzpQ41Yz6ns2gcwdjHI7hkXz0Dd/Rs0Q5EftFxxtllGOLicpY9+1G3tQk1MlhWxo i/lNRybw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tONYK-000000035Nu-0D2A; Thu, 19 Dec 2024 20:55:24 +0000 Received: from mail-am6eur05on20624.outbound.protection.outlook.com ([2a01:111:f403:2612::624] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tONX9-000000035Ar-1hA6 for linux-arm-kernel@lists.infradead.org; Thu, 19 Dec 2024 20:54:12 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BXi4chNkX9NhgrF+sjmUZfccnZ4eTDskWTi79hDiCv0KDM/IC1earBjWchlqJ8cz5kBRq11OSlePULD1r9Zscwrcn4BvSzyvxvaoQtVK5tKnDKDfqBNGYIEHQKSRWxBzjjnJnJDisUlLuPRlPjI3lyQEAkAYI6fCMd73aHgJxFvFOLvVr/t965kWXT2LcoyiUZhvK0uf9qMXyM5t43z99dEzuVCwB9iHHa+7QhKSNTyIwWViBomgjaF6Il3AnRsOGHJVUPFuUajRgtop+MR5MfYAgNDZmmtUXODzy+KzEKh3zqCbCpngy7JxoVzR81j4eJlvUZpSg8FiYWDhGOiXQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bUoZ2jjqS5qwFCmsSe5h68wiZT4ncLI3/LFFStBzVI4=; b=iZFLvzrstPPMkPGqxtd3Dy/JOBOxxKlDEMDCFmHxONuGiyjlj4rQm5rx7i81oOjmjFKlNju2WZxDy5MvSmTPAnT+h6L+IliQpzlY509hd1JY/6XnO6pcEA8QenDrTCiKa3krfRZxgoJ5aKwScf5ULbnwM04cPIDoqdC6shusI1Bo12GG8n8Jk+8M8zzLMUZOyd70cQGK5msITEMZhLgwb+KxWTzGAH27D3FVtds77s3GrhjKHtzLeZql6kp85Nyq7ndpCslGEJFQRXu+zDxz78nONNCw3pITxallvc1Kol1mt4oPrmh8iLaDpixkX1imq7lSC8n0bYaPgHYpq69Z/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bUoZ2jjqS5qwFCmsSe5h68wiZT4ncLI3/LFFStBzVI4=; b=Dc8Blj6kCgx376TrChk0cs7hXKubY9tOFnUZAa5+AvMjmcAP+TbJS9hoFSVLGCrl+Jlb5pw0ERsnF49GMqceUmgw3cgBXTOPS9ocvXmur0S+UQVL62tfJ9GqLvMEmnVhYG0R/BP97axwigMqNrnvI6L/3QoYMo47fJFTQ9Lv289Ygp4ARuAJl3IKyW53gUM3C2GO8svQkCXREjRNBpY8hKED4MPiAIH0EeJ1hgKdVfOLuGa8brC5cXrz6G/LLUfP0oiOMyaCos4u3XNRovwCa3bibJlh32mWitSEpyzARNc5mLJ8L9dUarQP8hvGar6pRGeB7W9gnfHnnXLi5tjS5Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by AS5PR04MB9855.eurprd04.prod.outlook.com (2603:10a6:20b:652::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8272.14; Thu, 19 Dec 2024 20:54:05 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%5]) with mapi id 15.20.8272.005; Thu, 19 Dec 2024 20:54:05 +0000 Date: Thu, 19 Dec 2024 15:53:56 -0500 From: Frank Li To: Niklas Cassel Cc: Marc Zyngier , Manivannan Sadhasivam , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Kishon Vijay Abraham I , Bjorn Helgaas , Arnd Bergmann , Greg Kroah-Hartman , "Rafael J. Wysocki" , Thomas Gleixner , Anup Patel , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, imx@lists.linux.dev, dlemoal@kernel.org, jdmason@kudzu.us, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v13 4/9] irqchip/gic-v3-its: Add DOMAIN_BUS_DEVICE_PCI_EP_MSI support Message-ID: References: <20241218-ep-msi-v13-0-646e2192dc24@nxp.com> <20241218-ep-msi-v13-4-646e2192dc24@nxp.com> <868qscq70x.wl-maz@kernel.org> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: BY5PR17CA0010.namprd17.prod.outlook.com (2603:10b6:a03:1b8::23) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|AS5PR04MB9855:EE_ X-MS-Office365-Filtering-Correlation-Id: 3fbbc5da-e778-4bf4-9ac3-08dd206f464f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|52116014|7416014|376014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?AAorejPBs0wL0Zu739EyV8LiugRlEPXsYQsk7KlQVnKyWUWxr2WQx+olpUeS?= =?us-ascii?Q?fEcNASy8dgNMvDGxhUpIZLASOW6h+lPYbjAa01d7xKm7N+Uq3MCwxTn26qq5?= =?us-ascii?Q?ksjz9Owhf7GyM9kSThJ7qPbjvf+ANBXTsKz9heJEZbFSZTELqDavNz7XTe07?= =?us-ascii?Q?rf/3YSgi+l+sJEKuXJclXGd7mQDuVATYjhxB8eKbPpAEZiETJJcr6Evhf/vB?= =?us-ascii?Q?hiyO1eLPwou0PfykoUR08d8tG9khKQwybNQSC5bfLImPSFAmyK9w1NJUa+/b?= =?us-ascii?Q?fY+suNHTEiUs5FW7ycHHIFFPrgxidkxwDQaep1x6AA5Am2KLZM5J/mGFCoKR?= =?us-ascii?Q?nhgK5j6hhqT8tfrp8GMJ9ReQr09pmngwDzkS38WVDT1MquQjuMnaOzcLFV8g?= =?us-ascii?Q?NTZ88B3vUV2FH37IyA/HyndJMITinLXbsxuqRibzvjY6GExShzLWfUxw2JE8?= =?us-ascii?Q?YvDEDv2IHowwBtm5z8Vrg1vF82IKs/EbfYa2cLTbl1tOnbmABna98xs9/8+n?= =?us-ascii?Q?ScU+X+hkTmYbvIh9p88bFNZM/PQdDU/JSqinIxYXTNauXwmzTETZl5+ltsnP?= =?us-ascii?Q?SPW75IdpehN6Fm2DEOKFEc1ZagQ1M8MyfD2U/RCiyLjPz/ouNk8Ddgrx2QRA?= =?us-ascii?Q?7VmIEPDKIySZFZ22E66fuCdD9IuDqt5yz0OA4JQNvjxLjvZT2HnCPpKsmsUn?= =?us-ascii?Q?zQUtLXwlm/SA1pO2hf2v32Pw+ZabNydIzZpJrhSz5EqBL0x0Q6SMMBoogN9t?= =?us-ascii?Q?UUlcqqPG9rhp72u7dHDg/941c0zfZCw+G3xlfYXUMkz+Y2dTIuD02oQxe5G5?= =?us-ascii?Q?PUaBbvL9mpj9popozupdJ0Lqob00lonMtMwLSAAJXAAzpaWIBjPmIeLnyEEf?= =?us-ascii?Q?7mddzHY1uI6kkzkviCw/U2Izp3olyqqrlCxfbLs3/9jU39i07lF861qC5S+f?= =?us-ascii?Q?it66uXWU1/4dHoYOPTzoMcM9bxdxqWbIfBqbkXHGiqGsFGFhT7iWZB+oZt22?= =?us-ascii?Q?+/Hwq5GzvM1YzTAvkdpg+33nYyjhxLbmm6NbPmjp4rTbz8ol+dUCdskxPjFM?= =?us-ascii?Q?x1cmwQnUnGdDx8J9fQkE/7uDExAaIF6b3ZWtaSLVcB+FvOiTAyqMgrgR6but?= =?us-ascii?Q?aeuVMYez2+pE3X4ywJSNMxWvgAxmjVwmW5JCV8b+d+LfxRy6j/ffAhW3Qesd?= =?us-ascii?Q?+ujSOqd20M0A+7WwMlOs+r93XyghjEDn+5+BAHcOIFcA6YF2EpW0CjoQa570?= =?us-ascii?Q?yOlk45Yb2sg4kWcVK8Kd16Ib1gGdPHJWvISaRpXZokhuB1iwnROr28hduKWp?= =?us-ascii?Q?dUKEjF9AiGxFbCPmRQCKSHuSy1AvrLivGdyY6t9iPljRxbF1hDT+D4uBKgZi?= =?us-ascii?Q?UuKdyTknmz0BBXUdcZ1q9+8JWXZtOBituZPYjAcjSVG21Jlch0w/7nDXPdqa?= =?us-ascii?Q?R7cZkeLfSLVbWj0BOdOaMKsY3uaNytDm?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(52116014)(7416014)(376014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ptGyd7nYee9Dv2CeL9cQp7xQ+sjbn8IDw0fLMwl43y0NiEmobEiT2qw9+Hfs?= =?us-ascii?Q?e9lGzgapiizQbEtMvApQ2wEGyT1KPO4CSucDOloo9Q8HFclOtrDk5P/y/iEX?= =?us-ascii?Q?4bo/r32HB3IsfQ7yV4zkFxkUoT8AL8VyPm4VEQTb+NbwWVD9oIcgDgrnbnD+?= =?us-ascii?Q?Rl+dkh8giwPu2tnLmdE6W/jJMJ22wP1ZqZxupC91h249W3wz9Bu8jXbKRaW+?= =?us-ascii?Q?5gZ16CXP5Ihx8oEnil2dqpLWukoe0TeKDXaMkNB4i5BWZ7ap2GZ0H4D9h0BP?= =?us-ascii?Q?AZ9ciNY9ugy9hWRNzuuEWB1N/NwP14G9uDEyd6PDIHm5kxXN67O1DfbEVB0M?= =?us-ascii?Q?Yb7jggCSJRa+EDO2nqBFtZwjjFJB3S8lAOK0u06zBVc8bwIYNq7X0FofWE2E?= =?us-ascii?Q?hI7ky8sDNrVbbc2HgnYB365xfN38Izk2NgV1XtsE0880UGhZrdRAfY4S011Z?= =?us-ascii?Q?ZkO6g2oSo37lg/B/q1ouIyRziIoDrQpXxdErmv3RNogV9ARr6jCAAHb2XGer?= =?us-ascii?Q?OyJUbGFf2qx3YNykqwxtyKq0i0H/gQz6qLEDiOmAwzi50C/C8wx/uLpZy3pI?= =?us-ascii?Q?ln3Sngn/gWTlIO2iXoXEJwUy1WmbJ5JdkUWv4QUnbrtqgXAke+dOpzU9Rcls?= =?us-ascii?Q?nDfPeBUzqYL6ayV8QR4HeXDQ0rprjGA56SLEVT1ojNKPeY0k4Cb3/sX70yOX?= =?us-ascii?Q?xLmtx0aWAUUnFdBYJZ3vXOWIlmbVDqKhVRJrXocI03ABx7efOesamTOleplF?= =?us-ascii?Q?YTtxp9kOekq06jq/Jy/uaxqoc/Pl6nTYt0++L+GH/IzHSQEcWEbaXEE5gvTQ?= =?us-ascii?Q?YsCFoGhshyLvrFK+CIKDGeAax9PzT6gzcYMTOhxRkk6c9QwZlf8gu4TLDkfl?= =?us-ascii?Q?vWKHXZYPd4iKeIrfgPC6CIpQfS0wMuFz7sstnHT5/R/8jc7Wo9Pg5je5Hn67?= =?us-ascii?Q?N5hJjrtEs0DKZtZgKt29Ne1wJHlTvNsILHfRLV+TR2k8lAYLIHFQTZIxlL3D?= =?us-ascii?Q?1NDPvMyBWcCfbZkaWlnln21yrFzRSYWcOB7wToRkgvSbys0j1GhHNFF4VqhD?= =?us-ascii?Q?c4jBSUeQ1gqvcHwKiVmdjVr5FjNnlCgHc1XUgyMdvdA/KqqY3Gk8K2ZsOu2q?= =?us-ascii?Q?GBJyhLIScbTXvX3bAWVezja7FxCIDiU8k1vMyZSDyKBjgIiIr7/VXXdOgyie?= =?us-ascii?Q?oFcLTvY27HupVkkJUcSRz0ZFBAI5/YMDDboGzCv9o7WwFOPgwycXgCxOEVMs?= =?us-ascii?Q?YBgWsbbAf7Wf1VSJbKlvk1VcsHUHhJRrQt5irpL+bg43pQ7CxV0SemEuDJIC?= =?us-ascii?Q?jVTBNTP28HNHdkb8bNDSmmuwfrl0D+sGrFtE7oOa0ttGOC9oc0iraa48RfPT?= =?us-ascii?Q?XlkOA/CM/VAbEYLOvSgFY9TbXyCNfUg/ozaoNxThoFa6KzXINbiOZbh3hCLv?= =?us-ascii?Q?iayPTxsb9IlHB9BaZzIB17mCpcZ30nkUKwy1Pj+clF405IBW+s6RIrmVUQjl?= =?us-ascii?Q?4W1a29hUVx/Bk+i8EBRl4Sbz5fNtipMM+h5DQbUNRa7+i/l4qobNe9aIhvom?= =?us-ascii?Q?yK2QqapXryfG1oQW0L4=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3fbbc5da-e778-4bf4-9ac3-08dd206f464f X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2024 20:54:05.0792 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PreWJyL7hebVOUhwpdtWXqOTvR/qoi3t2DVTuqSUWqTSBHm/epc21mUljLQC5utDlw5IIiPFld/zJR+yZuHHXQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS5PR04MB9855 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241219_125411_448604_F41BE787 X-CRM114-Status: GOOD ( 21.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Dec 19, 2024 at 09:43:15PM +0100, Niklas Cassel wrote: > On Thu, Dec 19, 2024 at 03:17:15PM -0500, Frank Li wrote: > > > > Thank you very much. I update msi part, so endpoint controller node align > > host controller node. > > > > It should be > > msi-map = <0x0000 &its1 0x0000 0x1000>; > > > > So if your hardware support multi physical function, your can create more > > than one pci_test func. Previous version only support one EP func. > > I see. That seems like an improvement. > I will need to ask Rockchip maintainer to drop my msi-parent patch for PCIe > EP node then. (Which is currently queued up in for-6.14) > > However, for the PCIe host node, rk3588 has: > iommu-map = <0x0000 &mmu600_pcie 0x0000 0x1000>; > > For the PCIe endpoint node, rk3588 has: > iommus = <&mmu600_pcie 0x0000>; > > https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v6.14-armsoc/dts64&id=da92d3dfc871e821a1bface3ba5afcf8cda19805 > > Is it fine that for the PCIe EP node, we specify iommu mapping using: > iommus = <&mmu600_pcie 0x0000>; > but the ITS/MSI map will be: > msi-map = <0x0000 &its1 0x0000 0x1000>; For doorbell feature, it should be fine. > > isn't this a bit inconsistent? Ideally, iommus need do similar map. > > The physical function is the "F" in the BDF. > Does this mean that: > iommus = <&mmu600_pcie 0x0000>; > the IOMMU will not be able to distinguish different PCI physical functions > from the same PCI device? You are right. All physical functions will share one IOMMU space. > So two different physical functions on the same > PCI device share the same IOMMU mappings? Yes, Function should be okay. Only miss isolation protection. func1 and access func2's dma memory address. At most system it should be fine. Frank > > > Kind regards, > Niklas