From: Yeoreum Yun <yeoreum.yun@arm.com>
To: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: Mike Leach <mike.leach@linaro.org>,
james.clark@linaro.org, alexander.shishkin@linux.intel.com,
bigeasy@linutronix.de, clrkwllms@kernel.org, rostedt@goodmis.org,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev
Subject: Re: [PATCH v3 0/9] coresight: change some driver' spinlock type to raw_spinlock_t
Date: Fri, 20 Dec 2024 11:39:31 +0000 [thread overview]
Message-ID: <Z2VXc/R/nOLGz+Cg@e129823.arm.com> (raw)
In-Reply-To: <ac537889-dc0a-4d2e-870b-c5a33279633e@arm.com>
Hi Suzuki,
> On 20/12/2024 10:38, Yeoreum Yun wrote:
> > Hi Mike.
> >
> > > Notably missing is the same changes for the etm3x driver. The ETMv3.x
> > > and PTM1.x are supported by this driver, and these trace source
> > > variants are also supported in perf in the cs_etm.c code.
> >
> > But I wonder etmv3 needs to change. Because its spinlock is used only
> > via sysfs enable/disable path.
> > So, I think it doesn't need to change the lock type.
>
> ETM3 can be used in perf mode, similar to the ETM4x.
>
> So, you need to fix it as well.
Yes. But etmv3's etmdata->spinlock doesn't used in perf path
its usage is only in sysfs interface path.
That's why I think it could skip too.
Thanks.
next prev parent reply other threads:[~2024-12-20 11:42 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-16 11:49 [PATCH v3 0/9] coresight: change some driver' spinlock type to raw_spinlock_t Yeoreum Yun
2024-12-16 11:49 ` [PATCH v3 1/9] coresight: change coresight_device lock " Yeoreum Yun
2024-12-19 12:23 ` Mike Leach
2024-12-16 11:49 ` [PATCH v3 2/9] coresight-etm4x: change etmv4_drvdata spinlock " Yeoreum Yun
2024-12-19 12:24 ` Mike Leach
2024-12-20 10:13 ` Yeoreum Yun
2024-12-16 11:50 ` [PATCH v3 3/9] coresight: change coresight_trace_id_map's lock " Yeoreum Yun
2024-12-19 12:24 ` Mike Leach
2024-12-16 11:50 ` [PATCH v3 4/9] coresight-cti: change cti_drvdata spinlock's " Yeoreum Yun
2024-12-19 12:24 ` Mike Leach
2024-12-16 11:50 ` [PATCH v3 5/9] coresight-etb10: change etb_drvdata " Yeoreum Yun
2024-12-19 12:24 ` Mike Leach
2024-12-16 11:50 ` [PATCH v3 6/9] coresight-funnel: change funnel_drvdata " Yeoreum Yun
2024-12-19 12:24 ` Mike Leach
2024-12-16 11:50 ` [PATCH v3 7/9] coresight-replicator: change replicator_drvdata " Yeoreum Yun
2024-12-19 12:24 ` Mike Leach
2024-12-16 11:50 ` [PATCH v3 8/9] coresight-tmc: change tmc_drvdata " Yeoreum Yun
2024-12-19 12:23 ` Mike Leach
2024-12-16 11:50 ` [PATCH v3 9/9] coresight/ultrasoc: change cti_drvdata " Yeoreum Yun
2024-12-19 12:24 ` Mike Leach
2024-12-20 10:07 ` Yeoreum Yun
2024-12-19 12:27 ` [PATCH v3 0/9] coresight: change some driver' spinlock " Mike Leach
2024-12-20 10:06 ` Yeoreum Yun
2024-12-20 10:38 ` Yeoreum Yun
2024-12-20 11:35 ` Suzuki K Poulose
2024-12-20 11:39 ` Yeoreum Yun [this message]
2024-12-20 11:48 ` Suzuki K Poulose
2024-12-20 11:50 ` Yeoreum Yun
2024-12-21 17:02 ` Yeoreum Yun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z2VXc/R/nOLGz+Cg@e129823.arm.com \
--to=yeoreum.yun@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=bigeasy@linutronix.de \
--cc=clrkwllms@kernel.org \
--cc=coresight@lists.linaro.org \
--cc=james.clark@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-devel@lists.linux.dev \
--cc=mike.leach@linaro.org \
--cc=rostedt@goodmis.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).