* [RESEND PATCH] arm/pgtable: Remove duplicate included header file
@ 2024-12-25 12:30 Thorsten Blum
2024-12-25 13:42 ` Mike Rapoport
0 siblings, 1 reply; 5+ messages in thread
From: Thorsten Blum @ 2024-12-25 12:30 UTC (permalink / raw)
To: Russell King, Thorsten Blum, Mike Rapoport (IBM),
David Hildenbrand, Andrew Morton
Cc: linux-arm-kernel, linux-kernel
The header file asm-generic/pgtable-nopud.h is included whether
CONFIG_MMU is defined or not.
Include it only once before the #ifndef/#else/#endif preprocessor
directives and remove the following make includecheck warning:
asm-generic/pgtable-nopud.h is included more than once
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
arch/arm/include/asm/pgtable.h | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/arm/include/asm/pgtable.h b/arch/arm/include/asm/pgtable.h
index be91e376df79..6b986ef6042f 100644
--- a/arch/arm/include/asm/pgtable.h
+++ b/arch/arm/include/asm/pgtable.h
@@ -19,14 +19,13 @@ extern struct page *empty_zero_page;
#define ZERO_PAGE(vaddr) (empty_zero_page)
#endif
-#ifndef CONFIG_MMU
-
#include <asm-generic/pgtable-nopud.h>
+
+#ifndef CONFIG_MMU
#include <asm/pgtable-nommu.h>
#else
-#include <asm-generic/pgtable-nopud.h>
#include <asm/page.h>
#include <asm/pgtable-hwdef.h>
--
2.47.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [RESEND PATCH] arm/pgtable: Remove duplicate included header file
2024-12-25 12:30 [RESEND PATCH] arm/pgtable: Remove duplicate included header file Thorsten Blum
@ 2024-12-25 13:42 ` Mike Rapoport
0 siblings, 0 replies; 5+ messages in thread
From: Mike Rapoport @ 2024-12-25 13:42 UTC (permalink / raw)
To: Thorsten Blum
Cc: Russell King, David Hildenbrand, Andrew Morton, linux-arm-kernel,
linux-kernel
On Wed, Dec 25, 2024 at 01:30:35PM +0100, Thorsten Blum wrote:
> The header file asm-generic/pgtable-nopud.h is included whether
> CONFIG_MMU is defined or not.
>
> Include it only once before the #ifndef/#else/#endif preprocessor
> directives and remove the following make includecheck warning:
>
> asm-generic/pgtable-nopud.h is included more than once
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Reviewed-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
> ---
> arch/arm/include/asm/pgtable.h | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/include/asm/pgtable.h b/arch/arm/include/asm/pgtable.h
> index be91e376df79..6b986ef6042f 100644
> --- a/arch/arm/include/asm/pgtable.h
> +++ b/arch/arm/include/asm/pgtable.h
> @@ -19,14 +19,13 @@ extern struct page *empty_zero_page;
> #define ZERO_PAGE(vaddr) (empty_zero_page)
> #endif
>
> -#ifndef CONFIG_MMU
> -
> #include <asm-generic/pgtable-nopud.h>
> +
> +#ifndef CONFIG_MMU
> #include <asm/pgtable-nommu.h>
>
> #else
>
> -#include <asm-generic/pgtable-nopud.h>
> #include <asm/page.h>
> #include <asm/pgtable-hwdef.h>
>
> --
> 2.47.1
>
--
Sincerely yours,
Mike.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [RESEND PATCH] arm/pgtable: Remove duplicate included header file
@ 2025-01-07 10:47 Thorsten Blum
0 siblings, 0 replies; 5+ messages in thread
From: Thorsten Blum @ 2025-01-07 10:47 UTC (permalink / raw)
To: Russell King, Mike Rapoport (Microsoft), David Hildenbrand,
Thorsten Blum, Andrew Morton
Cc: linux-arm-kernel, linux-kernel
The header file asm-generic/pgtable-nopud.h is included whether
CONFIG_MMU is defined or not.
Include it only once before the #ifndef/#else/#endif preprocessor
directives and remove the following make includecheck warning:
asm-generic/pgtable-nopud.h is included more than once
Reviewed-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
arch/arm/include/asm/pgtable.h | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/arm/include/asm/pgtable.h b/arch/arm/include/asm/pgtable.h
index be91e376df79..6b986ef6042f 100644
--- a/arch/arm/include/asm/pgtable.h
+++ b/arch/arm/include/asm/pgtable.h
@@ -19,14 +19,13 @@ extern struct page *empty_zero_page;
#define ZERO_PAGE(vaddr) (empty_zero_page)
#endif
-#ifndef CONFIG_MMU
-
#include <asm-generic/pgtable-nopud.h>
+
+#ifndef CONFIG_MMU
#include <asm/pgtable-nommu.h>
#else
-#include <asm-generic/pgtable-nopud.h>
#include <asm/page.h>
#include <asm/pgtable-hwdef.h>
--
2.47.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [RESEND PATCH] arm/pgtable: Remove duplicate included header file
@ 2025-02-04 15:55 Thorsten Blum
0 siblings, 0 replies; 5+ messages in thread
From: Thorsten Blum @ 2025-02-04 15:55 UTC (permalink / raw)
To: Russell King, Mike Rapoport (Microsoft), Thorsten Blum,
David Hildenbrand, Andrew Morton
Cc: linux-arm-kernel, linux-kernel
The header file asm-generic/pgtable-nopud.h is included whether
CONFIG_MMU is defined or not.
Include it only once before the #ifndef/#else/#endif preprocessor
directives and remove the following make includecheck warning:
asm-generic/pgtable-nopud.h is included more than once
Reviewed-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
arch/arm/include/asm/pgtable.h | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/arm/include/asm/pgtable.h b/arch/arm/include/asm/pgtable.h
index be91e376df79..6b986ef6042f 100644
--- a/arch/arm/include/asm/pgtable.h
+++ b/arch/arm/include/asm/pgtable.h
@@ -19,14 +19,13 @@ extern struct page *empty_zero_page;
#define ZERO_PAGE(vaddr) (empty_zero_page)
#endif
-#ifndef CONFIG_MMU
-
#include <asm-generic/pgtable-nopud.h>
+
+#ifndef CONFIG_MMU
#include <asm/pgtable-nommu.h>
#else
-#include <asm-generic/pgtable-nopud.h>
#include <asm/page.h>
#include <asm/pgtable-hwdef.h>
--
2.48.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [RESEND PATCH] arm/pgtable: Remove duplicate included header file
@ 2025-02-19 11:24 Thorsten Blum
0 siblings, 0 replies; 5+ messages in thread
From: Thorsten Blum @ 2025-02-19 11:24 UTC (permalink / raw)
To: Russell King, Mike Rapoport (Microsoft), Andrew Morton,
David Hildenbrand, Thorsten Blum
Cc: linux-arm-kernel, linux-kernel
The header file asm-generic/pgtable-nopud.h is included whether
CONFIG_MMU is defined or not.
Include it only once before the #ifndef/#else/#endif preprocessor
directives and remove the following make includecheck warning:
asm-generic/pgtable-nopud.h is included more than once
Reviewed-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
arch/arm/include/asm/pgtable.h | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/arm/include/asm/pgtable.h b/arch/arm/include/asm/pgtable.h
index be91e376df79..6b986ef6042f 100644
--- a/arch/arm/include/asm/pgtable.h
+++ b/arch/arm/include/asm/pgtable.h
@@ -19,14 +19,13 @@ extern struct page *empty_zero_page;
#define ZERO_PAGE(vaddr) (empty_zero_page)
#endif
-#ifndef CONFIG_MMU
-
#include <asm-generic/pgtable-nopud.h>
+
+#ifndef CONFIG_MMU
#include <asm/pgtable-nommu.h>
#else
-#include <asm-generic/pgtable-nopud.h>
#include <asm/page.h>
#include <asm/pgtable-hwdef.h>
--
2.48.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-02-19 11:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-25 12:30 [RESEND PATCH] arm/pgtable: Remove duplicate included header file Thorsten Blum
2024-12-25 13:42 ` Mike Rapoport
-- strict thread matches above, loose matches on Subject: below --
2025-01-07 10:47 Thorsten Blum
2025-02-04 15:55 Thorsten Blum
2025-02-19 11:24 Thorsten Blum
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).