From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9ECDDE77199 for ; Wed, 8 Jan 2025 10:10:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IM18OvxnC2Fka89jFAwkpiq2it51EwQpNq/r7/+W1qM=; b=29r1yUsPNyHec7U9n+IpYXcKc6 DbMngLd/97B/blu5a/jDIca4Sn5SvJG0ocq9FAEnnmHCIjAaeKb5k0dmS+922T/i/myl8xF+KhKmS lajePofA5hLLbdsRQ1f1hcwuJPZY4piUdbQaoDo5L66+aOX7ZAu0Zx6TZlvcqNwLdJvoRLuiJPuu/ 6yaYfLvJZqgUZ0GxY20BnHKt5PXkSNUcCe+NtN+51jDFnIHd1pV5g3xnvjNIgJ+jRvtqF5yH8K2NZ lBh7fFIqJsl1aKalpsyfVkRsp3lcP/VRV/U5u3uAI2yt1GDCvQOmRs/ocMTR5nUP7YmDEbxNcnJWl S+zTaGgw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tVT1C-00000007vPu-34Ee; Wed, 08 Jan 2025 10:10:30 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tVSyi-00000007ucc-1hXA for linux-arm-kernel@lists.infradead.org; Wed, 08 Jan 2025 10:07:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=IM18OvxnC2Fka89jFAwkpiq2it51EwQpNq/r7/+W1qM=; b=PtfGjMV6PHxFkPsIypAGiLRCK7 iqSLKC1OGaVkSIc8VVHCRlTTXaizu2k7rcfRIJjTlqFwILbKNa+VgN5x8UW1RNQQToDvD3IKqKYqQ UdTuwFuXYn3RncFb9zrzkwGJLE31h4YZKzdi6nDvgJYFZrld1MxZAJe2nDd4rOIxGaCcXK7RINXmc I+/+RybMotW6qFPVCbjkW/6c27C9Xj6uo+IxXx7ZHQGOhM69/3PTT+6fJA0oflXXNC0PcM3lVH/h7 yl4bYMAx9fq62wORkA5tZU8aezNa97S0XYoA4XIByJsA4JNMAwosQooWALZ8SlU9DLvTzM/mgUM/U gziQYczw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:60424) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tVSyU-0000Lv-2r; Wed, 08 Jan 2025 10:07:42 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.96) (envelope-from ) id 1tVSyP-0006Bv-0q; Wed, 08 Jan 2025 10:07:37 +0000 Date: Wed, 8 Jan 2025 10:07:37 +0000 From: "Russell King (Oracle)" To: Choong Yong Liang Cc: Andrew Lunn , Heiner Kallweit , Alexandre Torgue , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Jose Abreu , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Coquelin , netdev@vger.kernel.org, Paolo Abeni Subject: Re: [PATCH net-next v3 02/18] net: stmmac: move tx_lpi_timer tracking to phylib Message-ID: References: <66b95153-cb12-494d-851c-093a0006547f@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <66b95153-cb12-494d-851c-093a0006547f@linux.intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250108_020756_443930_B24D24FF X-CRM114-Status: GOOD ( 13.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Wed, Jan 08, 2025 at 03:36:57PM +0800, Choong Yong Liang wrote: > I have completed the sanity test on the EEE changes to the stmmac driver. > > It seems that most of the changes are acceptable with respect to EEE behavior. > > However, I noticed that this part of the code requires a minor change to fix > the logic: > > /* Configure phylib's copy of the LPI timer */ > if (phylink_ethtool_get_eee(priv->phylink, &eee) == 0) { > eee.tx_lpi_timer = priv->tx_lpi_timer; > phylink_ethtool_set_eee(priv->phylink, &eee); > } > > Otherwise, the "tx_lpi_timer" will not be set correctly during the initial > state. > > Tested-by: Choong Yong Liang Thanks for testing. I can't update the series as there has been a power failure at home, hence the machine that has my git trees on is inaccessible at the moment. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!