* [PATCH] ARM: orion/gpio: Use str_hi_lo() and str_lo_hi() helpers
@ 2024-12-26 23:10 Thorsten Blum
2025-01-02 10:55 ` Russell King (Oracle)
0 siblings, 1 reply; 2+ messages in thread
From: Thorsten Blum @ 2024-12-26 23:10 UTC (permalink / raw)
To: Andrew Lunn, Sebastian Hesselbarth, Gregory Clement, Russell King
Cc: Thorsten Blum, linux-arm-kernel, linux-kernel
Remove hard-coded strings by using the str_hi_lo() and str_lo_hi()
helper functions.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
arch/arm/plat-orion/gpio.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/plat-orion/gpio.c b/arch/arm/plat-orion/gpio.c
index 595e9cb33c1d..31cc42345b82 100644
--- a/arch/arm/plat-orion/gpio.c
+++ b/arch/arm/plat-orion/gpio.c
@@ -466,14 +466,14 @@ static void orion_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip)
if (is_out) {
seq_printf(s, " out %s %s\n",
- out & msk ? "hi" : "lo",
+ str_hi_lo(out & msk),
blink & msk ? "(blink )" : "");
continue;
}
seq_printf(s, " in %s (act %s) - IRQ",
- (data_in ^ in_pol) & msk ? "hi" : "lo",
- in_pol & msk ? "lo" : "hi");
+ str_hi_lo((data_in ^ in_pol) & msk),
+ str_lo_hi(in_pol & msk));
if (!((edg_msk | lvl_msk) & msk)) {
seq_puts(s, " disabled\n");
continue;
--
2.47.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: orion/gpio: Use str_hi_lo() and str_lo_hi() helpers
2024-12-26 23:10 [PATCH] ARM: orion/gpio: Use str_hi_lo() and str_lo_hi() helpers Thorsten Blum
@ 2025-01-02 10:55 ` Russell King (Oracle)
0 siblings, 0 replies; 2+ messages in thread
From: Russell King (Oracle) @ 2025-01-02 10:55 UTC (permalink / raw)
To: Thorsten Blum
Cc: Andrew Lunn, Sebastian Hesselbarth, Gregory Clement,
linux-arm-kernel, linux-kernel
On Fri, Dec 27, 2024 at 12:10:52AM +0100, Thorsten Blum wrote:
> Remove hard-coded strings by using the str_hi_lo() and str_lo_hi()
> helper functions.
This description is missing the reason why its desirable to make this
change.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-01-02 10:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-26 23:10 [PATCH] ARM: orion/gpio: Use str_hi_lo() and str_lo_hi() helpers Thorsten Blum
2025-01-02 10:55 ` Russell King (Oracle)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).