From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D2FDFE7718F for ; Fri, 3 Jan 2025 15:12:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=p5rZBuOmnh2gC1AclxcLBgFsso+YsuVkAi17D+HrYTM=; b=sE8kqVp6JX0wOMB3BlI3B7Cpdj Dp7AUPxVba3tAwQrXXWGQfeSdpnOWPzCIUe0IFUHi0W1yllLuJr/Qt1NNEp5nvQ9qn69RU2v9jtFb RNi7LbGuJw6mKEMXPre7tmabo7CNKZGDZdRPjAcvsqi10RCTwSES6QZ9UgHreqiD6BHoCPaXZJP07 7uRDEkWwr5PBJ0bt6D/pcP1WNVeTCnPP2I3rk1N5N5/xqhALnymmVDWWPLfRvFFQ+ble7KT2JStYk gT6ShOEaxtNwbm91ARzmPJbUMyUVW1EUoN3CCzPDqLS13CHpjaMs6yVfLELHiEcBZWbkOMrI9C57c KQve0CWg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tTjL4-0000000DEBB-2sqk; Fri, 03 Jan 2025 15:11:50 +0000 Received: from nyc.source.kernel.org ([147.75.193.91]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tTjJr-0000000DDzM-0aSp; Fri, 03 Jan 2025 15:10:36 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 30BA4A40BE4; Fri, 3 Jan 2025 15:08:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ABE5FC4CECE; Fri, 3 Jan 2025 15:10:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1735917034; bh=1BF/6cjFkwRL519wCuap2QXMjEYM9CYI1Dk9qxzXxNc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vJ/ApSphiN0qvPN/WMJ+exnXwCvG9WFvpjWQRoBQBZcqsyUjnn18nMvnIqLGZ06lY +RkGa0cC+t7uOFJ9JqNsid9tEeuhCrAL4pSp+0I0uo5PX6AdEdoKAoQjDW+BIde+WY tYCOHmN4MlLC1J28eVTXF9UpQl6y3EroHLu0La2eGSpxkG/4HK2kgo3+OYe8vc9AV2 4dmKOA9ZuekWiaIfZKGzZkCj5MVDFG4gYtk13UX+CvrBswD5Jm6BnuGdByRhMBBWv9 Y+UmfzAfmios8vQXrVYmdKi5yxQAFjh7HnvXID8K7LQ5O7TzO+VGIWNlQSiIzk1aub fLGO436FH22rw== Date: Fri, 3 Jan 2025 16:10:29 +0100 From: Niklas Cassel To: Anand Moon Cc: Manivannan Sadhasivam , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Heiko Stuebner , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] PCI: dw-rockchip: Enable async probe by default Message-ID: References: <20240809073610.2517-1-linux.amoon@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250103_071035_240197_2F81CECD X-CRM114-Status: GOOD ( 16.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jan 03, 2025 at 08:36:18PM +0530, Anand Moon wrote: > > > > > > We need to enable the GMAC PHY and reset it using the proper GPIO pin > > > (PCIE_PERST_L). > > > Please refer to the schematic for more details. > > > > The PERST# GPIO is already asserted + deasserted from the PCIe Root Complex > > (host) driver: > > https://github.com/torvalds/linux/blob/v6.13-rc5/drivers/pci/controller/dwc/pcie-dw-rockchip.c#L191-L206 > > > > which will cause the endpoint device (a RTL8125 NIC in this case) > > to be reset during bootup. > > > Thanks for letting me know. It seems like a workaround. > I'll try to disable this and test it again. > > My point is that we haven't enabled the GMAC PHY (device nodes) > and must properly reset the GMAC. > > We're relying on the code above hack to do that job. I do not think it is a hack. If you look in most PCIe controller drivers, they toggle PERST before enumerating the bus: $ git grep gpiod_set_value drivers/pci/controller/ Kind regards, Niklas