From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 29541C02182 for ; Tue, 21 Jan 2025 15:24:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=STeVv6qQNXCq9BuLlPFYxut60XyAAxHh0l8SrIBLhLc=; b=O/1zHr4lUiZBDywNRvIvIsgXKC bluyC6MJPwH26vXlBNVBXSZ2vJ0EAih0alx1EzCve3awMnwXy+IaDOenQjKhTa1CVUs15y/8Giw21 6nr6PmnY0uyRBP1NVVX8g5YdnkX1DgSMYRY717iuJe1LbHs7ibHvN2tKml1kR2iSnZg0XrxUzpW0R TbkFvqOkgD0ZKF1MjT+jKPWxwm0BSb8ptc7TkRvgxlesxetSRyoGSKmfnFv6HSyRJnOcJNi0uMCC0 JbGbmGEUG2T+D5mpgRf2oeM9nfDYAwyzxNCUyP6gJOLjEY04SAuFihz6JTDfYENOmnrc4hKSaYd0C 0x6PceWg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1taG6d-00000008D3b-0fKj; Tue, 21 Jan 2025 15:23:55 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1taG0g-00000008C9x-2bqR for linux-arm-kernel@lists.infradead.org; Tue, 21 Jan 2025 15:17:47 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8270F12FC; Tue, 21 Jan 2025 07:18:14 -0800 (PST) Received: from arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E67B73F66E; Tue, 21 Jan 2025 07:17:40 -0800 (PST) Date: Tue, 21 Jan 2025 16:17:02 +0100 From: Beata Michalska To: Viresh Kumar Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, ionela.voinescu@arm.com, sudeep.holla@arm.com, will@kernel.org, catalin.marinas@arm.com, rafael@kernel.org, sumitg@nvidia.com, yang@os.amperecomputing.com, vanshikonda@os.amperecomputing.com, lihuisong@huawei.com, zhanjie9@hisilicon.com, Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H . Peter Anvin" , Phil Auld , x86@kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v9 2/5] cpufreq: Introduce an optional cpuinfo_avg_freq sysfs entry Message-ID: References: <20250121084435.2839280-1-beata.michalska@arm.com> <20250121084435.2839280-3-beata.michalska@arm.com> <20250121105355.sdrgmjv2w2256qfn@vireshk-i7> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250121105355.sdrgmjv2w2256qfn@vireshk-i7> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250121_071746_700993_0A0EB847 X-CRM114-Status: GOOD ( 19.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 21, 2025 at 04:23:55PM +0530, Viresh Kumar wrote: > On 21-01-25, 08:44, Beata Michalska wrote: > > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c > > index 6f45684483c4..b2a8efa83c98 100644 > > --- a/drivers/cpufreq/cpufreq.c > > +++ b/drivers/cpufreq/cpufreq.c > > @@ -733,12 +733,20 @@ __weak int arch_freq_get_on_cpu(int cpu) > > return -EOPNOTSUPP; > > } > > > > static ssize_t show_scaling_cur_freq(struct cpufreq_policy *policy, char *buf) > > { > > ssize_t ret; > > int freq; > > > > - freq = arch_freq_get_on_cpu(policy->cpu); > > + freq = IS_ENABLED(CONFIG_CPUFREQ_ARCH_CUR_FREQ) > > + ? arch_freq_get_on_cpu(policy->cpu) > > + : 0; > > + > > if (freq > 0) > > ret = sysfs_emit(buf, "%u\n", freq); > > else if (cpufreq_driver->setpolicy && cpufreq_driver->get) > > Maybe this should be a separate commit ? And also I am not very happy Initially it was supposed to be one, but then the rest of the series justifies the changes so it made sense to send those in one go. > with the new kconfig option. I don't want others to use it as we want > to get rid of this for X86 too eventually. Making it a kconfig option > allows anyone to enable it and then depend on it without us knowing.. > > Rather just write it as "if (x86)", with a comment on what we plan to > do with it in few release cycles. Right, those changes are based on discussion in [1]. --- [1] https://lore.kernel.org/all/CAJZ5v0gCRKzaFrwkoBpLHQUxoP_+jAyhMiCkLQaBUpduk9yxtA@mail.gmail.com/ --- BR Beata > > -- > viresh